Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Michael Welling <mwelling79@gmail.com>
Date:   Sun, 9 Apr 2023 15:52:46 -0500
From:   Michael Welling <mwelling@ieee.org>
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: iio: dac: mcp4922: add vdd-supply
 property
Message-ID: <ZDMlnj3+CpU4BPdt@deathstar>
References: <20230405140114.99011-1-frattaroli.nicolas@gmail.com>
 <20230405140114.99011-2-frattaroli.nicolas@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230405140114.99011-2-frattaroli.nicolas@gmail.com>
Precedence: bulk

On Wed, Apr 05, 2023 at 04:01:11PM +0200, Nicolas Frattaroli wrote:
> These chips have a vdd supply input, which should be modelled in
> the bindings as well. Vref is only the voltage reference supply for
> the string DAC.
> 
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

Acked-by: Michael Welling <mwelling@ieee.org>

> ---
>  .../devicetree/bindings/iio/dac/microchip,mcp4922.yaml        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> index 19374401e509..a3e80e90eeca 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> @@ -21,11 +21,14 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  vdd-supply: true
> +
>    vref-supply: true
>  
>  required:
>    - compatible
>    - reg
> +  - vdd-supply
>    - vref-supply
>  
>  allOf:
> @@ -42,6 +45,7 @@ examples:
>          dac@0 {
>              compatible = "microchip,mcp4912";
>              reg = <0>;
> +            vdd-supply = <&dac_reg>;
>              vref-supply = <&dac_vref>;
>          };
>      };
> -- 
> 2.40.0
>