Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3381553rwl; Sun, 9 Apr 2023 14:40:33 -0700 (PDT) X-Google-Smtp-Source: AKy350bnciYnM15RzjM+9E8rf0yCI4TJI4MBoK+I47LPK0Jl3zmPaF7qPyJE/PnkimN/ExpGIVKH X-Received: by 2002:a17:90b:3c49:b0:23f:b609:e704 with SMTP id pm9-20020a17090b3c4900b0023fb609e704mr7431683pjb.1.1681076432894; Sun, 09 Apr 2023 14:40:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681076432; cv=none; d=google.com; s=arc-20160816; b=H+q5QUJo+oBcFZYAmPz2YQIRYP7Zmc0o0ZX34cnJzcxIFeQeEbvCLeP/RQL6CKJy0D XPxPLLFnS7bO2v4BCWDkAw0bYYmvFePJyQ7qo9X+9Mt4gA1X/vRuMkti8BsZTTJ+EVVl Q5LgevYB0MarNFCsO/PgA3NEuYDbQyungfertzyADrBp+8buB8NoDt92vjrInJ4gqTy/ 5zTDoE2nUZ4pdHmrRFxvrpWZniY+2gon5H8TmPamLS4kPjj4PA/1M2/kt0LMSj6yyCgl HV1r9KzKwI2ksz+FbVPig2LJ4Fn+3yHGRGvLFP8wsyA/wML4wnb4ArfssMTiYaY81yNy ka0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=rYjszfZdIcFlvw/gOOPz9XiTbVxYxk5w+BqzIhUy+bE=; b=ZAKS66nMMQpU2NnQlW8Ot7/42yCDlkIMhLygb/ob67ZhrYLMaGlmBe/JCBZUMCtnUX Lk/id5+bagXI2hx8jMpXkLBr8U+2PI8RUZCHUkvYIFFl8MigB5WlCA+8EcepacWIdpzt lPO3xwg6G+IbkYTPgiH8j29mFpkI1sXq94NyKNTcWgA9HNum2vGseYGS7f65pPDYzRGY QEyxhiUHRO4hlRL9nTaRdGEpulECPmzT5ggm2ImuWMScuZLpM3T5Dt0L6AagQUmNKVzp WtzFerDqGV69oF/387WjJEZD6l/LUSFWxTkOE5S6vguunDt58PwtpMb+OwGdS4o3megd itng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="d/mrOeoK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk17-20020a17090b33d100b00244ae429c86si8808155pjb.36.2023.04.09.14.40.07; Sun, 09 Apr 2023 14:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="d/mrOeoK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbjDIU7f (ORCPT + 99 others); Sun, 9 Apr 2023 16:59:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbjDIU7e (ORCPT ); Sun, 9 Apr 2023 16:59:34 -0400 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDA072D4C for ; Sun, 9 Apr 2023 13:59:32 -0700 (PDT) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-54ef6ca60ceso58098777b3.3 for ; Sun, 09 Apr 2023 13:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681073972; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rYjszfZdIcFlvw/gOOPz9XiTbVxYxk5w+BqzIhUy+bE=; b=d/mrOeoKL0OlBPafapAnDGixxdLfdyADkQLv+Ua2kG7yhbZVHtFc9ETB8RGLrd27Ap Dyk8PNsg7tIuWbzhMdAmpDHBx8lZjfMXygqPy0J1qlyUnvHYoD2t/TcnZI/EtcSMFONa vGeKS6QFi70+ryohE6/BJ59MI8i8CYYkYeiSZ4m/c/aux1wjejdvxlTHHBjj/O6x8KHu 2kFlCQ6nAHFhSd9GOcKOoAz514uKbtCkPBNEdlNupO4hlEoB4+1syUYqu3IdAztVgozt qAAKmUGignwNN60l7MeqMBeo/DUuPKKMBH9vsOuj5J4byGrKXw/4Dx0M4/Z1J4g7r5Nb PdtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681073972; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rYjszfZdIcFlvw/gOOPz9XiTbVxYxk5w+BqzIhUy+bE=; b=N2FF0Lbp9WerOd3D2LXGmYOc7FhktRKeySmRNnUk51lqQUrIaP2efd74qR1j0bzwOQ Pbb7kfQNt+Pxue3ma9HYhRwXozYACa/aFaF0WrA1CqC2HONa3vg1a8dOMFH9jERqBFlk HouhqzDC0AaZSCIQO/LCUEQcrTaq9slzpCxYjsUyaD6navhBMnkPzbNHrLfDYCO0Jul1 S/CB3NKcgKtTViXrkiBkZTKBNU7OFkmmRamO09q4s6DsfcAakLVAmVylEdJF1CZh16hp pOObbdt4Xy1mnKoRgfLFvNO8KIIxSeDNEtwKc8wFA5rYBu4tUNB39xdI9Zy6VGHhMdu3 YgCw== X-Gm-Message-State: AAQBX9cJLvz+K3tFohe0+9J6nrvvVqL3OJ+a1g0PvWwFM+WpLiz4yQap FLkOFHG+LeeFV4Z3BHcWgsLN5PXbmGyfrPJdHYOuDg== X-Received: by 2002:a05:690c:1:b0:544:bbd2:74be with SMTP id bc1-20020a05690c000100b00544bbd274bemr5923049ywb.4.1681073972033; Sun, 09 Apr 2023 13:59:32 -0700 (PDT) MIME-Version: 1.0 References: <20230102094733.3966825-1-linmq006@gmail.com> In-Reply-To: <20230102094733.3966825-1-linmq006@gmail.com> From: Linus Walleij Date: Sun, 9 Apr 2023 22:59:20 +0200 Message-ID: Subject: Re: [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init To: Miaoqian Lin Cc: Russell King , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, SUSPICIOUS_RECIPS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 2, 2023 at 10:47=E2=80=AFAM Miaoqian Lin w= rote: > of_irq_find_parent() returns a node pointer with refcount incremented, > We should use of_node_put() on it when not needed anymore. > Add missing of_node_put() in the error path to avoid refcount leak. > > Fixes: cd931dcfda5e ("ARM: ux500: Initial support for PM domains") > Signed-off-by: Miaoqian Lin Patch applied. Sorry for forgetting about this patch! Yours, Linus Walleij