Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230407081021.30952-1-gautam.dawar@amd.com> <20230409091325.GF14869@unreal>
In-Reply-To: <20230409091325.GF14869@unreal>
From:   Jason Wang <jasowang@redhat.com>
Date:   Mon, 10 Apr 2023 09:39:38 +0800
Message-ID: <CACGkMEur1xkFPxaiVVhnZqHzUdyyqw6a0vw=GHpYKJM7U3cj7Q@mail.gmail.com>
Subject: Re: [PATCH net-next v4 00/14] sfc: add vDPA support for EF100 devices
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Gautam Dawar <gautam.dawar@amd.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-net-drivers@amd.com,
        Edward Cree <ecree.xilinx@gmail.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        eperezma@redhat.com, harpreet.anand@amd.com, tanuj.kamde@amd.com,
        koushik.dutta@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Apr 9, 2023 at 5:13=E2=80=AFPM Leon Romanovsky <leon@kernel.org> wr=
ote:
>
> On Fri, Apr 07, 2023 at 01:40:01PM +0530, Gautam Dawar wrote:
> > Hi All,
> >
> > This series adds the vdpa support for EF100 devices.
> > For now, only a network class of vdpa device is supported and
> > they can be created only on a VF. Each EF100 VF can have one
> > of the three function personalities (EF100, vDPA & None) at
> > any time with EF100 being the default. A VF's function personality
> > is changed to vDPA while creating the vdpa device using vdpa tool.
>
> Jakub,
>
> I wonder if it is not different approach to something that other drivers
> already do with devlink enable knobs (DEVLINK_PARAM_GENERIC_ID_ENABLE_*)
> and auxiliary bus.

I think the auxiliary bus fits here, and I've proposed to use that in
V2 of this series.

Thanks

>
> Thanks
>