Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de25219b-2f7e-1e7b-ebad-70287ee4c28f@amlogic.com>
Date:   Mon, 10 Apr 2023 10:00:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 07/32] perf/amlogic: Assign parents for event_source
 devices
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org
Cc:     linuxarm@huawei.com, Dan Williams <dan.j.williams@intel.com>,
        Shaokun Zhang <zhangshaokun@hisilicon.com>,
        Yicong Yang <yangyicong@hisilicon.com>,
        Khuong Dinh <khuong@os.amperecomputing.com>,
        Robert Richter <rric@kernel.org>,
        Atish Patra <atishp@atishpatra.org>,
        Anup Patel <anup@brainfault.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Frank Li <Frank.li@nxp.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Vineet Gupta <vgupta@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Dave Jiang <dave.jiang@intel.com>, Wu Hao <hao.wu@intel.com>,
        Tom Rix <trix@redhat.com>, linux-fpga@vger.kernel.org,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Liang Kan <kan.liang@linux.intel.com>
References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com>
 <20230404134225.13408-8-Jonathan.Cameron@huawei.com>
From:   Jiucheng Xu <Jiucheng.Xu@amlogic.com>
In-Reply-To: <20230404134225.13408-8-Jonathan.Cameron@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDRBeGMvR2ZZQ1lIL2htQjBJZ3BrU1l2L04wR0pnMTVpbXA3VTdOSzZMQkwz?=
 =?utf-8?B?Q3NZWnJ6ZW03WUhqSzEyQnU1U0xxYXZBQ0dTKzNRSTZTckxNNnV3OXZvNk11?=
 =?utf-8?B?YUs0VExXNGg5Z1hHVDlkWTUzcVpqemlHTHdEaVV0M1MyT2ZteU9heVFlMGoy?=
 =?utf-8?B?T203SXJEY1hBYTFWNThWRWJlSmc0dFhpTkowNGZyTy9yd0VlNzV1dUF5ZVZN?=
 =?utf-8?B?L1lCcVYyb1NZTnJZNS9HamY1WjNnVlBRK2RWVVhjZ2pkMDhlcTRYSnVxb3Jz?=
 =?utf-8?B?d3NVVjRSR0k3cXRNdlJpQ3BJcnZ0UWlLMVgxekFZdEZadlF3S2t0UGxtemRs?=
 =?utf-8?B?RXQwUFBOQ3pXNUt5UklMMElxVDljelBpQ3VBYXAwYld3Tk0wcUlLVW14OGlo?=
 =?utf-8?B?Uk9mTElFdlJlMjhLTHhndWZ3RkJHKzhGVE03ckVqaWNXSU5RZitPUmFYaHh5?=
 =?utf-8?B?REpCV2VaSFl4em40dFR6WXl0V0UybVpZeGRtdHU1enhNR3hqWXVtTUs5TWRO?=
 =?utf-8?B?b2M0M25QZkFCMWhXeEFrQnBpMVYwendzejhSVTR5Q3JsVDNNZXFDTk5FT2RR?=
 =?utf-8?B?YVJiYUI0WXlFbUJwZytSTmZDK04rdGVwcHB4QUp4cHlHdDl0Y1MzMUVFK212?=
 =?utf-8?B?QzNVSXZvQ0twRHRBZlh5TmF6WUM0NFcwajRYWEJET3lJVUZCZTBPV1RVV2s3?=
 =?utf-8?B?WkJTZXhFR1hRWWdvT2ZQMmJ2ZmRvWEZlaEw4NGx3L2pjZW44NG1ja0JPdTRR?=
 =?utf-8?B?NUhqS2c0ZzMyNXVNbWdxUC95OXQ0VDVoTll0a2RGdWR5ZHg5aUtWYWU0bTl5?=
 =?utf-8?B?ZnBSMHFRZTB5WmlTUW5IdEM2YXBqTm91TDcxaS9jSzFyWFpxbmkxWlB2SHpY?=
 =?utf-8?B?NFkwcnJrSjBJbkVkTmQ3NU52UUVxVzJvaG1FKzR1SmtJeG1VbzNYRCtrM3F5?=
 =?utf-8?B?S1F1TGJhWW1MK0tGWDhOczVOd0NDaVVkRXJsSXZFTHBzd1J4VEtONUs2NjBF?=
 =?utf-8?B?Q1RFKzNQRXEwYXBobWcrL3VTQUg5YzNGSW5Zcmc4aTlaT3JEY2JDclNmRjht?=
 =?utf-8?B?NnROZUU1cG1pekVvQlpJSmtOR3prcWxPYlNPZXVYSHM4WmI5dUFLcUszRWpE?=
 =?utf-8?B?M05zMzNBdW1NeXNTcWVRV0p2VEw1dE9UZzB2Y1F0SWlEZW5DeWg2a1dadW0y?=
 =?utf-8?B?SXZ6VHdENzBTUWpTUUdZbUVrdENMcW1VRGdHcnFVMlFjdXNycDFSaDRvMWYr?=
 =?utf-8?B?UVo3SGJ3TFI3Nlh2RjRxMDVqbTZaTGlwWnNLbkp1d3dqNDU5QXMxMnRHNGxp?=
 =?utf-8?B?aGI2OTVUV0FpTHAzUkM0dFd1VVRVbDVlOGtSaCtISDA2WWcwNnowZHRYREhW?=
 =?utf-8?B?Skc2d3E3cmJxOFpVYnAzcFUzK0FjMHMzRDd2WEYxcUswUEhMcTJFRExXNWM4?=
 =?utf-8?B?QkU1R1Q2R2NIaXA5R2owRnk2UE5kL2VXWmFVbVMwQjczR0lsQS9Oc1J1SlFJ?=
 =?utf-8?B?WlJIT1pvSWxES29pd3BTZWRLVTd3dEJ2MEtHUzNyNktUYmNqS2IxOWRGOStr?=
 =?utf-8?B?WkZ0S0pPck5iWGswS2VQQXlDUlNpL2FSVWFSTHAwRVNvbEFUeGt4WGlPUlF6?=
 =?utf-8?B?SXlFa2poVTFzVUxPbkpWdkpXd0RFQ2pmZ09haG1XTXM4a2cvbUI1NFF5Vlcr?=
 =?utf-8?B?U3Zoc3g1cWZlc2Q2S1dkbDIzMHNXeTNHVGFSWm56d3YvWWJDZVZBTGcrbzlO?=
 =?utf-8?B?NmpZbDAvc3Q5ZU1tMmNkbFhBL0k1R0lnT0FOZGF4MDlvQ0YzdXNMbDgxdGFm?=
 =?utf-8?B?TjFNaUp0Zk9nRGtwYkxDRnlCdmdRbGltOTdZc3RKQXBnZzFLcVd1TUNpc2o5?=
 =?utf-8?B?Z3hCZHVxcDM4REF1dEh2eHNBR1RWMVpOalZmUHRTZ2FLcG4xejlXVi9VaUdJ?=
 =?utf-8?B?RlMwRVNpYWNYaW5Ua09nOW5XYzh0cEJFWVVBR0N5R1ZHblB0cXd6RXYyNzRp?=
 =?utf-8?B?UUNpNkNYckJIUHNta2hVMHNtcVJmYW92WU4zZFE0TXZMN0oxdFVEaXl1M3hS?=
 =?utf-8?B?cW14MjBMMzVxRTJGdlFMeUxJaEtac0FHU2c0bDJTUGE4QmUyQWpmTmRxZCtJ?=
 =?utf-8?B?dlVPclp0dnZsbTQ1dFlteVZPbUZ2RGp4Tnl3OVhlbDEvQXF2NzlDejRkS2h6?=
 =?utf-8?B?WWc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 216fc914-f088-4bdf-af84-08db396730f3
X-MS-Exchange-CrossTenant-AuthSource: TYUPR03MB7232.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 01:59:17.4660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6095LAkJfwCU6KtEc4UBEwZVbNefr+0B+S2q+mMg21B66duFW/YoVU/hkcKnZSiPtesde5uG4ML+7Zn9SbPA5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB6761
X-Spam-Status: No, score=-2.9 required=5.0 tests=NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/4/4 21:42, Jonathan Cameron wrote:
> [ EXTERNAL EMAIL ]
>
> Currently all these devices appear directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parents to be the platform device.
>
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Cc: Jiucheng Xu <jiucheng.xu@amlogic.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>   drivers/perf/amlogic/meson_ddr_pmu_core.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/amlogic/meson_ddr_pmu_core.c b/drivers/perf/amlogic/meson_ddr_pmu_core.c
> index b84346dbac2c..e0d3e87457e0 100644
> --- a/drivers/perf/amlogic/meson_ddr_pmu_core.c
> +++ b/drivers/perf/amlogic/meson_ddr_pmu_core.c
> @@ -490,6 +490,7 @@ int meson_ddr_pmu_create(struct platform_device *pdev)
>   	*pmu = (struct ddr_pmu) {
>   		.pmu = {
>   			.module		= THIS_MODULE,
> +			.parent		= &pdev->dev,
Reviewed-by: Jiucheng Xu <jiucheng.xu@amlogic.com
>   			.capabilities	= PERF_PMU_CAP_NO_EXCLUDE,
>   			.task_ctx_nr	= perf_invalid_context,
>   			.attr_groups	= attr_groups,