Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net PATCH v2 3/7] octeontx2-af: Add validation for lmac type
Thread-Topic: [net PATCH v2 3/7] octeontx2-af: Add validation for lmac type
Thread-Index: AQHZa3LRnlELUOX5YEe4p+msHli3lQ==
Date:   Mon, 10 Apr 2023 06:08:07 +0000
Message-ID: <BY3PR18MB4707056861A499D736B1354EA0959@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-4-saikrishnag@marvell.com>
 <20230409173015.GK182481@unreal>
In-Reply-To: <20230409173015.GK182481@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g6kC+xTj4rBuBZWtccMLI9A7WU6CY1T79vTPV2m18ksNUQ8sw3DPGmPXFBFJ?=
 =?us-ascii?Q?m8GojT8P0Xgv6wYPntYNsIxfocuWeHHy7Qxg56rSaJCPd9nR1E2uORzAjyuI?=
 =?us-ascii?Q?o4VHh5MJuXo6StxOyI2G0IZZ0EXnvojMcXJNJ2JZk2yVpWF60bzv9VrdSOQ+?=
 =?us-ascii?Q?5TJKEehq9WyUowjnlBN+GWqeKZ5jMbuMJZqF60lordBRjLGb+f8a1ogNH5oL?=
 =?us-ascii?Q?zfFqKRipTaC3/qVQ2FMdrD3i13HlrI9r4A0OvhktCHyMickk4tPKI0VESswB?=
 =?us-ascii?Q?M7HukVDU3KdTZBAhYAystj0tB2uULPGoj0zgeQ+9ClE8qRbpUEH/n7u8PUCA?=
 =?us-ascii?Q?X7Sgnlt9y8To+dsR6hJnMQTa6oOqNbXHgANvFz6D8hHjMubfbl3Omg8pvD54?=
 =?us-ascii?Q?8C9ZcS+XwGDmEmCdCrTCniw8PGvDxgz05QgSBOxodv9sivdUq5hcSPXzPDrE?=
 =?us-ascii?Q?vEZjhIVdgpV+dIWqIo6ZOswJtoTzSHMpcG5sFrUbLhJ8RztcCrwRZZIIztTg?=
 =?us-ascii?Q?OkrmefY0+2eJqUWoJFXS7nrKvART6TUlix6BJo8Fr25BXxd/a333GTrHvLOZ?=
 =?us-ascii?Q?fPHOVP/aJbfAGKT8u7+XFwDCnUL/+GWxORi8UBkbn2DttE6e0McaJMklVXtF?=
 =?us-ascii?Q?QgfZb7aEoGmziRQN6wSBfPXqyYG4/aURG918EfjOD/lLm9gInn5Y7RgyURbg?=
 =?us-ascii?Q?OInpDZP4pX7uTEIC/4nJnUm6bPENrBGCQfP6PL5g4a9scRQnkTyVdPkIIJMA?=
 =?us-ascii?Q?2j4/THzVxm5tVOa5jNlpJ74K+jz+9k/xHUVU8MotDBOKUNe9hqvZeZcBCJhR?=
 =?us-ascii?Q?32Qu/oy65wO5gYH2hbv+6LhT5MXLJHdXEhO0Rc9uaBgOCzDQwXhIRkJwNj8H?=
 =?us-ascii?Q?JdMGhEwjDIv5TCJe3c9VjYzuOE8UqamhopSrnal0WAgKdxr+0A5Dw+MWP3Yh?=
 =?us-ascii?Q?K0kLTnF9tRoSJ658NYpU6cp5r3btloqMOS6dCGg4k4/kUOj1Y1k4fznntD3X?=
 =?us-ascii?Q?oy1bqXUNP1KPBLhYJzBIhNHf9AoMid/9Sqbj8+bvHqr/VOZ5ruZgPtl5AMgE?=
 =?us-ascii?Q?JKGUX04RVT3nQOKS0/m/tfL3oiPIekqFEwNm7Z89F+dUJl5I3ebkpZsF/4p+?=
 =?us-ascii?Q?bGno/H3XYK/6ZrxIQHamyjmQL5bW7/Oc0cRJm8RR02+yS0rGLjgmsUi4pZa8?=
 =?us-ascii?Q?Ci5FY4RoOaaqlj56ncifpPEKAeBLw4JH3kjCfLCp7giIQzk+T9v+7yKWh1Z8?=
 =?us-ascii?Q?b4s7biuK8dRwnKE9rbuqeFJ3Ge35l3SmLgiSA9E9zwM07pKM5DErvlDUa6LU?=
 =?us-ascii?Q?X6fsruYkSAl0GL7D1+QPSoppJiA4DhwEuZkN5YENjBbDSIUeZZ9ECV7ro6Yz?=
 =?us-ascii?Q?adwrR3mOAtDeedkQ5qzs9prSTGEGgmVU0AHqdKk8DEfAlZQTZ37d9Ld7b54m?=
 =?us-ascii?Q?kDsqichYyl5XRl1qoFliSlwqYs02n618u+Eairte+8itqU7hB05kBqjfkLMS?=
 =?us-ascii?Q?2ttxcNgInlQyPVwh9cPv2PK+/7EOh14hOL0hGWWt+zgmlclEu9VAyk58hPFI?=
 =?us-ascii?Q?6eS70cQyMwAKmAyWBw3UdYeBlgfEQhOUuzVEkwNb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3949f8b1-42b3-4186-b968-08db3989f466
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2023 06:08:07.6492
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UGTkp5f3+JgRMaM4aPnI1FRYaiyhvUwF25AoG4rn2+a1zgvqBnf99SxoKhgmZcdwY2f7aia/7LNOPVJVjGwFtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB5532
X-Proofpoint-ORIG-GUID: 1yNZ6lseqOgT3WIACCjtx9q-CoaYnMmS
X-Proofpoint-GUID: 1yNZ6lseqOgT3WIACCjtx9q-CoaYnMmS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-10_03,2023-04-06_03,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline,

> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Sunday, April 9, 2023 11:00 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; richardcochran@gmail.com;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net PATCH v2 3/7] octeontx2-af: Add validation for lmac
> type

> On Fri, Apr 07, 2023 at 05:53:40PM +0530, Sai Krishna wrote:
> > From: Hariprasad Kelam <hkelam@marvell.com>
> >
> > Upon physical link change, firmware reports to the kernel about the
> > change along with the details like speed, lmac_type_id, etc.
> > Kernel derives lmac_type based on lmac_type_id received from firmware.
> >
> > In a few scenarios, firmware returns an invalid lmac_type_id, which is
> > resulting in below kernel panic. This patch adds the missing
> > validation of the lmac_type_id field.
> >
> > Internal error: Oops: 96000005 [#1] PREEMPT SMP
> > [   35.321595] Modules linked in:
> > [   35.328982] CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted
> > 5.4.210-g2e3169d8e1bc-dirty #17
> > [   35.337014] Hardware name: Marvell CN103XX board (DT)
> > [   35.344297] Workqueue: events work_for_cpu_fn
> > [   35.352730] pstate: 40400089 (nZcv daIf +PAN -UAO)
> > [   35.360267] pc : strncpy+0x10/0x30
> > [   35.366595] lr : cgx_link_change_handler+0x90/0x180
> >
> > Fixes: 61071a871ea6 ("octeontx2-af: Forward CGX link notifications to
> > PFs")
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> >
>=20
> Your patch missing --- trailers and probably won't apply correctly.
>=20
We will fix trailers errors in V3 patch.

Thanks,
Sai
> Thanks
>=20
> >  drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > index 724df6398bbe..bd77152bb8d7 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > @@ -1231,6 +1231,14 @@ static inline void link_status_user_format(u64
> lstat,
> >  	linfo->an =3D FIELD_GET(RESP_LINKSTAT_AN, lstat);
> >  	linfo->fec =3D FIELD_GET(RESP_LINKSTAT_FEC, lstat);
> >  	linfo->lmac_type_id =3D FIELD_GET(RESP_LINKSTAT_LMAC_TYPE,
> lstat);
> > +
> > +	if (linfo->lmac_type_id >=3D LMAC_MODE_MAX) {
> > +		dev_err(&cgx->pdev->dev, "Unknown lmac_type_id %d
> reported by firmware on cgx port%d:%d",
> > +			linfo->lmac_type_id, cgx->cgx_id, lmac_id);
> > +		strncpy(linfo->lmac_type, "Unknown", LMACTYPE_STR_LEN -
> 1);
> > +		return;
> > +	}
> > +
> >  	lmac_string =3D cgx_lmactype_string[linfo->lmac_type_id];
> >  	strncpy(linfo->lmac_type, lmac_string, LMACTYPE_STR_LEN - 1);  }
> > --
> > 2.25.1
> >