Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Binderman <dcb314@hotmail.com>
To:     "Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: linux-6.3-rc6/lib/maple_tree.c: Two style issues
Thread-Topic: linux-6.3-rc6/lib/maple_tree.c: Two style issues
Thread-Index: AQHZa3oGkjmGjA5gLkua9Txw7MMTQQ==
Date:   Mon, 10 Apr 2023 07:05:47 +0000
Message-ID: <DB6P189MB0568CB290411B23A176511239C959@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM>
Accept-Language: en-GB, en-US
Content-Language: en-GB
msip_labels: 
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [1hIiXfPIiFpzb6MaMFHe/ZgpzYQQN00w]
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB6P189MB0568:EE_|AM7P189MB0725:EE_
x-ms-office365-filtering-correlation-id: 869081db-bfce-42b7-1f8e-08db399202b0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: dyZeYUOxdns5YvB8My9QjWPzgHi9jV77fNVlKuF3NyWuPptXKQ/UvponlIdxqFV1+D1daaEzbAGBmLAV6W+qRJCFoS25mxKyjVNV0KA4SEWeuKKze1bD0Cg1RHThqKkKj61uUeKZqzOFCXb6UZ9AMw1C1N3GvZswtqzlGFOgmKd9YHsfb+zktfNTc8Ul36Tu9ItsEn7hS+S+97QkPzKtSVbXXp51AmbBGAtVNWzzA9+kISx6jZ9ObH3PDmp/T2sqE8QMKCloeXpC+S0fs/ZkCz4o0FQS7jkzH6220MTIb+P/oHJUsIQ5toNSV1BJaJb2kBLp4JZWcfDIohAPT1u1F9Ab2KqY/WuY7VKgZ804DGUhKnglKajcsjAfNS83SBIrn3ewew4JBezV8+j0rkYs47+jIbGGUJtO5ccBNhuWbZp7O/+//YPXPM3XgMBeEXq9YCqngqbKbEgXcOIGgZ2YBCP75WeLzyrxv7BCfmYupW5UhMJ+8frssoRbAUqN0jQy300A9RrBsnnzdLWbRbyQNXfPBiCh/W087GRHY/xOU2TTcKblVCmQxc9TEQFxHGpR
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?yapSnAfobcgMiw4L2vzq6jlS+AUfvQzkX2Q9ln4TkYTGlEoOLDI7JYSipM?=
 =?iso-8859-1?Q?1WV1csWgXOI/UzmL0SaTItwLBoyxg9aWCGDOUnPpKIFfT4D0N0+TD+vOaT?=
 =?iso-8859-1?Q?pe6/t2NU5Swf7cjUpnVuJfSZGIKJqcJnkEDRrbDWNdo4Yt2NtJnVtwVizK?=
 =?iso-8859-1?Q?s+H0hrC7oTRGVfCG4rsC5Snc9lI5ZMrIvPxAKUWiZ+BVABYku3whmrdecI?=
 =?iso-8859-1?Q?2UJkB4C5Pi51i9HYXWvrWulTZeVWcfolq9pO3tCZbGvni03+GpfyxFaqL7?=
 =?iso-8859-1?Q?kaFuSYz3gZJBHrXT6YfP+EwGfzDfiDEY0FJXqIJAQeUghYDSfyOxiCqw3k?=
 =?iso-8859-1?Q?qGeVVlF1+m0OHNtEnN3l7rxkvvxVbRnJ47PQb6tqUrwDumdQL+rwZZ07Ai?=
 =?iso-8859-1?Q?LNxkuBn421zhC4WXLpqxsulnKJKMVzjo2C6fUfNlXLk4HXUvW3OOdX+OXB?=
 =?iso-8859-1?Q?uOJMD4KaCbs3yFWKv29afL7g/5AnPaNTGFQNkMEGTU1RuZsziSeVwKOSJu?=
 =?iso-8859-1?Q?ItlTTVzk7O/1Cxg9c9WdvtjND4F5dZeTNQqXa1QeeUDRyt0BSbpKxAdYWS?=
 =?iso-8859-1?Q?dGf/bpG5kVfXc/jl6dVqB7FcfLAj0PkWFzbIfQwLLVZEnODhyGCVnzmeLf?=
 =?iso-8859-1?Q?WojNtwflHiDb3oM8EX2MxFt03hOf0gauc3nLEpc1qL4ATbgM9fvpBwZLG/?=
 =?iso-8859-1?Q?S+HcqBWF7aZikwHK8/mz6buiWOPoYITfWsRDdIlQYS3hqnmxBMAyV6KPq1?=
 =?iso-8859-1?Q?3xzX+wQE7T7ozWj6UsJ7nS6zCtKQueLXlU6py/aNOAc/Aryz5cGAyMy3ed?=
 =?iso-8859-1?Q?vgxxUiVaAVnQtWWLxY7AdNam74QayAcRNBFp5aUWyr6BBmTaP8R2heW+xz?=
 =?iso-8859-1?Q?JuWQ8vRmMEzEzSRiv54Fa9ItkWCKWhbnzc47S/vIoYtiKlAxYo3flBXgxt?=
 =?iso-8859-1?Q?HgUp9CvkRKOpeevXjzwzcHc/Bl6Ei9WxVp3a87fSM7LLRYTWP/NP06sUFw?=
 =?iso-8859-1?Q?cDx5AToOWk+EjqHsl9TX/JiTSKjx8sMgprbsVBe8Dy/iJ+9y3E+bKWOTie?=
 =?iso-8859-1?Q?/E7Y4U+z1o1nDWNNy5yBr13Gbvb2wK1+3WoT8hDUaqUKRQHenXVs4HwP2m?=
 =?iso-8859-1?Q?eUJvVRNuF5sTiC1Qe4iIMze7+Qj4g5+wUgEwzDqIPZRTKUWx0oMLSwRHJR?=
 =?iso-8859-1?Q?DM0qlOvHPD8JcvFbGvgfwN80CyITkmjzgynwEmAYe6nke5jHcMuIvX+G?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-4734-24-msonline-outlook-c54b5.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB6P189MB0568.EURP189.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 869081db-bfce-42b7-1f8e-08db399202b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2023 07:05:47.5995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7P189MB0725
X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello there,=0A=
=0A=
Static analyser cppcheck says:=0A=
=0A=
1.=0A=
=0A=
linux-6.3-rc6/lib/maple_tree.c:1951:21: style: Array index 'split' is used =
before limits check. [arrayIndexThenCheck]=0A=
=0A=
Source code is =0A=
=0A=
=A0 =A0 =A0 =A0 while (((bn->pivot[split] - min) < slot_count - 1) &&=0A=
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(split < slot_count - 1) && (b_end - split >=
 slot_min))=0A=
=0A=
Suggest move limits check to before use.=0A=
=0A=
2.=0A=
=0A=
linux-6.3-rc6/lib/maple_tree.c:3289:11: warning: Size of pointer 'pivs' use=
d instead of size of its data. [pointerSize]=0A=
=0A=
Source code is=0A=
=0A=
=A0 =A0 =A0 =A0 =A0 =A0memset(pivs + tmp, 0,=0A=
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(unsigned long *) * (max_p - t=
mp));=0A=
=0A=
but=0A=
=0A=
=A0 =A0 unsigned long *l_pivs, *pivs, gap;=0A=
=0A=
Pointers and long don't have to be the same size. Suggest code rework.=0A=
=0A=
Regards=0A=
=0A=
David Binderman=0A=
=0A=