Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net PATCH v2 1/7] octeontx2-af: Secure APR table update with the
 lock
Thread-Topic: [net PATCH v2 1/7] octeontx2-af: Secure APR table update with
 the lock
Thread-Index: AQHZa4YA3A/K+/IfKEyu2wpVnbE0nw==
Date:   Mon, 10 Apr 2023 08:25:25 +0000
Message-ID: <BY3PR18MB470732BB43D8D9EF34CF7434A0959@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-2-saikrishnag@marvell.com>
 <ZDF7KFavZuM2SoGO@corigine.com>
In-Reply-To: <ZDF7KFavZuM2SoGO@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4SomzjU7Y0jozWIbXVW0hyO7P/I8j3M7hn1GSMpRzSH+yw2kwt8z0cMd7f6B?=
 =?us-ascii?Q?d7jfBsDq++VWIzjXxxDGl7c/g7YsQ09Qgy5zJ0ZbEY3CgztRPZVa1LluWjTT?=
 =?us-ascii?Q?guPwU30oe5JFLkUwR4RaLMNI+xb6anysxO9UWOyIme7TBWcywVDWiSfw23VR?=
 =?us-ascii?Q?nXPXpRoACjwtDxSMdJwaupfjMrIiwVx8a7Z2HFT4ZO7EFdxs1Ptmqkrb6VcD?=
 =?us-ascii?Q?9Q0QUi762j0+kRGvSNdf2q+FxuWaYpiOUceV0cDjl4HlDVAE7b9kmq9HmLWD?=
 =?us-ascii?Q?Oe5HTI2GuG/fmEd5g2dUTBCK4N93wC5MdnGSH6t5Ss6GYC5sW3/OfV67vF6N?=
 =?us-ascii?Q?vHFiTf9Oc0eH+aX/Nr1jSZXND2P0s2Gc4HssFHFAwB8X0SgVQoiM4elgEW67?=
 =?us-ascii?Q?qLNHFbhKAxGB6TbL6Qvv90uYoA/Fmmjg1K8p/HnuAtIsTLygzKAMityrRwE2?=
 =?us-ascii?Q?89aiRMlwo4MDEEld/XhoiUNjcrjJ+lZ46d1IZ+ckvtRti45s3j+PbCOeP5Lx?=
 =?us-ascii?Q?AydRPA3hVzku4+LIOI32/JoX3qNy+p/WJx3nl6lvY8rWp0gOO8/4MSAs5a8O?=
 =?us-ascii?Q?yIp4SVXTkgWcah1RcnmTJIlzXvD4ftBW+TUMnVbKbNfFNsP2nTe1ZcLoND24?=
 =?us-ascii?Q?wNtnLj9L1GbB7Fhh6PVH4cIPxILKdURK3nYKva3fic3bWhK5Yopstjx4o05C?=
 =?us-ascii?Q?nvk/GNv7W3d3C3rnJUSGk3JXQX6vTd2XDUmH5Y9SM2V63iKynrQHeLaHRxnk?=
 =?us-ascii?Q?SR46BF7BPR1Z1jO4k8fcupZ0L2/MD5TERpzAhhfSQQdVfQxw2Cg0clX4usuu?=
 =?us-ascii?Q?OSBkk4CsTTOheGZAwKA0x8E+Zx5ICe1W2XDzp9MQmW4oMgrbN6ZWx34feZH5?=
 =?us-ascii?Q?EduWV8+fyv1cbf6jzDBWmrmdWwQcoB3Q4LtevwSfjZrMsrM2ESampMJSM6Mn?=
 =?us-ascii?Q?4CQZQIsPw04zlGifn64dhM22xesMgk5r26ub5RTE2dDIfuiJvhPooKjgbwCW?=
 =?us-ascii?Q?FLm4mgvW2TiZ1MPAXXopRknt9D4hL9MURpUT8+RCx8hawKsS71bAe4SWG/nQ?=
 =?us-ascii?Q?eFTUTQrgOsXwgUZOjwak+bHb3KRracolnpSmlVuGosJUs7LRhSYP8cDRdILV?=
 =?us-ascii?Q?scY6SCszG4hUtbgq0+Zsf2b3YJG1OoLv1Ta0ryFllq9MD05Mabfj0F5GNebC?=
 =?us-ascii?Q?9jcCAu/jEUONHN8pr10jqKmJoI+sOR5BnG+GD/0/3TMfhSDhsYLx/mvcn7aQ?=
 =?us-ascii?Q?m5komuwkYCUCRKet9vIZI7jA4Pjk7vy2JVEgFx1MTXeFFshOA88rR5mPACSJ?=
 =?us-ascii?Q?D9/nIo0/WlsetXI+lwu5i9Kkq1hHOPlJ3vP3rqZFBO0D2Nsfr/OdeR0pKneK?=
 =?us-ascii?Q?xewkTfDw11gfUQZLUgcDhKKhGQzup3POY2bfGMATyQfTc7Fsfl7owdL7UF3K?=
 =?us-ascii?Q?b20oKUg8K+j6dScblSA1pNBG1Lzv+f1ybeYcgo1pcQB+Azn0zjU8KPSBhJBH?=
 =?us-ascii?Q?UkBUSlIG7WmoD8u51Kn8CVSvughHtKZn6/RxlkjCPAjJq8I5w0puaIEpD6ZC?=
 =?us-ascii?Q?runoyzyTHd/q6YusDjB0jw06j8NUOv5NNL6ChZtd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07db7b8a-99a3-4d89-c66f-08db399d2299
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2023 08:25:25.5731
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 37VgMIxePVT6GmdqTQzPdmawbtQZoWUxQNkVd9Ku0zlTID9v4XYEldJSZE57M9cjhCmmAPwWXbijXCCkceKr8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3461
X-Proofpoint-ORIG-GUID: 1Db9AvLcE-8Two3thTAwrY5BzK_ubutj
X-Proofpoint-GUID: 1Db9AvLcE-8Two3thTAwrY5BzK_ubutj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-10_05,2023-04-06_03,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline,

> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Saturday, April 8, 2023 8:03 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; richardcochran@gmail.com;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net PATCH v2 1/7] octeontx2-af: Secure APR table update
> with the lock
>=20
> On Fri, Apr 07, 2023 at 05:53:38PM +0530, Sai Krishna wrote:
> > From: Geetha sowjanya <gakula@marvell.com>
> >
> > APR table contains the lmtst base address of PF/VFs.
> > These entries are updated by the PF/VF during the device probe. Due to
> > race condition while updating the entries are getting corrupted. Hence
> > secure the APR table update with the lock.
>=20
> Hi Sai, Geetha,
>=20
> I think it would be useful to describe what races with
> rvu_mbox_handler_lmtst_tbl_setup().

We will rewrite comment message and submit  v3 patch.

Thanks,
Sai
>=20
> ...