Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net PATCH v2 7/7] octeontx2-pf: Disable packet I/O for graceful
 exit
Thread-Topic: [net PATCH v2 7/7] octeontx2-pf: Disable packet I/O for graceful
 exit
Thread-Index: AQHZa4ljQlggiZqUq0KfiwOrdnujBA==
Date:   Mon, 10 Apr 2023 08:49:40 +0000
Message-ID: <BY3PR18MB4707C4CD2D05101BB0AFFE21A0959@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-8-saikrishnag@marvell.com>
 <ZDF6TC+Tm5NvfePi@corigine.com>
In-Reply-To: <ZDF6TC+Tm5NvfePi@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Km9ju3W6WS+qMqDK+xJUwPzmOE32fN/Wu4r2ShZBk5aduiTHmlzdbl/i61ni?=
 =?us-ascii?Q?uTTjghJ+12rlGI6cJ0egX6OTMHVnEn3+va2R6H1mSlpkJdYleOY1ZO7IeqIG?=
 =?us-ascii?Q?0PO+HYQjjdq8i9mnQknHV1Bp5hsOLiptRP//pobimGGp9x/3hsAhFmwxFmr8?=
 =?us-ascii?Q?/H60NhhZaQqnm0U0LaQBoYy36/yesEvGZLr38YBHE/BfiqTkLEQsWnQ8JUrP?=
 =?us-ascii?Q?aqXK2DPe7SmstmSDEGeO9tw62p+30YtGo5z6ggoK8CBjPuGnXGtulkhUmUPv?=
 =?us-ascii?Q?qTelOGGjXegxIneXS9V6ttd6UUKwZO3l5c5sWGapoxIrfQt6xtEv2Ehy/ca6?=
 =?us-ascii?Q?vMSpmhqYEOlamLnVNFjy7kg+inGqgGBYNjPAg91YelDlXvEkGlDFvjiPaC5h?=
 =?us-ascii?Q?mon7yS2ylL+u2lwTB/SLMcWXDtmAVKHuU1WZ0PNgggAmISV3usv7+R/QS5Jb?=
 =?us-ascii?Q?HVDtaOrNgtj3CjQSAkpHTvUzOt4mepfeOmWmchIQWj592xp7YhA2IHS71ZnK?=
 =?us-ascii?Q?oLdt+i/j+AchCtwawJwgrtpGokW4XlKuLNOb2+iRra2NeF/Bys9oPi7+6X3B?=
 =?us-ascii?Q?KW1+9I1U/KOym0XjASqPbEpLIfVDR6GjEoXeGzoOM6ETTCWiRD3lAkAURHzt?=
 =?us-ascii?Q?ITk4tVcvGgYjwnT//gjNCBwKMV8PL1r+NPAYXaEVXFS/y/TZ6P5I5eTv2/rQ?=
 =?us-ascii?Q?qYUnctlINH4BcfivszqJ4QeHHIu+s4PMLQK7PnvohLS16JDrbjQgg9+nkTVl?=
 =?us-ascii?Q?N7dTRGYCj1Jgb+g5/pUUcFSOpdMBeylwvwnyDxd/A1VpLEo2MO2ecePBJScv?=
 =?us-ascii?Q?LBd1Kv/K8u8rovqzDRdLOiu557V16IVvXbotUEdmKXBjtPrHOpUSE172hN3B?=
 =?us-ascii?Q?PdqTWwnM/AibIsEmosoMkij1TMuj4y0tPIpJFdwNz5Sr9Ilb4NkVqgmVezYw?=
 =?us-ascii?Q?f4bGhnF/pXBSL2tTbPDfz2Ykodw/9wiEjYyMUCZ65NG37jfyXkGCGM53vwOD?=
 =?us-ascii?Q?Y9vj64xPPdgcktEODTwBlHhyrww9/yH9I28dh6/swH0Qx49DM3zlh8O7gz7r?=
 =?us-ascii?Q?oJnBseqLLS40pqutuRVPfbCQ7aN2IOTph+XyvVlugfKN2+MVFrvYeww05To4?=
 =?us-ascii?Q?wkGcFa1iw2lMAPOWcOHGDyBjU2F6pGrC5j4M7x7oePRKkvct6nS3QmGnvmza?=
 =?us-ascii?Q?6mFMcqj+axYp6+Gwq1qLXGsoxOLbpJgA0XQVD7rAqmnpVIY0+AMbmK4M7PrK?=
 =?us-ascii?Q?dTMY/9QGBDdKtxjoNQpULUfGiMRCMITAWV3jYWzL54CnOSvposgz7HXkx5qA?=
 =?us-ascii?Q?V6lqwm/LpiP89yAgr7yFuCtrtZOnbqjGwINjEXAcrUJz1CaSGUBnR74tvocx?=
 =?us-ascii?Q?wpmHhilDz5CLOYNR7m0VP15TAU7b5Rq1Ivu/X6RBBskD2nQdJYV/kJ0VQVpN?=
 =?us-ascii?Q?ORXYiXLFFGlwPmupSnpnJLWf4fX9EVqNTHFifqH8j/ivX3uRNdcqXqKSBAc1?=
 =?us-ascii?Q?BevZfZFgAo1q5bGEYH9/sC6JqYP9DF3Js4A35WWhE/Urpeb3Wyb5OReVtb9L?=
 =?us-ascii?Q?2dC22jaeRaTO165Cl1RUfC/dlPfjPM42XgMAk2jz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc943bb-f039-46bc-6559-08db39a08608
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2023 08:49:40.8907
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QKAZHr/hNrGaTXALPcBkCY8xmWTiB/9HZsqpwNarZqHfU5WhmPCiNyDh+LxCvsbsyjgF1MwtlA/Ai7JZ4iJIdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5129
X-Proofpoint-ORIG-GUID: FNH1EBGvMKirr_LZd2Noj4h1md48Mgvb
X-Proofpoint-GUID: FNH1EBGvMKirr_LZd2Noj4h1md48Mgvb
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-10_05,2023-04-06_03,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline,

> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Saturday, April 8, 2023 8:00 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; richardcochran@gmail.com;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net PATCH v2 7/7] octeontx2-pf: Disable packet I/O for
> graceful exit
>=20
> On Fri, Apr 07, 2023 at 05:53:44PM +0530, Sai Krishna wrote:
> > From: Subbaraya Sundeep <sbhatta@marvell.com>
> >
> > At the stage of enabling packet I/O in otx2_open, If mailbox timeout
> > occurs then interface ends up in down state where as hardware packet
> > I/O is enabled. Hence disable packet I/O also before bailing out. This
> > patch also free the LMTST per cpu structure on teardown, if the
> > lmt_info pointer is not NULL.
> >
> > Fixes: 1ea0166da050 ("octeontx2-pf: Fix the device state on error")
> > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
>=20
> ...
>=20
> > @@ -709,7 +709,8 @@ static int otx2vf_probe(struct pci_dev *pdev,
> > const struct pci_device_id *id)
> >  err_ptp_destroy:
> >  	otx2_ptp_destroy(vf);
> >  err_detach_rsrc:
> > -	free_percpu(vf->hw.lmt_info);
> > +	if (vf->hw.lmt_info)
> > +		free_percpu(vf->hw.lmt_info);
>=20
> free_percpu does nothing if it's argument is NULL.
> So there is no need for the if clause added here.

We will submit v3 patch as per review comments.

>=20
> >  	if (test_bit(CN10K_LMTST, &vf->hw.cap_flag))
> >  		qmem_free(vf->dev, vf->dync_lmt);
> >  	otx2_detach_resources(&vf->mbox);
> > @@ -763,7 +764,8 @@ static void otx2vf_remove(struct pci_dev *pdev)
> >  	otx2_shutdown_tc(vf);
> >  	otx2vf_disable_mbox_intr(vf);
> >  	otx2_detach_resources(&vf->mbox);
> > -	free_percpu(vf->hw.lmt_info);
> > +	if (vf->hw.lmt_info)
> > +		free_percpu(vf->hw.lmt_info);
>=20
> Ditto.

We will submit v3 patch as per review comments.

Thanks,
Sai
>=20
> >  	if (test_bit(CN10K_LMTST, &vf->hw.cap_flag))
> >  		qmem_free(vf->dev, vf->dync_lmt);
> >  	otx2vf_vfaf_mbox_destroy(vf);
> > --
> > 2.25.1
> >