Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field hash
 extract
Thread-Topic: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field hash
 extract
Thread-Index: AQHZa4iTzNWI70/imEGdQTM0k6wZwQ==
Date:   Mon, 10 Apr 2023 08:43:51 +0000
Message-ID: <BY3PR18MB470718017D6B5513C87883E3A0959@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-6-saikrishnag@marvell.com>
 <ZDGGbyXDjrnoJRcd@corigine.com>
In-Reply-To: <ZDGGbyXDjrnoJRcd@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VWgLii2G9tdmwCdMWJtJcODL4LumiBUvXugHoPHbRyfM57geeDaGlgXqOvL6?=
 =?us-ascii?Q?VYbmxKFyeHfh6WVXF8LMhBMG3XhXxELQ9XcLtb+Z2ezONcWkNG0YqhGe33yU?=
 =?us-ascii?Q?/H8JLvLn2fFqndgTM4LZxkedscvu4Je74pLSy4P+6jP0EITgIdahcc58RZ0l?=
 =?us-ascii?Q?KCIUDs7W4LqGPqg8Bi3HyuuFC3m4GAd6gUQZMyGxBcg6vRET54qdsh3ttEXu?=
 =?us-ascii?Q?p2j7BH34cdBoknIsPNvoTqibRPlFrtC+czMQXc42dS0LoQPEb3+VuB6ygy5J?=
 =?us-ascii?Q?XZVjH3RJkXBAD+OeeUaM72uz5IR41BdX1eLAsf3PS79pXpPaK6Yh4sLjoPzU?=
 =?us-ascii?Q?REAt5RCXSk1N5ke1zahk/pMjgV261sYeegaaO/pu6Gj+/9iKfjkfLySNMZUk?=
 =?us-ascii?Q?Dxb3q9ctuG1XO5CQBrQlheHFMtwXmeRoSGoXHTvyRys5MYA/RGvjQ5lbnwKi?=
 =?us-ascii?Q?va5cNRmlt/CXZHqx2QqgmShqYtlFp2l/SHbmDxobli649XCUheu/tcZhRumq?=
 =?us-ascii?Q?1iM/Lnxr2ieS7lBQSgFyqHxuH5zArVMXNIFFiVL4VgMQ1A14UMpMGYkoBxZS?=
 =?us-ascii?Q?dAwGL22f/oY1gcHx+ZYPd+5uHqKWHFi563NbBYCov+v9Ir2TgTQD+n6956S4?=
 =?us-ascii?Q?ozyhTgzpAdpf11hE6nQGxEJuMofrJTBcdq8Abzo0Q2PwGmeYnIMLZbW/wkKO?=
 =?us-ascii?Q?QhwwmabnQM1xx40+nXE5apzqSO8KwWXMurmknRH/UaV/DneSRal5ySNEdLmN?=
 =?us-ascii?Q?7V5kRvQ9mmuoRkW+yAjvcsd0p7acDZLu21sOCBIFWhvWgt7AX+8DQGwH1Tje?=
 =?us-ascii?Q?KwiSSCb+GxwTUTVFJyLgFgb6UMMMx87VQ592pUGnEG29yIqF26KqIAWCXWRZ?=
 =?us-ascii?Q?xPIy/oU3eZrfuic7Z7hiKhSxMT7tqJM3QCuCqBU+ikVRSJP5h1MdrKwRzYFW?=
 =?us-ascii?Q?axjO3ouWv5g/cVAYShTqNTNMqnCNmPKDOtTSy7xkGgtrV4fEyu5fmR8hbv4K?=
 =?us-ascii?Q?qCQ6kcM96pacY7jYknkABpPtqzrkFOESAiuQaG4+36EclJnMlLDzpGVNNwvl?=
 =?us-ascii?Q?4ycTP2TdluH73rd0kZ2NmAmzRgMW3AaT1Wzm0CUjC3gyAHWphPAbrBdRUKsL?=
 =?us-ascii?Q?VRKgRY0GiWqTU/1q3bKYU/TKV2u+cO26UAsQuBMvDKMPTDsvJj/gVKtWeZ/U?=
 =?us-ascii?Q?mJ23cyHbm84MvTEL6KPhciXDejnHvnzhjj1n7AfMUYfGTSOfu3djsAyJloaz?=
 =?us-ascii?Q?soBS894FUDJutEXedJ54Y/hwX8rMwqMnMe0YaggNkmum0k+qC1aHiVyUcPXa?=
 =?us-ascii?Q?AWjOVO9DTOkL+OtQD28v+/R266Jo1c/gneOlalp4jasvskdZLiSYCfUrZ77a?=
 =?us-ascii?Q?zsDkBvMduPYp+/9mGpN8KYbrWNIY0CTHphsomW0oEfytEMGqJvRDfWAlPYcn?=
 =?us-ascii?Q?7+bBMQUPWaNCrCg05xadP22cmqMpUdKKXvrSmrBXRTWOWgkhjY6g3FRA9E1K?=
 =?us-ascii?Q?XcYgoje8C++CwM5y6BB3++Ga5Cokk7YbINIOjx3dhaYNPAexX/SGYV2owRv+?=
 =?us-ascii?Q?fwREDiWBp3O2TDcaWmHDJotGgMapG9wBC02wX5kO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9959f866-1ca6-40a2-4463-08db399fb5ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2023 08:43:51.5310
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: npI/oo1rWxHtgPn4Ly0seyLAhdTHUrkTijQNHQWyTyvAK7OHbE+3hLHM29STWwK5OA0NtP1QZU41R79uefR9lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5129
X-Proofpoint-ORIG-GUID: s-9AOf9yr7l0pJgcY-ypokCoW83hNunz
X-Proofpoint-GUID: s-9AOf9yr7l0pJgcY-ypokCoW83hNunz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-10_05,2023-04-06_03,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline,

> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: Saturday, April 8, 2023 8:51 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Geethasowjanya Akula <gakula@marvell.com>; richardcochran@gmail.com;
> Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Ratheesh Kannoth
> <rkannoth@marvell.com>
> Subject: Re: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field
> hash extract
>=20
> On Fri, Apr 07, 2023 at 05:53:42PM +0530, Sai Krishna wrote:
> > From: Ratheesh Kannoth <rkannoth@marvell.com>
> >
> > 1. As per previous implementation, mask and control parameter to
> > generate the field hash value was not passed to the caller program.
> > Updated the secret key mbox to share that information as well, as a
> > part of the fix.
> > 2. Earlier implementation did not consider hash reduction of both
> > source and destination IPv6 addresses. Only source IPv6 address was
> > considered. This fix solves that and provides option to hash reduce
> > both source and destination IPv6 addresses.
> > 3. Fix endianness issue during hash reduction while storing the IPv6
> > source/destination address as hash keys.
> > 4. Configure hardware parser based on hash extract feature enable flag
> >        for IPv6.
>=20
> Hi Sai and Ratheesh,
>=20
> there is a lot going on here.
> Could you consider breaking this up into more than one patch?

We will break this patch into multiple patches and submit v3.

Thanks,
Sai