Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 17:22:40 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Andi Shyti <andi.shyti@kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-usb@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <srinivas.pandruvada@intel.com>,
        <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v6 5/6] i2c: Add support for Intel LJCA USB I2C driver
Message-ID: <ZDPVYEHSI3ud27rN@ye-NUC7i7DNHE>
References: <20230323172113.1231050-1-xiang.ye@intel.com>
 <20230323172113.1231050-6-xiang.ye@intel.com>
 <20230326153846.zo77mbgti2injnxl@intel.intel>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230326153846.zo77mbgti2injnxl@intel.intel>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F0VJLG1G3595V0EskCzH/UCajt3cSR/M6Gc3axV/ScdnJDJijt+Sfg7OBKX6?=
 =?us-ascii?Q?yvcW1DMxNPJEVSX7M97auvH8xZ60qFub+DiSU39FAEjts7lh/VHgme8WzT9s?=
 =?us-ascii?Q?5pOMctyTEAWNfGIqSvAq9F7iHeXteoeo+uDKEhB25lQK5tXdFuj+yLeBUcIW?=
 =?us-ascii?Q?NwHj67Yi8OPEkrQ99ls5RbHQoRpLkGbtcVYdKh5o1hSvBnyUfxq5bbvV3bcl?=
 =?us-ascii?Q?zwj10elW+pQVCJ6JqqtaKjOsiiVHQYHTfC8TsZJFiDd5A2gIRJnBe1yf/Y7e?=
 =?us-ascii?Q?Vp2JhzZ96rQjEH1+cVFVKPm9m111F/tkfCV2uOWoGaUSXhFn/rSrcvczh/Dv?=
 =?us-ascii?Q?359yYeecWilwx9IhiLzULUGxdkU3lu+HQV9jE1Y8q7T1XUNg4DX9vXrDE1eN?=
 =?us-ascii?Q?LWqz7f/eWC1LrnIo+ASdhbw8e4KJkgRVjLJjUZ2+2Ma/RKulD89eY0FJRX5R?=
 =?us-ascii?Q?YLVajyaizTUB6MtMZUx3Wh5kaOgw8xFOypWy6Kri5mIRtPt/fH5gM3jjFjq8?=
 =?us-ascii?Q?8HdZ++K2pRfezGcg5uQi3kChFArIRz7fIKdJhN++WwvVSrxhzgIDYvBXwL7R?=
 =?us-ascii?Q?4Oz/xEi8iZM/Yya16z2wvQ3pH2yS2qrnU8F5aYyS5gkibRUvnaIiaT+60Vp8?=
 =?us-ascii?Q?Qx1VYHeVFfM23HZDsuk0VEq3+JRQdP1FBBRpEBJDC2SI2QvOMPjOga8oOSVB?=
 =?us-ascii?Q?NERaRKZSr9XhGcLVWlu1Kdz+cmxcC9w6ptkNVdUecW9omZOYOO+0WSj4+S7j?=
 =?us-ascii?Q?EHUYX3uNlp3F3YbzzFH5g7YTuhJeOlrZ+BO4aHiIqxYSk9cBN+Cl4UVndiCc?=
 =?us-ascii?Q?JcZ7GtsOYiK633a6Gvfsg3B3Y9zZCsWMADKsGYaLHm0l9UDydRvg0waitQKX?=
 =?us-ascii?Q?gzZIQqBXb6dH2antarNbyEe0l6jDxopAUo+fx2Q+l+W9fuYaHcbC8X4l3XNE?=
 =?us-ascii?Q?H08S9689PRVyJkmNulsqwnkKLwYictfPPtybg0Np34gl5wWqoS2/enKUYBo8?=
 =?us-ascii?Q?i5NLvdBOHE8au9Qap0eXeHZRFuMoBlqYnaR3La8+T7oydNV5YxLQz2aFelJP?=
 =?us-ascii?Q?ygz9ZRaMGYae8lga5cHASC/oJbCyNuJAdJd9lHQvsVJT/hsuFQjP+Q+kVRfh?=
 =?us-ascii?Q?ymi1zGeiw+XB/DkZE1IqXIpe+1hjJQSLh9Qec+Pn7vm5VlWiyc/Ce1qKgzfy?=
 =?us-ascii?Q?Th0nH5fR7zV4JwzlwLYxHHMhqfe9JtgrBANy1QMNloAh84d85S2jg5yEMiam?=
 =?us-ascii?Q?7hH78U+pyzivUi24IzQbkX3nwLsXAx9wbvPNc4+V+aHroFx8+orwCgyNh7pS?=
 =?us-ascii?Q?bW6nMRcbVJl8qZUQe28F1RFBB8k1ecxahRMADuRBhEeuPP9Jla7T0xR9xCcb?=
 =?us-ascii?Q?MzzG6M1gi0WlV4tHx6Q02KOUzpgIVGpjx1x+LDNqDZWY8+ANib1IWYeqtQSq?=
 =?us-ascii?Q?IaO9+VrpFQJMsWUXqoN5Tl47iOc3lDb2Y0mLLutwWK/+0a6l8f707YesAfCq?=
 =?us-ascii?Q?b1xYMvwDgcOk+lpCAEDJdDrFU6fxt2HLZvODQ4NuNvy+POCujsj7IF7w+c85?=
 =?us-ascii?Q?wjgkQ6ZdmKMMcBBdb9n0cWfUrT5K3VVjSy0vxrNj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec62e962-233f-4501-b2ac-08db39a52144
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 09:22:40.1659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G7PFw4erLojNh1VX17aAk7qinjgOtuf4bN8KsL5Yi/qJiJzX3FgEadh4UkYAwqhmzz8ioZtmia2ZLIGRYUpLJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5008
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andi,

Thanks for the review.
On Sun, Mar 26, 2023 at 05:38:46PM +0200, Andi Shyti wrote:
> Hi Ye,
> 
> looks good, just a few questions:
> 
> On Fri, Mar 24, 2023 at 01:21:12AM +0800, Ye Xiang wrote:
> > This patch implements the I2C function of Intel USB-I2C/GPIO/SPI adapter
> 
> also here, please keep using the imperative form.
Got it.
> 
> > device named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA
> > I2c module with specific protocol through interfaces exported by LJCA USB
> > driver.
...
> > +static u8 ljca_i2c_format_slave_addr(u8 slave_addr, u8 type)
> > +{
> > +	return (slave_addr << 1) | (type == LJCA_I2C_READ_XFER_TYPE) ?
> > +		       LJCA_I2C_SLAVE_TRANSFER_READ :
> > +		       LJCA_I2C_SLAVE_TRANSFER_WRITE;
> > +}
> 
> How about:
> 
> 	return (slave_addr << 1) | !!type;
> 
> BTW, am I reading correctly that the address here is composed as:
> 
>    7     6     5     5     3     2     1    0
>  ADDR7 ADDR6 ADDR5 ADDR4 ADDR3 ADDR2 ADDR1 R/W
> 
> [...]
>
You are correct. Will adopt this solution on next version. 
> > +static u32 ljca_i2c_func(struct i2c_adapter *adap)
> > +{
> > +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> 
> how is the smbus supported here?
The i2c-sub module of LJCA device is SMBUS compatible.
It's supported by LJCA device hardware itself.

Thanks
Ye Xiang