Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 18:44:34 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Oliver Neukum <oneukum@suse.com>
CC:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "Matthias Kaehlcke" <mka@chromium.org>, Lee Jones <lee@kernel.org>,
        Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>, <linux-usb@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <srinivas.pandruvada@intel.com>, <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v7 3/6] Documentation: Add ABI doc for attributes of LJCA
 device
Message-ID: <ZDPoku+k+S65cmeQ@ye-NUC7i7DNHE>
References: <20230325154711.2419569-1-xiang.ye@intel.com>
 <20230325154711.2419569-4-xiang.ye@intel.com>
 <b1eb8356-4519-4c95-b3ee-afc142b8d17f@suse.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b1eb8356-4519-4c95-b3ee-afc142b8d17f@suse.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4XvPAuYxtzv5N1aaLen6s8snriIC5L/I2PAi+zVpv3p+7E7fUq1I7soUr028?=
 =?us-ascii?Q?yUFcu42Byb6ZUM8qY8moI+NxsyMzrKIRjpPbPFuazUZWPYDpYbrdxJbXYS8p?=
 =?us-ascii?Q?KoRDhTKvoai8+9H9VptVq2iTh4oJxVgp4xRcaX8gGLR6cduDsz7DMxHGDL2c?=
 =?us-ascii?Q?tVBn/+Wfbr/O6q2SIYZgIpAiWNdyf4+G26UGTaknV0+QGv1avxymEZLvlyQh?=
 =?us-ascii?Q?20G8rg7UPE2EMmVyN6viSj5Qwe3DBwDlukOTdlryczysseThLST3KXvccb8x?=
 =?us-ascii?Q?5vpyLpUCBzUHQI0Q4HI65F1PiDPHFfOd3TRZuON4RsDInFvNBpcO2IzIrj6P?=
 =?us-ascii?Q?7r4p9VIvVm6nH1EkQKOS33DYQyACvSqP4WjH6u0JyKis29axM1W7PtSBhsH8?=
 =?us-ascii?Q?cwnofWp+7UaqsqedsRTGIXkOj62abUagG5r+pkxWHLSvm8kYg+ye/Mg7OB9Y?=
 =?us-ascii?Q?y+4/poLHFpV032oOUsEHCNse9GGfZrFgBqaqJyLoO/2RHx5HS8Wnv2X5SJ6s?=
 =?us-ascii?Q?jnbMQ5MfhX9iROA5G8TwfFWTAn6sA2caS7gDTFr9y7UBIq/nVMI75qHdvIdR?=
 =?us-ascii?Q?lJ1eV7ZjXnZ9B4x8GSGlQm9j1RlS46QEXcqgujmJNncDDpHAED43uI5sMAU4?=
 =?us-ascii?Q?led77/jle6oJwf3hyut8RyxNdr8BUmKcxbIsNmuqHO6rjhdgLETcbmXUvyWE?=
 =?us-ascii?Q?04bQtf6xBaiSd9B17AaZH3228t5pv0vI8WjdsYGviFU/EKVa9eapJE454lHY?=
 =?us-ascii?Q?ZsFVoMWcJCjC+5vgDfVIJqczpvTu3Nr8HQq0PIdZ9zh3j1J5B0wT+tvlwflp?=
 =?us-ascii?Q?zoDVCLev3tqlH43N2daXNm8g3/MnhvSCOaZ1113Vex3kHvcHGtGDEA7LWf/b?=
 =?us-ascii?Q?trWLL3XGPPPOaSJNBoPYpkcKrF2wSx/dj5RKZd+NuWgCBFVup8+RNTi/Cajm?=
 =?us-ascii?Q?fJU8HPVlRtxGcoYEKajVIVwPIVwH18KkmUsLU+vsSxYx+875EBbLGhJP+GQP?=
 =?us-ascii?Q?v+mgFCBZYHxalZ1MKUXe4Dm0gELxR5xz/ll3rhRMPWGCqJPtNClNCHmq9MaV?=
 =?us-ascii?Q?TYd/9CE7BrWIfKMNyOTKJb1LegwJXRVbCZPw2HRZkp11bK37Riw6ZDiR43Cf?=
 =?us-ascii?Q?Hre+XtOiY2gCUrwHjjcbET6CZjN/7zfiXH17ntNgKVlo1YQZm9asoZO4j/jr?=
 =?us-ascii?Q?T967dU8rRqHjEQkQXUpzgOOyJHiEh1hMDDNmTPN8Rp2u43v58BmHAdJHOGFU?=
 =?us-ascii?Q?BRsZe/HIwL3tCYkhhWz0odBIPnRgmjP7pczpLc20H1cpFtBIeOztCSix8jsg?=
 =?us-ascii?Q?0vlAXvRivV8GTjeJzCyVIXj0+8labtNxKw0UQfPxTayYimEwLoslvaMqscOD?=
 =?us-ascii?Q?3pDKcxXXzdalDb1IJUS6cbKpJ3XLj8YJ+c8ijZMS3vTQEunIQfSWT+3f1Lpt?=
 =?us-ascii?Q?LeeV7zlHbTkTHx1LvOXEQQCT20ewQDr/FQNtB0kST6Qjz9YGb9XB4m3dVdQ0?=
 =?us-ascii?Q?lYw1tcH67+adcCxoUgyL6+xrQJgUIgXRaoxSGHaqFmVEuOvocxNKoK1mOcg8?=
 =?us-ascii?Q?r+YLCUN6oV1VXk/86fyrzDp8fLa00DdfJ8HIPBuy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ef2d7bd-d9e6-4eec-88aa-08db39b09283
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 10:44:34.0889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RdENQCrHpkAtK8etC5dC8hmuj3sBrDC1dUYefx6BPTCmKxxYCpBkuE74TJjwj8n+NMbLCwCkfasE/E7YyPSZVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5505
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Oliver

Thanks for the review.
On Tue, Apr 04, 2023 at 10:53:48AM +0200, Oliver Neukum wrote:
> 
> 
> On 25.03.23 16:47, Ye Xiang wrote:
> > Add sysfs attributes Documentation entries for LJCA device
> 
> Hi,
> 
> do we really want each driver to have its own attribute for that?
> It seems to me that that should be unified.
Three ABI entries are added in this patch: ljca_version, ljca_trace_level,
and ljca_enable_dfu. The first two items are specified for LJCA device and
I think they can be kept in sysfs-bus-usb-devices-ljca.

But for ljca_enable_dfu, I didn't see a unified DFU entry in sys-bus-usb.
I am not sure whether other USB devices have similar DFU mode or not.

Any suggestions?

Thanks
Ye Xiang
> 
> > +
> > +What:		/sys/bus/usb/.../ljca_enable_dfu
> > +Date:		July 2023
> > +KernelVersion:	6.4
> > +Contact:	Ye Xiang<xiang.ye@intel.com>
> > +Description:
> > +		Writing 1 to this file to force the LJCA device into DFU
> > +		mode so the firmware can be updated. After firmware
> > +		updating has been done, the device will back to normal
> > +		working mode.