Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp3995900rwl; Mon, 10 Apr 2023 04:44:08 -0700 (PDT) X-Google-Smtp-Source: AKy350Zeg0JDEFLgN7hAPlUP6mlyrI/PIC5erRl5wEwOZJATddPRu10rpukYYz1mXjj4eKWt4LSg X-Received: by 2002:a05:6a20:5481:b0:bf:58d1:cea0 with SMTP id i1-20020a056a20548100b000bf58d1cea0mr12722921pzk.31.1681127047898; Mon, 10 Apr 2023 04:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681127047; cv=none; d=google.com; s=arc-20160816; b=syfsyCkezGGUJhYIGTJITrb2+vqHAKUZNiymmWeuZUcn+fFocSaPmX9E/jguDG/Pkb cfWX5550CoBJ4Qgh5N7nKG5/ibMZ2uWit1SBkW2j5wir1h86H0oKESKMT/EPgfcLK8yI hy/pQ65PoBY7RbulSN/X3p2A5zGKkgOR3EVMUFNfzSAqdfFz/uMcg45Nitiylin4A5Gb jrDFIpR2Pf+e1kPXSdhd8epC/nUkNDQN2v/ZY5HWBHE7JaCvaVvE5UNRSxuyJ4Gp8n4U sMarRiwUf+zAuQ9buuclUtj7q5TSRUCIh61vWt14VlmSe/ZE+L3ubjm2RFPtRkA9N0iv ze3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=JiF9TzwY2uuvpMs57Kp8Y5Ov+6bfFQ7oVM9R2z2oxW8=; b=lFkif1SScXECnk5vxjL8IMniTNf+BF+VJ6asp8D/uC5dgmIdHu8l+WJSX+mRMnVoNR /mLQGA+TpQHCHXVhyagvNunTKGHnIfKyvfsQKpNx5aXFsC+EDNt6u/t2O1zjPnjGdAaO N8QEmzD9/7L3jbG2A1EkVC8O7fYB3PzsHHXjsUR49Cc54pngjs5cw5FnSkZeH5631EWc ynEgcANJsUvthRSod6ZiveLdql/lffd/RUHzBjcRjB3WSJRAjzjRrfdpSSyg3588qtwh yhFT2AAIMvdTftvFMpVw8bFqzvTUU2jHO6uSFjbRen7HF43og1+1ip3T8qXOgkfkPPeA Mr0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a6550cb000000b00513218b46b1si10471194pgp.385.2023.04.10.04.43.56; Mon, 10 Apr 2023 04:44:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbjDJLhH (ORCPT + 99 others); Mon, 10 Apr 2023 07:37:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjDJLg7 (ORCPT ); Mon, 10 Apr 2023 07:36:59 -0400 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E74A549ED; Mon, 10 Apr 2023 04:36:57 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4Pw6Px0NL9z4f3qsl; Mon, 10 Apr 2023 19:36:53 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgAHvbDT9DNk0tNvHA--.50875S7; Mon, 10 Apr 2023 19:36:54 +0800 (CST) From: Yu Kuai To: logang@deltatee.com, song@kernel.org Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next v5 3/6] dm-raid: remove useless checking in raid_message() Date: Mon, 10 Apr 2023 19:35:56 +0800 Message-Id: <20230410113559.1610455-4-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230410113559.1610455-1-yukuai1@huaweicloud.com> References: <20230410113559.1610455-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgAHvbDT9DNk0tNvHA--.50875S7 X-Coremail-Antispam: 1UD129KBjvdXoWrZrW7trWxXry3Gr1kGF4rXwb_yoWfuFcEgF s5Xr9rXr17u34fA3W2vw40vr90ywn5ur1kWF1rtFyayF18KryrXryru3s8CwsrZFW7CryU CrWUKr1fCrn5CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb-kFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY02 0Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM2 8EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AI xVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s 026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_ JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14 v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xva j40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JV W8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbJ73DUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu Kuai md_wakeup_thread() handle the case that pass in md_thread is NULL, there is no need to check this. Prepare to protect md_thread with rcu. Signed-off-by: Yu Kuai --- drivers/md/dm-raid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 2dfd51509647..9db45f3508e3 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3750,11 +3750,11 @@ static int raid_message(struct dm_target *ti, unsigned int argc, char **argv, * canceling read-auto mode */ mddev->ro = 0; - if (!mddev->suspended && mddev->sync_thread) + if (!mddev->suspended) md_wakeup_thread(mddev->sync_thread); } set_bit(MD_RECOVERY_NEEDED, &mddev->recovery); - if (!mddev->suspended && mddev->thread) + if (!mddev->suspended) md_wakeup_thread(mddev->thread); return 0; -- 2.39.2