Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 08:41:44 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH 1/2] maple_tree: Add a test case to check maple_alloc
Message-ID: <20230410124144.ouhhnmfoipkqtveu@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230407040718.99064-1-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407040718.99064-1-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8/Iluy1Sy19+tz21grBuBH9NIcgVV1wo0KKbviZ+zZA3hwlG8JyqQbWR3wRh?=
 =?us-ascii?Q?l5J644jg+9BbD9GsLbl400w9uVHU3B9kPbO0g7Ow4Z4phYzITuQi9ZXQ/tkS?=
 =?us-ascii?Q?QFNot/G+/Wfvaq+4aqEJOQfFedYa3rE3dfYr4AyYQXZf/XOFGX+i69kLS0EP?=
 =?us-ascii?Q?0HOREFyuaT4pApy0IovU+JGUaWRO2ctcOA9fb+7SCbJpHuRjaHGKY+dLP1Ov?=
 =?us-ascii?Q?0/aC/lUiQ9MZExowaqQypxPMfd0NyvefTQp9Zk/hIBUYYJipuFwGctVBbwtY?=
 =?us-ascii?Q?LALJbgI0VpwfxttXixvs59BgQ6w/kNil7Bru5EmW/zdNeGkWBo1abDittt5a?=
 =?us-ascii?Q?iEwsbEgvfzKMxBwh3l5XqNM8LL074Kijdlcg672UdmowV9G9PPMb32Fc07Yn?=
 =?us-ascii?Q?gjDQZHJS1QPxqeGTgUfZGpb0nE4Z3h1TUEo2hYuhs65nezdWithjunbBU+c4?=
 =?us-ascii?Q?8CxNGtVgMbKH5NlzeV6KEgLW+yGpeIhCFCXC2Q3HVhsRjuvD8+dKRDJRLtIe?=
 =?us-ascii?Q?mX6SQMrwTIEo88sQNbN6z4qvhlBLZ/G89KfilzfcCBf/9fVFQ0u2yR3ALGyf?=
 =?us-ascii?Q?RWvlSoF3JGeUZ7lpCGYCxgoao82Gjm2UfvSuBY/mrGu/Xp1nwWwAFNbg83Yb?=
 =?us-ascii?Q?jUhZJ1X/vRyHTuF0emEfftx8udnCwGK4Xvm7Zxp2jBeemEaS/aCMmTcGhKKL?=
 =?us-ascii?Q?GpJDjvhrMZy5m3ZQk9SJl2jnyy2vKqayhr1s68x6WBWIK1QEvuplvV65FKMA?=
 =?us-ascii?Q?9F7A8xAw200HKjXLWXcRVR7JlaBnMQmUI6qg8Npvm1E8fF+k+UJcR0h8x4Jc?=
 =?us-ascii?Q?IFHEM2r312BubNrrK/Ns8zjnejoUKRs3FuR0YZfFXAqbjzCvdAP+SnWw6a4v?=
 =?us-ascii?Q?tpyPcesLmr4JHKq0CY2QVHP5JS3TRPk8UubGWUTXL3G5mRLfd2XTXhKWqk0w?=
 =?us-ascii?Q?AdmYzril/UtJVPVhappug8YtI0bwTakKMES93J8egb1iX+sQ1qT+00jKVi+x?=
 =?us-ascii?Q?4epbQhlBFl6FmpPFQfGbusxMY+v4j6ZCXYOteJViCWpSYZ8S4G/EZh5PKCKN?=
 =?us-ascii?Q?jmde8AzLMak0Efu3z8wjxcPXoMB7m4VLWbD85ip5D1uUlJ2EJE8AJj+V+Lld?=
 =?us-ascii?Q?umBdWJMVPwYQnxOayTgheiFnTSVKWDMXgswB8MX9UciQuQRj4Vt2AKfnWQ0q?=
 =?us-ascii?Q?+L/LtGioxRzObYuqyWo83KU19JyP+vjds0Kg62+jmI/u3NgIetQ5mizUGFc3?=
 =?us-ascii?Q?2qPVQclbwJA5P7LVoG+pdFYavslP98ktJ/Q07rC8EHqza+fnk0UlYnMVXYNw?=
 =?us-ascii?Q?BMm2OEubLS4V7Aj2MMgmjaEr9LDAPaD1DvmIq3h8KbALDUdWkcIShZ719qSQ?=
 =?us-ascii?Q?RHkXznFK50QG11ND3g0nLp69P/NqDzpAhOcTn4muDxqKLkQB/A1EAA8LIUko?=
 =?us-ascii?Q?zbgBeo5bG40aSRHUdRPOJ5R5x3jol3VoIyva9E9dRGDBA1dXFfuErQcShUwf?=
 =?us-ascii?Q?M3VytiiQZwqOoQPqVC3+mSkncLGaulZqQNZunZKBwq9eiMFxfxh0+7w/7uIw?=
 =?us-ascii?Q?F8GEcAYm/CYgDq6xR6nN1qpuPD2f1vysj2SGI1p9YBSwsLko2kf10+c+cXNo?=
 =?us-ascii?Q?yQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?VLu/vy5NEnA2OVM1Xp+VKYphVKzW2BXLZ1CiUbgO5FBch1xVhwM+p3MBpTug?=
 =?us-ascii?Q?5AxMX6xfhij2PDyyJ6Gbb0jCVnXf1Yd8jhj6wXQMWEHavVXjvWAy2vAR+KJj?=
 =?us-ascii?Q?kvSAB5CaNq35YiYrHRfPX7tPO6IjgMZglbixOXUekufAbbLdzRcmPyohH42e?=
 =?us-ascii?Q?FwxskUiKOZJTskWQYkqSLFHWN98HutdiKw7CnRjeTEFGU/YBxsxq8m0QqTPe?=
 =?us-ascii?Q?PTeP7zSFMQdLpOew1whvn0IQK1DeHdvDIwr/XYTdCrGnlxatGoMlzumR7XEq?=
 =?us-ascii?Q?DEBFezKJPMGkl9GekstzZwBD1OYOSkCQbJn5opS5EVtIxDEOxNPAmGsiAEpF?=
 =?us-ascii?Q?16oxscIFZ1Gh/NFoFiTArQGlnx4WepwK7+gXXaMtVKT3OThH0nqyt9KV7wn4?=
 =?us-ascii?Q?GRO300IMhMhQ8CO4uMnMFerKkorehcaA/rPsEJ4AJtDuxnOYqL36CDYO6aaH?=
 =?us-ascii?Q?LBJ5re6/YkYTz8MWhdt7Ti5rA89l2BfD57Asp6mqcn/18mA5CsaTMEdeJ3D+?=
 =?us-ascii?Q?tXAfngwNmEDDwam6MiIyPHlODRIXGXEbHrA69nA5qeOvC0c9KmDRWDCRizAT?=
 =?us-ascii?Q?aO7alLM8tZa/DYzpKQ7KUQDfgFw12utiRk2MuOSPJrKnaXov/mTO/mV9GvSU?=
 =?us-ascii?Q?ZcucYY+ILcHIY1zSFwcdHPWIlXV1BcSDxQowyLpOlqwGGCjqA7eyAdScGWi5?=
 =?us-ascii?Q?kHebt5wt/MxmmWh9eHJ9QX45t4NsgJCN7975NDAlLsQ9wyEWImUXbc5WjEae?=
 =?us-ascii?Q?RIy34Ysv50jWlgQAKcFhnpW3elEziLZzB0Nsp1jvRgpw8fA6RnyXuBoiKlks?=
 =?us-ascii?Q?WJeWGJ5Uepmh+S4iWGlk5dZxHVDA3LEqCJT2zj7oS2HEub+7q4z9qtcGx7Zr?=
 =?us-ascii?Q?MKPZgSSIhplD3s21V0kzLdVCkReI6TVilwpzoXYEuJpn/ZuUtCz2V2XTi8hv?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e611a81-ba47-4371-c7d6-08db39c0f2cc
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 12:41:47.4901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AC8lO+0OZQUMeBN2+uOxH0DCzDzbbbIip0LHATtG4wVhGdI7Z6+thBBytvM9UDENAPju2La++1+IyKjHuNccyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7454
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-10_08,2023-04-06_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=853 mlxscore=0
 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304100106
X-Proofpoint-GUID: R-xK04NnQGRExH-stAKxvXo35LxAM32s
X-Proofpoint-ORIG-GUID: R-xK04NnQGRExH-stAKxvXo35LxAM32s
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230407 00:09]:
> Add a test case to check whether the number of maple_alloc structures is
> actually equal to mas->alloc->total.

Thanks for the test case.  Can you please send the code to fix the issue
first in the future?  This way the verification code can be used to
bisect any issues.

> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> index 958ee9bdb316..26389e0dcfff 100644
> --- a/tools/testing/radix-tree/maple.c
> +++ b/tools/testing/radix-tree/maple.c
> @@ -55,6 +55,28 @@ struct rcu_reader_struct {
>  	struct rcu_test_struct2 *test;
>  };
>  
> +static int get_alloc_node_count(struct ma_state *mas)
> +{
> +	int count = 1;
> +	struct maple_alloc *node = mas->alloc;
> +
> +	if (!node || ((unsigned long)node & 0x1))
> +		return 0;
> +	while (node->node_count) {
> +		count += node->node_count;
> +		node = node->slot[0];
> +	}
> +	return count;
> +}
> +
> +static void check_mas_alloc_node_count(struct ma_state *mas)
> +{
> +	mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 1, GFP_KERNEL);
> +	mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 3, GFP_KERNEL);
> +	MT_BUG_ON(mas->tree, get_alloc_node_count(mas) != mas->alloc->total);
> +	mas_destroy(mas);
> +}
> +
>  /*
>   * check_new_node() - Check the creation of new nodes and error path
>   * verification.
> @@ -69,6 +91,8 @@ static noinline void check_new_node(struct maple_tree *mt)
>  
>  	MA_STATE(mas, mt, 0, 0);
>  
> +	check_mas_alloc_node_count(&mas);
> +
>  	/* Try allocating 3 nodes */
>  	mtree_lock(mt);
>  	mt_set_non_kernel(0);
> -- 
> 2.20.1
>