Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 14:48:41 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Gautam Dawar <gautam.dawar@amd.com>
Cc:     linux-net-drivers@amd.com, jasowang@redhat.com,
        Edward Cree <ecree.xilinx@gmail.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        eperezma@redhat.com, harpreet.anand@amd.com, tanuj.kamde@amd.com,
        koushik.dutta@amd.com
Subject: Re: [PATCH net-next v4 08/14] sfc: implement vdpa vring config
 operations
Message-ID: <ZDQFqV5xfQBC6hWT@corigine.com>
References: <20230407081021.30952-1-gautam.dawar@amd.com>
 <20230407081021.30952-9-gautam.dawar@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407081021.30952-9-gautam.dawar@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?knDLcDnvt6ykL6grM+k7CP5h4rieq55xbxBFIoSlBXHXulIdnmEzsn51rAAc?=
 =?us-ascii?Q?ybq4E8qWdVPSzB62yv8Wn4sA3pgeDywIy2uwu57f/590TRIJQNgD1ARRyx2k?=
 =?us-ascii?Q?7ab3rRGdY86XQI4ytrcovdyunfWoOZBIYsDVVsvvUSkvE6lMs9CCzuS3iv2D?=
 =?us-ascii?Q?8hdVHyk+5cubdXc7CBgAQX64TSzm0nRkNmfjFMhoSPxEeXEU157lGjFpy7Ql?=
 =?us-ascii?Q?tVMipuqtvu/SKkm/xug+m9CB1rP3GHxasP2vYtEHGWPGHUXb11devNS/AJwJ?=
 =?us-ascii?Q?8ObqallwZmgpLgJoVpv4dudGa9PtmS2Qp97jLp2aNbqmAxiOO2UsmonQx1gi?=
 =?us-ascii?Q?WIllA4xbCPSDmjQJYdYBvAeHXSTKg2nEbQTb7F1UFtVFVBQ47PnFQKSpDBm2?=
 =?us-ascii?Q?n6xULicoX2PdDoLpLDBGs61ahDI9D/z/wC5PQb7fi0nTI+AUQYAkjCiKfNhV?=
 =?us-ascii?Q?7gLHRLXLECiRCcs3fz4zvzrWCsycZifbq9etqg4/BHLj36LXp/pkwB1SRidM?=
 =?us-ascii?Q?D/TXeRl7BpnyVa1h81oHdhboMFWdf5g/kT7nEfceQ9O2eRy/NicqjWWkf9PK?=
 =?us-ascii?Q?3el3VtE3KQDTeF/3ufqnkfjJUf0dzEohWAmGYkzhnijRIrNZc7H9iMrpt0Em?=
 =?us-ascii?Q?dcHX1X+hwBmjbRbvhpoEX5FkaFdioUp3PvJ2IAvslL8H1W4sqnZAIXiUHRSD?=
 =?us-ascii?Q?MpMTZ91HikChTpyjC7PHU80E9mqcfzHElcxk1G9usZ/pppabuyMW4NvJLq/s?=
 =?us-ascii?Q?Ke7ogf52YvDQl1HwlrcOxepiHEuWCk126iYBuH3Zq14AkcguNmRxwjKAw3TD?=
 =?us-ascii?Q?IBdkaAEqDoU8iT6ISIeWHF3l8mjPEdC34D7kmqfiaD+JvJXCNm1inOBA51Nf?=
 =?us-ascii?Q?O0Cgka8OxkASwd0ajkZ53i3g0MT9zNNNGXESikp9/nrRsxMrtST54BTjGQLG?=
 =?us-ascii?Q?G/1HJsJSx7WfhCIYMuZqxg2bUYYNegGpMVb/o1PcTRDMzlI+tufn7SXDQ4ua?=
 =?us-ascii?Q?bfz6TijkJf4oM4UJTNsGZAzapyxyxVZU2ntjyZVeaHRAU4ovbVpxGfeL2k+0?=
 =?us-ascii?Q?HTnbN11ob/nxa8syYj4be4xZFnpq20RshVN94e5rQdAzxbBy6Eqqvfbctqzd?=
 =?us-ascii?Q?KhOWdHxkeSF6mlvT8OepKDJKmgrX1qzQR+zv1ndGfATro44j+d8Hkkx6A9XN?=
 =?us-ascii?Q?6Jfc0R9puhRjnASVvtGpbIMGOZ7JWWWycZKs/CmepXt646uz4K1fqnXWeMEq?=
 =?us-ascii?Q?N2lRUvv3rDA28R0QA618zpgSYW2aYRDIfbzvo8ZOWDTMro6QIyH6AWHurtqL?=
 =?us-ascii?Q?RO60tz+GflUGjijTRyNJQo4kKTFuUNhlFdGztTFEh3m/wfxR0fm0t+8bNP8J?=
 =?us-ascii?Q?t5WTy8G4i5AhnFFMUVHaVNDk9HyR9BBsklZeIuMfVkFgVLbKPPD4oSXYx6tW?=
 =?us-ascii?Q?7EpBTaS4i3ySPS+SZWSJ2VcUAEKOyu7RUTjkkLW3E9iZMJrtZRHj/mEY7vyc?=
 =?us-ascii?Q?Y98l967Z+rX8tMMhpLZgvvs5HM46nYxe3HapEbyUctDH3OmwllB3z5V05R5L?=
 =?us-ascii?Q?7HCFEnAASq6+IzGM49MHIXsyP2wzzw/k7spIiybqWg19+LVB+SDhlh4Sp1dp?=
 =?us-ascii?Q?b0JWgM06qDvBg5BY8FE3xN3ijQIdnz+IN4GywwvOCg3VnFxTVk5z3+/Wes/t?=
 =?us-ascii?Q?D+uDPQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6ed5c29-46a7-4c32-a43e-08db39c1ed7b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 12:48:48.0490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RNLnXFZC87sWGOf7dlS5ojScAU6CuEGK5sK1IDnBzeiHK95mf8b+ydVmZQLZwWioGixjX5qP3NIHtbSeR6HI3/5sUsA/OvkFWE94Sj75Wog=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5314
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 07, 2023 at 01:40:09PM +0530, Gautam Dawar wrote:
> This patch implements the vDPA config operations related to
> virtqueues or vrings. These include setting vring address,
> getting vq state, operations to enable/disable a vq etc.
> The resources required for vring operations eg. VI, interrupts etc.
> are also allocated.
> 
> Signed-off-by: Gautam Dawar <gautam.dawar@amd.com>

...

> diff --git a/drivers/net/ethernet/sfc/ef100_vdpa_ops.c b/drivers/net/ethernet/sfc/ef100_vdpa_ops.c

...

> +static void ef100_vdpa_set_vq_ready(struct vdpa_device *vdev, u16 idx,
> +				    bool ready)
> +{
> +	struct ef100_vdpa_nic *vdpa_nic = get_vdpa_nic(vdev);
> +
> +	if (is_qid_invalid(vdpa_nic, idx, __func__))
> +		return;
> +
> +	mutex_lock(&vdpa_nic->lock);
> +	if (ready) {
> +		vdpa_nic->vring[idx].vring_state |=
> +					EF100_VRING_READY_CONFIGURED;
> +	} else {
> +		vdpa_nic->vring[idx].vring_state &=
> +					~EF100_VRING_READY_CONFIGURED;
> +	}

nit: the if/else above does not need { }

> +	mutex_unlock(&vdpa_nic->lock);
> +}

...