Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84c50299-5b5b-867e-1e96-2d3a0c6ade2a@gmail.com>
Date:   Mon, 10 Apr 2023 20:58:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: [PATCH 2/2] maple_tree: Fix a potential memory leak, OOB access,
 or other unpredictable bug
To:     "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
        stable@vger.kernel.org
References: <20230407040718.99064-1-zhangpeng.00@bytedance.com>
 <20230407040718.99064-2-zhangpeng.00@bytedance.com>
 <20230410124331.kijufkik2qlxoxjz@revolver>
From:   Peng Zhang <perlyzhang@gmail.com>
In-Reply-To: <20230410124331.kijufkik2qlxoxjz@revolver>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/4/10 20:43, Liam R. Howlett 写道:
> * Peng Zhang <zhangpeng.00@bytedance.com> [230407 00:10]:
>> In mas_alloc_nodes(), there is such a piece of code:
>> while (requested) {
>> 	...
>> 	node->node_count = 0;
>> 	...
>> }
> You don't need to quote code in your commit message since it is
> available in the change log or in the file itself.
Ok, I will change it in the next version.
>
>> "node->node_count = 0" means to initialize the node_count field of the
>> new node, but the node may not be a new node. It may be a node that
>> existed before and node_count has a value, setting it to 0 will cause a
>> memory leak. At this time, mas->alloc->total will be greater than the
>> actual number of nodes in the linked list, which may cause many other
>> errors. For example, out-of-bounds access in mas_pop_node(), and
>> mas_pop_node() may return addresses that should not be used.
>> Fix it by initializing node_count only for new nodes.
>>
>> Fixes: 54a611b60590 ("Maple Tree: add new data structure")
>> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
>> Cc: <stable@vger.kernel.org>
>> ---
>>   lib/maple_tree.c | 16 ++++------------
>>   1 file changed, 4 insertions(+), 12 deletions(-)
>>
>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
>> index 65fd861b30e1..9e25b3215803 100644
>> --- a/lib/maple_tree.c
>> +++ b/lib/maple_tree.c
>> @@ -1249,26 +1249,18 @@ static inline void mas_alloc_nodes(struct ma_state *mas, gfp_t gfp)
>>   	node = mas->alloc;
>>   	node->request_count = 0;
>>   	while (requested) {
>> -		max_req = MAPLE_ALLOC_SLOTS;
>> -		if (node->node_count) {
>> -			unsigned int offset = node->node_count;
>> -
>> -			slots = (void **)&node->slot[offset];
>> -			max_req -= offset;
>> -		} else {
>> -			slots = (void **)&node->slot;
>> -		}
>> -
>> +		max_req = MAPLE_ALLOC_SLOTS - node->node_count;
>> +		slots = (void **)&node->slot[node->node_count];
> Thanks, this is much cleaner.
>
>>   		max_req = min(requested, max_req);
>>   		count = mt_alloc_bulk(gfp, max_req, slots);
>>   		if (!count)
>>   			goto nomem_bulk;
>>   
>> +		if (node->node_count == 0)
>> +			node->slot[0]->node_count = 0;
>>   		node->node_count += count;
>>   		allocated += count;
>>   		node = node->slot[0];
>> -		node->node_count = 0;
>> -		node->request_count = 0;
> Why are we not clearing request_count anymore?
Because the node pointed to by the variable "node"
must not be the head node of the linked list at
this time, we only need to maintain the information
of the head node.
>
>>   		requested -= count;
>>   	}
>>   	mas->alloc->total = allocated;
>> -- 
>> 2.20.1
>>