Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 15:28:01 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvell.com,
        edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com,
        corbet@lwn.net
Subject: Re: [net-next Patch v8 5/6] octeontx2-pf: Add support for HTB offload
Message-ID: <ZDQO4RhUmUC6w6Hr@corigine.com>
References: <20230410084223.5325-1-hkelam@marvell.com>
 <20230410084223.5325-6-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230410084223.5325-6-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?myfgQYwSpiea6VfAuCxNxc8Uj4BUdaUKziHpFLrmAhKxxHB5wc79ljyl0/pV?=
 =?us-ascii?Q?LukowUN9Jm8r5dBOtg/Uc7OCfQ+HZPf+im/f/3MgGjgErYuIspnMp9zTpV3c?=
 =?us-ascii?Q?scABi+Ycwg6xWuc473BCkvXyqBb6YBx7JkrNuFhDPkjhUu9JMnxz3/boEY7C?=
 =?us-ascii?Q?Hmy7ovt/8gBGok9NIKfc54WIMUq49Pk5cGuiwoFMJMCJCSGKmbqBdTR7+SaE?=
 =?us-ascii?Q?UNuMADrKiYyeFkkin11O4nDXDFyGG8di+GH39rC5A6FjNnnRAkpVzd/8/2X3?=
 =?us-ascii?Q?vHC8AI+XYr5TsIKeozybWtsl2GDXl9ygHppfzP32j2lf7VLol2lq2xhQQGc+?=
 =?us-ascii?Q?q9lE5wbWjfBDMtySH1jDuTYf4NBYUhx/E6GNaACfhfzMNWkQz7iQgUONsAp9?=
 =?us-ascii?Q?PRzFBiG+p0Qx6TCGcxalwh4pTsp6YdzwLK0XgmeJlRkT45ujMIKXA6lm/Mt5?=
 =?us-ascii?Q?t1YurtTqnEVsH2ysFiZl4WOwfs6ir1EgRT/cQl/KWHkbdErUYjSb487FdLp8?=
 =?us-ascii?Q?Hr6Od9LbmTeP7wRWqlq440HZit5pZNKec4AbB3CWTYPDl1idjtDwaSuDQKqY?=
 =?us-ascii?Q?TCH6PFVg277XuDPmxH8gobyXuVstdVELz2/mYmFdaV1KP4MTplZEIeqs1hDl?=
 =?us-ascii?Q?pEQ3Q5/lnzz0cgGNUpEIDfIDQzv4T7z0qNL5zX1erheOkc2sYgLejc5noou7?=
 =?us-ascii?Q?wqirpPDd1DiPGbXnKwaTFRKZvuj+goDA/oZgqq/Z5cbGhKRfoXSV1yp2AkTl?=
 =?us-ascii?Q?cqmeVC8p/Rj7pBwmtvOZk7YdblFLh5QMt0ZEkABq1q8m00dZtk4A7RV39vhk?=
 =?us-ascii?Q?sywdB/yJV1FZJuao1BmM0h/w1Sqf/t856iwHYjE2i6TuiKYTo4uoU0qoRCVO?=
 =?us-ascii?Q?axnJ1DRRvRpbrPTKr77kjACJrsC7DprW1w+Qcjpau9C0UN89MKTkfP/JJdSF?=
 =?us-ascii?Q?LmTH3PdFHkxQcH7MBkqFVtMKtu3uwSE9a5BexBrk43J2gW9OZm4HReEmOM7r?=
 =?us-ascii?Q?mHOb+jnPXyXF0Imw9j8niTMBogT3NcaSUxBxPcUn8ISNjOWt/Hfwn/4GbW+z?=
 =?us-ascii?Q?uUeE11Fmp5tTVySqggDD6Xn0mr7lF0b2w/uekiAXJgMj1GiKDF4J9uN+4ADy?=
 =?us-ascii?Q?3c9Iscvplx2S2ErkUtwcfayYwEkVrIEiP+xynsALbL3gTLG6Wf2RdffuP+o5?=
 =?us-ascii?Q?XJotjXgDkW12j/t/ZfJG2tQhYcXHPbmDLsyfFh0Wn7ob8r04PJeQzMArqrV4?=
 =?us-ascii?Q?ZVBAsTswNVIX1wB49GRUdsvK5n+p3t/SLrOENmMV/kvOU5xQiZCgIZHMYRO+?=
 =?us-ascii?Q?ZB9m0rXtSLn069HEVOrXvHzbZ0kuaxWekYDhpdRk32cJP6asAOiwdazqkIrL?=
 =?us-ascii?Q?zBqd3PF0rVLEQ+UI7Mu1RthsHQyf/2G1IRrdvz3vhbcJVVzC3LI40JMjLTeU?=
 =?us-ascii?Q?cP8/RzJ+wEAgrcOf6kUGHLLpM3StjktFSIp7DOIFbAN70u0eBor2XNgAvXhT?=
 =?us-ascii?Q?6YBep10hdJcu9pHXkqcdZNYaOkSuUgtktwc7U3HQe8hKVGWvsJBcNJUptyYQ?=
 =?us-ascii?Q?qUDZK2RPwKRpsgyLOl/liVDWmteghF7Wxo7V2J6tpXTYzSUC5q8H69waiD9c?=
 =?us-ascii?Q?TIGiOlRRysgoQvzVpk/bhFLspmy02Ti/y4ae3jza2bRAaSXaQ9+Pc3pnHd1P?=
 =?us-ascii?Q?T/C2bg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5624ab5-1e2c-48de-1aa9-08db39c76cde
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 13:28:09.4168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JoDhcO3iKjUrhbdteujf5VEYT5VZPcif7GASC4NfFI3qWBuDjmtZMeYXo8S7LaKE6p8D1glaZJPzzEzcUdval3RxeBpQg1+gfUlCAEnN2tM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR13MB4481
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 10, 2023 at 02:12:22PM +0530, Hariprasad Kelam wrote:
> From: Naveen Mamindlapalli <naveenm@marvell.com>
> 
> This patch registers callbacks to support HTB offload.
> 
> Below are features supported,
> 
> - supports traffic shaping on the given class by honoring rate and ceil
> configuration.
> 
> - supports traffic scheduling,  which prioritizes different types of
> traffic based on strict priority values.
> 
> - supports the creation of leaf to inner classes such that parent node
> rate limits apply to all child nodes.
> 
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

...

> +static int otx2_qos_txschq_alloc(struct otx2_nic *pfvf,
> +				 struct otx2_qos_cfg *cfg)
> +{
> +	struct nix_txsch_alloc_req *req;
> +	struct nix_txsch_alloc_rsp *rsp;
> +	struct mbox *mbox = &pfvf->mbox;
> +	int lvl, rc, schq;
> +
> +	mutex_lock(&mbox->lock);
> +	req = otx2_mbox_alloc_msg_nix_txsch_alloc(&pfvf->mbox);
> +	if (!req) {
> +		mutex_unlock(&mbox->lock);
> +		return -ENOMEM;
> +	}
> +
> +	for (lvl = 0; lvl < NIX_TXSCH_LVL_CNT; lvl++) {
> +		req->schq[lvl] = cfg->schq[lvl];
> +		req->schq_contig[lvl] = cfg->schq_contig[lvl];
> +	}
> +
> +	rc = otx2_sync_mbox_msg(&pfvf->mbox);
> +	if (rc) {
> +		mutex_unlock(&mbox->lock);
> +		return rc;
> +	}
> +
> +	rsp = (struct nix_txsch_alloc_rsp *)
> +	      otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);

I think you need to check if otx2_mbox_get_rsp returned an error here.

Smatch reported this as:

drivers/net/ethernet/marvell/octeontx2/nic/qos.c:719 otx2_qos_txschq_alloc() error: 'rsp' dereferencing possible ERR_PTR()


> +
> +	for (lvl = 0; lvl < NIX_TXSCH_LVL_CNT; lvl++) {
> +		for (schq = 0; schq < rsp->schq_contig[lvl]; schq++) {
> +			cfg->schq_contig_list[lvl][schq] =
> +				rsp->schq_contig_list[lvl][schq];
> +		}
> +	}