Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4155297rwl; Mon, 10 Apr 2023 07:02:50 -0700 (PDT) X-Google-Smtp-Source: AKy350Zr0WQSgfxmOvTu7QilRDglBrZkJNEPXsGXSszFKSh+4PcYiGeQARp8MC+acZHIzLp48Nhi X-Received: by 2002:a17:906:4d13:b0:94a:56b3:ee66 with SMTP id r19-20020a1709064d1300b0094a56b3ee66mr5153429eju.31.1681135369912; Mon, 10 Apr 2023 07:02:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681135369; cv=none; d=google.com; s=arc-20160816; b=SiK2QUpA7rl14RSDBdT6wTo4J2UIy1FiWvu1Mp5TVr4Z05dyxDTmdfS/jtg9ntBcck I7q+HoP4K3jPbPc3aJFy7ZrTOCNRrxLR3Y7sKeKId6Wc5YhPRcENg25phpJHSKbdFBk5 vjjmI7P/xocna1WIsXTTAz2nhG7nmR8n+97Icbv7EbEnbkfiVcP7WaHfEo2BsWdvLhLO c5G+gvIS/Rs4nGZW+OqYHYu9k/+C/1uKhgmONtAw+taOT5PViTjv0Vo+DfgxPEavlVdh rVLFxOyjxGNsiApi9CMOYYOKAhfzstlXLcNsWtDkA1c7ZGwXELV94pLjw+rMUa2DFeeU jMaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xJiy5asiUhmQxlHjXRXu9kHZp3LovZa44g8LjX7RzaE=; b=0Nz3C74zKksZqXJsM5mnGX4hid7rqAq1KJuvvVhgtC3nTmymCczNIUwQgiUI8sUrjY 2BF9fyA5MqfyXpgn3JM4Flgx3ILh9cCKj7fj5Vis5UNo91V/5Kwml55F/Dq4608YyO5D J7F5VwrXJMtg4aRLkXL7EOsTbj4jdFlZQ7Cmu6mEiqEblaKGkaahqWzGR73KTlbFRlR8 TncgIOLGu8FTzhyki7BX65MzF3o5jVb5qK7KzL2Q+esAuPgw/KboHkawkerkxqHWyyXF Aw6PJGZvNRLbrTASy+dhS00DuLB0XOLBu/6HCTui+zBVAiHvB8o0s8bfdU3gwdQ/9dpR fvSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=LSDK9hfv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sn9-20020a170906628900b0094aa2fe0da2si1197809ejc.444.2023.04.10.07.02.22; Mon, 10 Apr 2023 07:02:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=LSDK9hfv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbjDJNwL (ORCPT + 99 others); Mon, 10 Apr 2023 09:52:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjDJNwL (ORCPT ); Mon, 10 Apr 2023 09:52:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5495A49ED for ; Mon, 10 Apr 2023 06:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xJiy5asiUhmQxlHjXRXu9kHZp3LovZa44g8LjX7RzaE=; b=LSDK9hfvS470b8r0sjcgHolIMj fjCO4XrBHUI/jZPzk6H8Q4gmgsTnOtsF9aD/E+O4cU40BzunkQ2U69NHqeZlByju5NkjbZfN7VvW+ j5cfaeW+UKixZKr1urBwdEAaU+go2YbR8FWZlyZ/71SlUYqN73b3hzdnIY350Mtp+tFj+DYVNclxh M40l1YLgmdA2ThhJpXWz9CgSZz8XaeTUp6h1Xbhbei1VYLnUvwmZNa7ELmZ62x0RGWEerRI1X48IS CswZJETP5FiBxshp7iZsk0BbLSa63VfwK4zSxWZ79M89ko/LT2tzY0ErJzcD7zVrJ/FHTpNMMuQjB 0NF4pJQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1plrvw-004E8M-AG; Mon, 10 Apr 2023 13:51:48 +0000 Date: Mon, 10 Apr 2023 14:51:48 +0100 From: Matthew Wilcox To: Peng Zhang Cc: Gang Li , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman Subject: Re: [PATCH] maple_tree: Use correct variable type in sizeof Message-ID: References: <20230410091431.74961-1-zhangpeng.00@bytedance.com> <8b5af22d-1612-a2a0-02da-728f1fd57bf1@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 10, 2023 at 06:09:27PM +0800, Peng Zhang wrote: > Maybe sizeof(void *) is equal to sizeof(unsigned long) > in most architectures, so I don't know if it counts as a fix. This is actually required inside the Linux kernel. The only programming model I know where sizeof(void *) != sizeof(unsigned long) is Windows 64-bit userspace.