Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4fbb44b-ed31-96b2-2342-b654299f72dc@amd.com>
Date:   Mon, 10 Apr 2023 10:47:46 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] drm/amd/display: remove unused matching_stream_ptrs
 variable
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        nathan@kernel.org, ndesaulniers@google.com, Jun.Lei@amd.com,
        wenjing.liu@amd.com, Jimmy.Kizito@amd.com, Cruise.Hung@amd.com
Cc:     llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230325134503.1335510-1-trix@redhat.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230325134503.1335510-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlVRd2YwV0U5WkxxZ1BIZHVvNUZxTVM2U3FLV1c5RDBkNWkwWG1XblJRTDRm?=
 =?utf-8?B?eHc5MllDNGJzcURpblRJbXFJZ3FzQUtaMVIwYmVhQWV2emtoalBGUGZUZnBo?=
 =?utf-8?B?RGZaVS9UN0ROZXl3RVArcEN1VjJlWFFNODljdWhkUUl1V3daS29ycERvd2RG?=
 =?utf-8?B?NDlyeHlkSThGZ3BZVVVpbTgySDRoS1dBaXlYck9RMlluZjdINU40MjZiSVZw?=
 =?utf-8?B?SEx2TWFuRVU3ekpMT09uSDBHMmk1bkJ6UlpmTDE3NDBxSUExWFlENld5ZzA0?=
 =?utf-8?B?MUh6QWw1QXN3TW5obEV4QW5FRGhwVUF1ZStLU3dydk9pMHdKLzZtM3YrWVoy?=
 =?utf-8?B?d3VRalJ2MG5rbFlCWU1XcUE5bEtrc2J5aWUyemtFbTRnSFJoZE9ocG03R1Fi?=
 =?utf-8?B?YllnNGNiMWYvNkZvSHpSNEE2RFM4R21GRi9LVzU3Qk8yL0xxUjRNN2ZZMExC?=
 =?utf-8?B?UWpGZmNKdkwzTklDV1RvOFRFUG03dW85Z2VPSHlrQUhVNEJPajEva3hDNnpQ?=
 =?utf-8?B?Q2N2bklLY2RBYTJObHl5N2dhZXhzTUdGdGU2UGxNMmpQRkpVYmZ6MW9hSHI5?=
 =?utf-8?B?Q2tadTh3ZzJvakkwNFdudFZFcTlEejM4eTB5YWI1YXhYYzNkUm5JTkpSc3R0?=
 =?utf-8?B?ZmVnYU1hT1ZtZ0ZwVmRmUmtKUUhVNVlnN3JXTG9MNXVEdHZpOFU2RG11OTVs?=
 =?utf-8?B?elB6bENnejRpRHJtQmNpdmQyQVRXelA3ZWJjaFlrc1BNVDBTSHcvK1hwTm9j?=
 =?utf-8?B?ZElmaE82aGRYWnRMQUkrNHNkcmcwaUc2TDRwdGxhaCtHRk1kT1RCZ2FFL0Zm?=
 =?utf-8?B?Uy9oWURNTjFHdW0zekp2YkFFTFdESVdkeis0b0V6Um5MMThkeVRab1o1SWUy?=
 =?utf-8?B?RFFaaE5NRzQyQUFTNGUzTTJINWtyNHB3V0dVT2hRMTZYTXRVSEE1M01DYkxj?=
 =?utf-8?B?R01Qb0YwSTg0S0xxajVSUERydXhYSmRxS0R3ditFa3c3SDR2Z1NOemRlWW9V?=
 =?utf-8?B?TjVMU2pNRVFqTjVBTTlOMStaRWZRUk5QZ2trU3RhUE1ZNGhzWFFkdWhpZDVr?=
 =?utf-8?B?d0NZZmhMdEFYejVpVEpLZitwL3pxbFVWY240aEtxSWs3QVBidXVmbHhxL0lR?=
 =?utf-8?B?V3VBVDJvT1Y2M25xU0xQUm9yWlR1YVNmYktiZldTQ3pxYVRZK2ErQldqVFVq?=
 =?utf-8?B?MkZlc28yR1FNS043ZTVGeERQT2FHbllSeTJVVnZuRmZiTzR0a1QxRFFHQzMz?=
 =?utf-8?B?MGRqWENtYllLdFlnZUY3N3RhbjZSbGZLbUZlYkZvUHFiLzVwelFYVkhmQWlM?=
 =?utf-8?B?bEZEenNWMHVYTTdOeW9VM2tzeUFMdWMxNG1TYy9BSlh5RStiUnRxM2dNbTV6?=
 =?utf-8?B?MlJYcC9mdENuL3Z6M1ZDS0QxcGh5bXAwYnEvY2x0TzRxbUJ3Q3NYWDVZN1pr?=
 =?utf-8?B?NEQwSVpuR3BTMDAzNlVWUWlPb1R3Z1lOKzBrYS80MTBNd0VOanJvcDBvWldt?=
 =?utf-8?B?YW1uN1IwMmNacmJGZFpNSTJlVHl3MnNXbEp0U0JuZTNxckN3NVRYZzk1Q2VI?=
 =?utf-8?B?R2xqc1NBMHhKMlByRVhiaWxIcE9DbzZHelpld3l3U1NnaWlqQ1R6aGUxOXp3?=
 =?utf-8?B?cTBPVUY4OFY0YmlCTnBWVCtlSXVKV3JpN1dwMnBJbjFvM3JnbkZPZTAvejRX?=
 =?utf-8?B?emlTMkpsbnFMUUdyUnRvd0NhVTNCaXVPbmVMbXBZdUlJZUVMNEVodVV3VVhn?=
 =?utf-8?B?ZWExbGdhRUh3WHBEKzlSVlVXd3NZNVM4bTBPNC9xLzcyamoxeWxPQUVzM0tm?=
 =?utf-8?B?Q2x6eU4vai9OVlBxT0kvRlk1YUljdkh6azRjd0pna2x0OS9hd1ZWQWR2RkxR?=
 =?utf-8?B?VmdDbVMyTUlvY1dJRW5HR0VxNk14UTNWRUYrZUwzNXduSWJtSzJRWk01aHlM?=
 =?utf-8?B?M0I0NVpiQTBMWGtBN3o0eUE5dmRxdWp3Ry8wYzZWdGF5VW5la1c4amV6enNx?=
 =?utf-8?B?Q205SEJ6VU4vdzdOaGM5MzliU3Aza3c4RmQ4cUZRUjNVejF0M0RLeEtVL2VB?=
 =?utf-8?B?QWN1dnUzK1NKRUNmV0JFSmFxdFNkVCtkTVRGYkZvbmNkaE9QZEFjKzJJRDJQ?=
 =?utf-8?Q?WSAdqpvoG4PsK5UPaxWY+SVE4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b40c687c-927c-4f80-8e7a-08db39d25b9d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 14:46:24.8760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mpKUB3+KvIo5ohLBroyRwydNfWZ6RCIgHRxFFwKTRlcQmztky9WRn5cXZGosemYLlWfQalVsYIjaAgqgyo2VOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5771
X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_PDS_OTHER_BAD_TLD autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/25/23 09:45, Tom Rix wrote:
> clang with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: error:
>    variable 'matching_stream_ptrs' set but not used [-Werror,-Wunused-but-set-variable]
>          int matching_stream_ptrs = 0;
>              ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> index 41198c729d90..30c0644d4418 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> @@ -622,7 +622,6 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)
>   	int i, j;
>   	uint8_t valid_count = 0;
>   	uint8_t dig_stream_count = 0;
> -	int matching_stream_ptrs = 0;
>   	int eng_ids_per_ep_id[MAX_PIPES] = {0};
>   	int ep_ids_per_eng_id[MAX_PIPES] = {0};
>   	int valid_bitmap = 0;
> @@ -645,9 +644,7 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_state *state)
>   		struct link_enc_assignment assignment = state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[i];
>   
>   		if (assignment.valid) {
> -			if (assignment.stream == state->streams[i])
> -				matching_stream_ptrs++;
> -			else
> +			if (assignment.stream != state->streams[i])
>   				valid_stream_ptrs = false;
>   		}
>   	}
-- 
Hamza