Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e912dd87-f518-bb82-0c18-be4fb2b11b8b@amd.com>
Date:   Mon, 10 Apr 2023 10:48:51 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] drm/amd/display: set variables aperture_default_system
 and context0_default_system storage-class-specifier to static
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        Brian.Chang@amd.com, Martin.Leung@amd.com, David.Galiffi@amd.com,
        Ethan.Wellenreiter@amd.com, martin.tsai@amd.com,
        tales.aparecida@gmail.com
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230406195818.1958162-1-trix@redhat.com>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230406195818.1958162-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVIwWkk1TGRNcEt0R21pa3hKTG5jQnlSM0xLaENlMk40MHFQeVZ5UStoOXEw?=
 =?utf-8?B?c2cwb3hQaDFQbFc0N1U3Zm9QcGNlaEtVdVNhcGRnMUp1VzhHK3EwSm45MVl5?=
 =?utf-8?B?K3p1US9oM1UvdjZIWEMwT3ZtM0plZ20yVGg4YXY3RTVWekd4ZVZYSjNwRXM3?=
 =?utf-8?B?cExVaEFlOUZEY00xK2U5SDltYmt0OHluaVhvMkJGcXhGM0VTVXJMRGt5dHpT?=
 =?utf-8?B?QnRlMHF3UzFDTTVPcHBwbUc1UnRSMXBlRDFmU09qMXpmWS84eG9BNFlSMW90?=
 =?utf-8?B?WmJWcldZWFdOWisvU1dpMG4zZWRrY0FHVzhxSGY0emJoK3VDWng2VS9YQkVm?=
 =?utf-8?B?RDdLUmNxUHc0MEs0MXpUWnR6dTFScGtrMzEwVUVVY0JDSWZzQlpPM0h5UjNP?=
 =?utf-8?B?elVsd2lqdHdQL0JaLzZidFNONkdhMUJjMFpEdXl2VEJGNGhLZDhnZjBaU1U1?=
 =?utf-8?B?MG5CU0M4WGxSelY3MlgwcTRObWpZSkcyamY3RkNmUlVvRjJpN2xscVVmbzFw?=
 =?utf-8?B?amFUQ1ZKOWtJbmNuWE9HVG5Ib2hkWU82ZzNLL3FncFNrLzFMUm05OE5oRmp1?=
 =?utf-8?B?VjgxcWVzb1RnVERFVnlyT2VkMk12eEFuS2Z6QjJNWFhYeWVZbGpPT1phdjlU?=
 =?utf-8?B?cmloYzljUkdvWVlZSGtDcnk1NnBLYWhMeXF0ZXdQRkxpT2dTbFhkZFpEdFUw?=
 =?utf-8?B?YzByTU9pckRtdzFSR1FieVRMaTZneERIb2Nib1JySWtOVVFzbEo5MXFLVHJJ?=
 =?utf-8?B?VEc1ZDJES2FJTlp1YnBUWWU3VTFsV0ZONTMvQldJRjJWT0ZzK1U2UlRlVVgx?=
 =?utf-8?B?VW0xSVRNTGFkSUdkekRSYTdoU0Z5SzlEWHJaZU11T1Q3Ui9LRy9QN3hzaUY0?=
 =?utf-8?B?Nys5REF2a3ZidU9OTUZ1ZGhZcXBpM0kzc0d2ditMbTJNb1VNVE02T0doUmZM?=
 =?utf-8?B?NFpoSmpDT24wZ1BCdDQvSHNyRWIzbExLbzR5VUV1N2JwbFZiQTN0QjczVlZV?=
 =?utf-8?B?NjFtd0kxd0NTaEE5Zmx4dkFaQmk4M3hyb0VkcDJiZUUwYS8yQ3V2MDV3QUd0?=
 =?utf-8?B?Qi9oZWR0MGtwQ1BYbjNwUUVnb0NCbkgwZnBaWmEzWXNuU1hoZXFubVBrR2dD?=
 =?utf-8?B?dFVLNjVPWk5ER2VrZ1RzYlVFSzJDSGNBSnd6Yjhkdy9JMjl1Q3ByMml4TkFW?=
 =?utf-8?B?QmV6WEt5bjUySnJzSGlCWkU4U3h1Z200SWFBZHRGMm9nUU54elViWmFabFBE?=
 =?utf-8?B?cWhnSFdFMWVHUFN3UzNFWTRoOGFPQ1hBV1JQV1FjN05XTXZKVlAxRUlOS21Z?=
 =?utf-8?B?UmNlMURUanBFU2RsTnpIL1dxRW5wRDZ2Z2dPM3l1N0xMaDJTVk1jdlNPeUpQ?=
 =?utf-8?B?TERUYm1nbzlKM1lPZ2tYRXpueDRXNXpJaTdldk1LVzFGL011YW02S0RiakJT?=
 =?utf-8?B?VVRGOGZCQWoxc2lEWG9ITXR6UnlwWVpBUndQTzBTc2dEOEZkVWl1V2V6aDJT?=
 =?utf-8?B?TWhTbGVlRytDVW1oQkcyVnJhVTFCQll0VWJha2F2Yk9scVhLeGlBOENPZndj?=
 =?utf-8?B?VXpBOEpycG4rdjlEWjBvZUI4WkdwWFphVVl3eEdzWFhlNlFPM011SUNwbUFF?=
 =?utf-8?B?dmpDdDBaUzA0bk91RkdCNkNxek9FMGkyR3B3STNrTjRiZElDcTVyQVYyV0lS?=
 =?utf-8?B?QUZvNjdFRVBWZmJ4aWczMThwWWNGbUZ1Mk9jTnprR1VCejFhRzNJYU5STGZV?=
 =?utf-8?B?V0N4TDZOREkyanRIS1dYVy93T1Q4QlFWSlZGZmZacnV4SUhPVVlDMmZoSElC?=
 =?utf-8?B?NC9sTGtSMkU4bElWdVEzNGc1YWpiSkNRUkRPVWxadXVhbkdHaXBHWkVmeUZ6?=
 =?utf-8?B?Rmc1LzRmWXZBczNFQ2hiLzZTcmxudHFxMXhteE1oU2l0WHFSZURsS1ZPbzhu?=
 =?utf-8?B?UFg1VXBCdnRGdm9jTUNxeHJCOTV4emtoOE9BcGZFS0g4b1hSaTMxL1dWSGtk?=
 =?utf-8?B?MEI1ZG9RVjV1TXBraVRKbUkvd3IwY3BKVmZ6Y3U5a2lFNU45UmZYSWdvcVpC?=
 =?utf-8?B?TjNsejVTSE5EZEFLMFVBemVlRXZYUUh5TkV6R1N5STNMcTQxaS9XRVhYaTRx?=
 =?utf-8?Q?ovfXCX+uYMUPyHdceN2vXG7ny?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63659b1c-27aa-4f69-de9e-08db39d28153
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 14:47:28.0651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LuOQYDMzn+8S3xmPFWtjGsa+Wwz29RAYCjkRdvZCqavZN2wql322bCmnZKS/Hz6GqemKq0m8gvJolH/poadAtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7110
X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/6/23 15:58, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol
>    'aperture_default_system' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol
>    'context0_default_system' was not declared. Should it be static?
> 
> These variables are only used in one file so should be static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> index a142a00bc432..bf399819ca80 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> @@ -755,8 +755,8 @@ bool hubp1_is_flip_pending(struct hubp *hubp)
>   	return false;
>   }
>   
> -uint32_t aperture_default_system = 1;
> -uint32_t context0_default_system; /* = 0;*/
> +static uint32_t aperture_default_system = 1;
> +static uint32_t context0_default_system; /* = 0;*/
>   
>   static void hubp1_set_vm_system_aperture_settings(struct hubp *hubp,
>   		struct vm_system_aperture_param *apt)
-- 
Hamza