Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 16:50:33 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jesper Dangaard Brouer <brouer@redhat.com>
Cc:     bpf@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
        Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        alexandr.lobakin@intel.com, larysa.zaremba@intel.com,
        xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com,
        yoong.siang.song@intel.com, boon.leong.ong@intel.com,
        intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
        jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com,
        john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net,
        tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH bpf V7 1/7] selftests/bpf: xdp_hw_metadata default
 disable bpf_printk
Message-ID: <ZDQiOZ9VR7CEVUTr@corigine.com>
References: <168098183268.96582.7852359418481981062.stgit@firesoul>
 <168098188134.96582.7870014252568928901.stgit@firesoul>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <168098188134.96582.7870014252568928901.stgit@firesoul>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kXvAi4c9jzFx1xP1fQSdcQcVFdyR3A6rJmNOoz8e1ow901XDzdeuIkdIfO3Z?=
 =?us-ascii?Q?3F67okR/EKsQkpQCkCZqnY3BYIIEloiKD4lVfCzYNkeTmJnLnHl4s8BJG335?=
 =?us-ascii?Q?Rmb4ZD79kT4lKSPS3+jgLLzwOjwNwxotf7Yh6coW/M3jbwSVMjG8Socc0z15?=
 =?us-ascii?Q?+nC6yLbTSK5NTVgYwP5cNcDVEkLgNErD1eiSV7zKRCbRAmKR3l1nGpDdk3Aj?=
 =?us-ascii?Q?FwSk2JLlcUJlt2eh12Q56NjixeJKvG9lcN8a3ijVfL7+aw+7dRIf+cHZ6o2g?=
 =?us-ascii?Q?6kRJM6Q75CiUUaWfG+nMMhgLhAoU1bLbJeJMC1cZE4ROqOTY4zHNg/hklcvy?=
 =?us-ascii?Q?kut7JczItNm63QlmG3cK36F/Awlk2zGfNDwLHQJgiAgU3uVi5QWftAtO/m9O?=
 =?us-ascii?Q?4uBq5eQlUe7GkGuJQzDyYWzv7p75gmi9MiKrztKoIFoCGaHspUsDOPSgD12J?=
 =?us-ascii?Q?mij4SR5UVUA8Z0Dq8tIkpJuW7eo3f8uAiDUJtMR6Ou7j1FKvgXdPP6uc7et8?=
 =?us-ascii?Q?WfeVJRkIGKMQmiqcvxGzemQIzB2HxgbQOL4TasTc9QgE5aOVV580rM4jpvtd?=
 =?us-ascii?Q?HHF9Imr/aULCjNuYwOaObrdO2nB6TL/9bUlrnEYzur7w9emBN8Gp62pHHawv?=
 =?us-ascii?Q?BQJJ4ycevRhB6sxn2lymrXQ9mllLTXiWda+yL0P1FsggCbhoiaLiYbcTxkNU?=
 =?us-ascii?Q?e4G4EHbRT0E/qCv7at2qgm7WTze2E+Kp7KcGeDysZNhAtW2ASchnUaEN8wCC?=
 =?us-ascii?Q?pztW/PvmzXqo7pShkzKx50UhqkYBS3GO3p48AACTc5LjsQyF/9bVqjkcD30l?=
 =?us-ascii?Q?bGZeXp6172t/bwO9C8XljHsOBKi0H8nJR50M0JowvQNknsCS6mgFZH2LhOmQ?=
 =?us-ascii?Q?Iu9jCDdqJpDSOE1dJrHfWfSDtABL1nM+UWv7RUdnjUvAsr1sDWCpM/tJiVWx?=
 =?us-ascii?Q?VxSxSv1qe/KMBfgIcfhpL37VfR4EqTRTzHtJ8Edi3m4VDGio30sT03f634G7?=
 =?us-ascii?Q?UasjAOCiS5T58/q5runog7qCJhamHG5NRjTP3sOpDlKkcbf+DltKKTl6hRU2?=
 =?us-ascii?Q?M5LPVFUzZzj9PJhZCzgdOqg/orSN4dEVTbXIQ+BWYo4YOshFpoRxGM1dsNr2?=
 =?us-ascii?Q?2X2VzuEY2iX9e5lK51uDeeBq4LMNnZbXjPH0y50Ep+nNTLHNkZuE8Vf4IE/W?=
 =?us-ascii?Q?k35LSATyZCzz+56Cplfy4bUfh0Kl+sSFSuby4FAKBk7f1iqW7FXIrSUWvxus?=
 =?us-ascii?Q?4gziobEoomV/Ta7lWRE3/+h8aI4Xx54ZhbBy3oGMqYLaitt7lqFYdvyWQLXz?=
 =?us-ascii?Q?tTyE8UL8McpuGJU1S2mlyfL847PM6lMX/inpCfOGkFgI/Dbn9ag4rLR+IeVm?=
 =?us-ascii?Q?DFusR+mgBD9T4L11sHtuyRdJx/62Bq4LThYcdLYLnk3Gfb4tnnNLPRjGzaDN?=
 =?us-ascii?Q?Gm9RvT6OE/u6pVtPXnVx5aqxYthHxBaMA1k4ePxWhJ6mnhWwp0OuOdOZlCPF?=
 =?us-ascii?Q?GYUAhD9LT0TrSEmD3Ou5AeSEkqYik14ksIY0wzdujm3RWtw7GQuqul1rHhgG?=
 =?us-ascii?Q?WGoMpSHBBiS10P3us3ghSrk0NpbgVtC8ZexoNGE+TBttDLPlK38gdkpmeRl/?=
 =?us-ascii?Q?jjnIR2HxWoIB/Xb9P2GfQsG1LtXUTkI8OQH1W/p3JtwEew7TRmguXZ7JZQTv?=
 =?us-ascii?Q?C7tWXQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe04e250-3420-492e-608c-08db39d2f580
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 14:50:43.2905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BsuMYq0EUiuIfwXbBXcDHuYou9XVBrVEHvOjuKar0qx+4SR4ScH+sOUEhK9aFNAjmo9p35j2BceWGdE8Y1ThRb/NW3HES9UY9OxPmf9qP/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB5064
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 08, 2023 at 09:24:41PM +0200, Jesper Dangaard Brouer wrote:
> The tool xdp_hw_metadata can be used by driver developers
> implementing XDP-hints kfuncs.  The tool transfers the
> XDP-hints via metadata information to an AF_XDP userspace
> process. When everything works the bpf_printk calls are
> unncesssary.  Thus, disable bpf_printk by default, but
> make it easy to reenable for driver developers to use
> when debugging their driver implementation.
> 
> This also converts bpf_printk "forwarding UDP:9091 to AF_XDP"
> into a code comment.  The bpf_printk's that are important
> to the driver developers is when bpf_xdp_adjust_meta fails.
> The likely mistake from driver developers is expected to
> be that they didn't implement XDP metadata adjust support.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
>  .../testing/selftests/bpf/progs/xdp_hw_metadata.c  |   16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
> index 4c55b4d79d3d..980eb60d8e5b 100644
> --- a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
> +++ b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
> @@ -5,6 +5,19 @@
>  #include <bpf/bpf_helpers.h>
>  #include <bpf/bpf_endian.h>
>  
> +/* Per default below bpf_printk() calls are disabled.  Can be
> + * reenabled manually for convenience by XDP-hints driver developer,
> + * when troublshooting the drivers kfuncs implementation details.

Hi Jesper,

a minor nit from my side:

nit: s/troublshooting/troubleshooting/

...