Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 17:11:18 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jesper Dangaard Brouer <brouer@redhat.com>
Cc:     bpf@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
        Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        alexandr.lobakin@intel.com, larysa.zaremba@intel.com,
        xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com,
        yoong.siang.song@intel.com, boon.leong.ong@intel.com,
        intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
        jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com,
        john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net,
        tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH bpf V7 4/7] mlx5: bpf_xdp_metadata_rx_hash add xdp rss
 hash type
Message-ID: <ZDQnFmZdESpF1BEz@corigine.com>
References: <168098183268.96582.7852359418481981062.stgit@firesoul>
 <168098189656.96582.16141211495116669329.stgit@firesoul>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <168098189656.96582.16141211495116669329.stgit@firesoul>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjRpdE1kRElXZkVkRXMzS0kvai9NaTZEcm1xUTRCeVNVdXN2MEx2dzQ0Yk5q?=
 =?utf-8?B?S0FDMzR0TXBER3FlNU1EZjZ5Z3pPbmxVQjZVYmRUL1g4VFFrZzlmT1dtcm9Z?=
 =?utf-8?B?NzN6L3hOKzBVRGQwK2RRTGVqcnQzdzhtQ1dST3hFMDU1MlE1cHJhOG9ScVF4?=
 =?utf-8?B?T3MrQXVWT20zTG5qcDRHYXpqcFFGajRpa0VCUlRiTEV6S1ZxQ3Zna3BBZnd4?=
 =?utf-8?B?NjF5dlBQU3NOWXp2dDBCeHM5ME00NXU4ZitLMW1wRUwvMk44ankwZ0diLzJl?=
 =?utf-8?B?dmVVWFdkYVcwQ2xDQmkrenFJaVVXMUEwWUpIbVIvUXN1aWgxazVtNmxrSkhP?=
 =?utf-8?B?ZWI3WEl2Mkp6K1ZHS1Q5L0wrWlhUMUh0NjRXeTRSZkR1VER4cldYUEM4Lyt0?=
 =?utf-8?B?R1dqVXVnZHpJdWxWL1RMN3c5V1E3dndzR2tybDRyU3dLcVQ2SjBpTmtGUmZk?=
 =?utf-8?B?NU9lTlFqd0F5SGlXbHN2VHBHWkNKMDZPd3ltd00zUWJSNEM1Qy9tejFLNUlF?=
 =?utf-8?B?bFJwRVdhVGR1M1YrdGdMRGZiYzROVWNIUG00cWQ3RkFQR0Jub0dvK2dGbFAv?=
 =?utf-8?B?ejFPcng0ODk1NzRNdnlhM09JY1BjYnB2TEVQSHVFVmYyaEs0dyt3RWo0cHBB?=
 =?utf-8?B?Q0VmK3Nadlh4ODJ4d2ZFczNaQncyMW1UYnhzV3VocFpqRld3UTZmbnJZaHIw?=
 =?utf-8?B?S1JmSDIwMFlOT0ZUUGYwRmdBYll3anJHSCs2WTl0UXlRWEJPcXU2L1cvKzdZ?=
 =?utf-8?B?OEF6YlN6a0ZEeE85M05lSmVLY3FQTy9EZzdXa0JPSXVtR3crcm1oQlh2dk41?=
 =?utf-8?B?MllhMmhCdTc5cXZwb0lnQnFDVFNEQmF5SVVWK0U5aEF1WUdUNXoyUytBK01n?=
 =?utf-8?B?bGpEZDg4RlV3b2VmZ3Yya2ZrNHlpTVlVaThyUzRQR252eHh0YkVIRStta3lo?=
 =?utf-8?B?Vk5LMUYrZndDRmJzNnZtVGxFMU0yWG4zMmtKTFRmNkIyZ0FSZHR1MkUwdjJU?=
 =?utf-8?B?eElrcjlsUnlhcWVTRlVUdW11c1g4R2RMb2VKWXFQR1ptZlF4UDBzMys2T255?=
 =?utf-8?B?UVNxMGJPcUJER1dlb3RnZ0I0YngwM0FVaS9LMTc4eFlIUktYMUpqTG1NOTBr?=
 =?utf-8?B?VWNQOEEvNVplVHJwVDRDSm54Szd2eEo3L2JpbHY1d0MwUmtVQzhZZ3hBOUNm?=
 =?utf-8?B?bk5MU2lJQTVVL1hXemRCVXdxbzlWSStEOUdLTUpCRXBSTnFQVEVzalc0UkhI?=
 =?utf-8?B?ZmNCRFdyblRlRHNrWEZwdHp2WjhUQi92cXloVE85eU5iZVJVTEpVVFZDeUR2?=
 =?utf-8?B?TGdoUDFtZ2xSdDlPSmRkNVM5a1dSZkhXRGwvZG5rcWdiVXdTZlMrMGNtak0z?=
 =?utf-8?B?dWU4Q0F4U1hGSGtWZ0lQcGJjY292TFAvZDRub3Z3SWl6MUV5MERxK3lNdlc3?=
 =?utf-8?B?VlpKcW9Zc3pBY0p1WGFlaC9pOEc2RUw0VFVNS3JSK3lsVFFXV1ZPZldTaU04?=
 =?utf-8?B?b1NCOFVkZmNsaDdoWFJmMktSRmx6RTM1RGlpdHgzd3h4NGRzb1BOSFdwWFpv?=
 =?utf-8?B?MmtkNGo3R2RyY2VTb01mNnVTQXNGdVRzRThDaVZPQnJYYTNMaENmZ2VpbTBY?=
 =?utf-8?B?Rmludk9TM0RrbGpjM3ZkazZ2blN6N0dqZE9QUFBkcUxlNmVkWnllTytZbnhE?=
 =?utf-8?B?em53MkN0TXlMcU9pbUE3dGJoYzAzWU8zcHp0MEZmUXN4Yy9IbUhCSDdJeEk3?=
 =?utf-8?B?dGlMYzNDWkRrc0gyZG9rY2lOYnJvWFBpSTBzZU5jbXI5Z3ZVOS96WXZMZ0pG?=
 =?utf-8?B?Mk1HZ3FVc3BKYVJLbWd1RlJWL3BBYmxBT29Tb3dSK0p0NExnekljVGY0V0gw?=
 =?utf-8?B?WlBXdlVhSlJiQlRMaUtOZk5jM1NFWVI5bFBkdXRNb2VVTDZtVC9uZ2ZPTENQ?=
 =?utf-8?B?eFFadWp4bkNzczVpaUxmQjU0clN5KzhxTW1VSWhWQlBhRjhBeEZWYjg3WWNy?=
 =?utf-8?B?WmcxZGg1RGl1WlFDdzJnekFaSnVzaVJMbjFVLzF6Q2ljZndhQlJYRTgwd1NJ?=
 =?utf-8?B?aFlOOEQzcU56N0JBRlljWHdPN2c4cTE2dWR6Mk92ajEyYVVWVTJ5eWlwUVB2?=
 =?utf-8?B?djhQdWQ4Mjh5MHg1cWpjeURaUHlqa0UyVXdMQ1JmYXNvM3lEWjJPTnlraEhv?=
 =?utf-8?B?bytKbkU3bzhKTUI2VU9KclhHUkkvNXkrdzNzNEJwekVGa1NlNkkvcGQ3RkM3?=
 =?utf-8?B?bDV5TFF3N2dobjhBNmJyNFp2NzJRPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62b44a2d-743a-46bf-1254-08db39d5db91
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 15:11:27.9706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7534XWCX7KJ8U8QB5ReIs8PGQBeIvPRCGjSQLqL+33AV1ZVWSvGBeXxytp3phitit0hcjNUVoNdJwHiPpBBYOTCbK2xQExnf/Aw78xS8k20=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5418
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 08, 2023 at 09:24:56PM +0200, Jesper Dangaard Brouer wrote:
> Update API for bpf_xdp_metadata_rx_hash() with arg for xdp rss hash type
> via mapping table.
> 
> The mlx5 hardware can also identify and RSS hash IPSEC.  This indicate
> hash includes SPI (Security Parameters Index) as part of IPSEC hash.
> 
> Extend xdp core enum xdp_rss_hash_type with IPSEC hash type.
> 
> Fixes: bc8d405b1ba9 ("net/mlx5e: Support RX XDP metadata")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Acked-by: Stanislav Fomichev <sdf@google.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c |   60 ++++++++++++++++++++++
>  include/linux/mlx5/device.h                      |   14 ++++-
>  include/net/xdp.h                                |    2 +
>  3 files changed, 73 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
> index efe609f8e3aa..97ef1df94d50 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
> @@ -34,6 +34,7 @@
>  #include <net/xdp_sock_drv.h>
>  #include "en/xdp.h"
>  #include "en/params.h"
> +#include <linux/bitfield.h>
>  
>  int mlx5e_xdp_max_mtu(struct mlx5e_params *params, struct mlx5e_xsk_param *xsk)
>  {
> @@ -169,15 +170,72 @@ static int mlx5e_xdp_rx_timestamp(const struct xdp_md *ctx, u64 *timestamp)
>  	return 0;
>  }
>  
> +/* Mapping HW RSS Type bits CQE_RSS_HTYPE_IP + CQE_RSS_HTYPE_L4 into 4-bits*/
> +#define RSS_TYPE_MAX_TABLE	16 /* 4-bits max 16 entries */
> +#define RSS_L4		GENMASK(1, 0)
> +#define RSS_L3		GENMASK(3, 2) /* Same as CQE_RSS_HTYPE_IP */
> +
> +/* Valid combinations of CQE_RSS_HTYPE_IP + CQE_RSS_HTYPE_L4 sorted numerical */
> +enum mlx5_rss_hash_type {
> +	RSS_TYPE_NO_HASH	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IP_NONE) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_NONE)),
> +	RSS_TYPE_L3_IPV4	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV4) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_NONE)),
> +	RSS_TYPE_L4_IPV4_TCP	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV4) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_TCP)),
> +	RSS_TYPE_L4_IPV4_UDP	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV4) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_UDP)),
> +	RSS_TYPE_L4_IPV4_IPSEC	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV4) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_IPSEC)),
> +	RSS_TYPE_L3_IPV6	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV6) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_NONE)),
> +	RSS_TYPE_L4_IPV6_TCP	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV6) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_TCP)),
> +	RSS_TYPE_L4_IPV6_UDP	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV6) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_UDP)),
> +	RSS_TYPE_L4_IPV6_IPSEC	= (FIELD_PREP_CONST(RSS_L3, CQE_RSS_IPV6) |
> +				   FIELD_PREP_CONST(RSS_L4, CQE_RSS_L4_IPSEC)),
> +} mlx5_rss_hash_type;

Hi Jesper,

Sparse seems confused about 'mlx5_rss_hash_type' on the line above.
And I am too. Perhaps it can be removed?

drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c:198:3: warning: symbol 'mlx5_rss_hash_type' was not declared. Should it be static?

...