Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Song, Yoong Siang" <yoong.siang.song@intel.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Stanislav Fomichev <sdf@google.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>
Subject: RE: [PATCH net-next 3/4] net: stmmac: add Rx HWTS metadata to XDP
 receive pkt
Thread-Topic: [PATCH net-next 3/4] net: stmmac: add Rx HWTS metadata to XDP
 receive pkt
Thread-Index: AQHZa5S9mRB50P2QwkG1pXlh2ZtnBK8klgKAgAAUx8A=
Date:   Mon, 10 Apr 2023 15:33:48 +0000
Message-ID: <PH0PR11MB58304A6BD97AB6DEA58067D5D8959@PH0PR11MB5830.namprd11.prod.outlook.com>
References: <20230410100939.331833-1-yoong.siang.song@intel.com>
 <20230410100939.331833-4-yoong.siang.song@intel.com>
 <ZDQZeSe5OaFlNKso@corigine.com>
In-Reply-To: <ZDQZeSe5OaFlNKso@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wz6sFGgLiUdqnn7XcaOGvH+1ScmAUgp+t2g6OzLb1BB+tSdw2Z63yRx/GGeY?=
 =?us-ascii?Q?ccpmXtvoihUZkq4mfjA/pkwRlJ6PrYuBWGQfef1+Lbc0MvptkMEZfcfSN2pt?=
 =?us-ascii?Q?39QykykUDTS779ShzYFGW1VvKxj7SA6LfWSQpszEUT29WDPP8vZsw7rYFolN?=
 =?us-ascii?Q?R3qRF+jmH8k8KWEsQeIB84qHXRlhwtAYiprbzaUqpSPFZT7mmBb101kxBwg9?=
 =?us-ascii?Q?mZiIX+Y2l9zz+S8dCXgQKNKTayAEsKfi3/ITiTXUdz1a8I4MJRQD/H6JW0t/?=
 =?us-ascii?Q?mPzvbzXUwZKXtR3WUAsES5hmAitUEDN9WraYUYZodyUyZvgakJP0H+KPV6b/?=
 =?us-ascii?Q?MKaag2AWAlX9SbS33NV1P34g4pN9o+GdpgsFfBFeMKAs1tfLNvlCo6kj1ygK?=
 =?us-ascii?Q?GNTydaol48kXMuooyTbENSWMzQxnEmqnC8Rc8BPDkEb07hbZ0ThjzWIX7xE5?=
 =?us-ascii?Q?jEPtvZgeonwKGgMM6lp6CF5Oht0d3clE4fJtHznc3VKRzF4z8OkzcEVXtEaG?=
 =?us-ascii?Q?BIZXjulbEwxchEFmK9V/hZiIgf9x2yOTne4xhtQIRqN8mbzJnba+bY4iwYfK?=
 =?us-ascii?Q?QmH6NXpmVBCAJb7ZdYKcC70KwbmFbbWEVG5YXRMyPt15thuSe6MI1Up5Xvzg?=
 =?us-ascii?Q?Ts84k1CaBICBqzhUBALhYA+divFmIluonWROlodLU+isLTOVhghHuDkW/82S?=
 =?us-ascii?Q?se2BUlxg6moOZoB5mAPIs4u2TauVbVT9qvZBgJKbZbxWEuujz5tZpQf9c6Sd?=
 =?us-ascii?Q?BV0z/OTXjs53LDA54h3ls1ReC1848LVwj3WCGunoMQ0Pcwm1PqLVJjrHzuhv?=
 =?us-ascii?Q?+eIeo5Gy0h84o6GUnIOVskoqrG7oz9QBUkbk8PWpAU+auy630loV0sR5DLBk?=
 =?us-ascii?Q?okqtf1RcU5LHaSh/YdpvOvao2PkArE7B391+PtSjTaJJIuGA7K5N09oyS3SU?=
 =?us-ascii?Q?5ZjMNP5ZZJjJRAZCVuhuhf32st+b9gFFWp1S2VMaqkh9TE85kyfnllyZahBj?=
 =?us-ascii?Q?fTVvfclxnz44G95vR9rJn/YxttODo/+Yu4GrDfN0anmdYw9SpQDdki9M/iaW?=
 =?us-ascii?Q?Jjj3nfpXOWUNOGnIfD9KISlVpKJQ0YIxkBGlMb8bLsfCeN24cQ4I/bfoYASn?=
 =?us-ascii?Q?Fh7cM0sF75P46vAvNhpuTyYJfAzVHRpI6qU9wK967HY+XfF1GLGXFdryeg77?=
 =?us-ascii?Q?gxAlaqVAeyFTCU4rBvaBUsZSQtVxsE6mj6ca/hGRLyYtBEPKmeI7CJbIFFnc?=
 =?us-ascii?Q?TvSh+PDZ2YtflXzi+RJx/37zQ2WHKlRyhZM4FoKHvHD2xeNUxe5KEwZ1iKN7?=
 =?us-ascii?Q?RoGixhRk5xbPiM/hcq1t1nmwaMeGDcq9Z/mgeN6hTA2gQR7Gkn4ryj8JdiEP?=
 =?us-ascii?Q?5ar19NH1ooIOUQd3jxjWoQGpbrWbK4bjo8e6f2DAmHM+qPw2qcSzVvUVnN2I?=
 =?us-ascii?Q?F2VKx2lj/TH24ggjryBVG28bZ8cEKT7LTqnjQFR1oN9wO99rbhQi2kjopASU?=
 =?us-ascii?Q?W+ZZ+dsMIPFwe/DzlQulJhjFtfR3tM52/Lz13JWcIJwnVUHLTvvT4fGInKUj?=
 =?us-ascii?Q?r6QT/vubAFJWYraZeB4g4HGB01ey/FG2uW6Slyv7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5830.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9b172aa-80bd-4303-bbf4-08db39d8fa7f
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2023 15:33:48.1373
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jPn45OTNDhMM+PkC2AtMVt736kbKGXUkhA295h4UlWgcCbT9N3ggJ66QudPrlOS6kEA/o9o6WsgINyb5wZYumgF5JMJLGVjgF3qkj2qbDQU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7867
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Mon, Apr 10, 2023 at 06:09:38PM +0800, Song Yoong Siang wrote:
>> Add receive hardware timestamp metadata support via kfunc to XDP
>> receive packets.
>>
>> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
>
>...
>
>> @@ -7071,6 +7073,22 @@ void stmmac_fpe_handshake(struct stmmac_priv
>*priv, bool enable)
>>  	}
>>  }
>>
>> +static int stmmac_xdp_rx_timestamp(const struct xdp_md *_ctx, u64
>> +*timestamp) {
>> +	const struct stmmac_xdp_buff *ctx =3D (void *)_ctx;
>> +
>> +	if (ctx->rx_hwts) {
>> +		*timestamp =3D ctx->rx_hwts;
>> +		return 0;
>> +	}
>> +
>> +	return -ENODATA;
>> +}
>> +
>> +const struct xdp_metadata_ops stmmac_xdp_metadata_ops =3D {
>> +	.xmo_rx_timestamp		=3D stmmac_xdp_rx_timestamp,
>> +};
>
>sparse seems to think this should be static.
>
>drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7082:31: warning: symbol
>'stmmac_xdp_metadata_ops' was not declared. Should it be static?
Yes, you are right. It should be static. I will add correct it in v2. Thank=
 you.

Thanks & Regards
Siang
>
>Link:
>https://patchwork.kernel.org/project/netdevbpf/patch/20230410100939.331833
>-4-yoong.siang.song@intel.com/
>
>> +
>>  /**
>>   * stmmac_dvr_probe
>>   * @device: device pointer