Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4340860rwl; Mon, 10 Apr 2023 09:32:34 -0700 (PDT) X-Google-Smtp-Source: AKy350YHVqMtqDeh2ZZEAxW3Ou4f620LLeEgZ94SMCT7VA+yC/D8/4dXI2aibwdb7teoQ6T8VDiQ X-Received: by 2002:a17:902:f291:b0:19c:d7a9:8be1 with SMTP id k17-20020a170902f29100b0019cd7a98be1mr10887509plc.61.1681144354664; Mon, 10 Apr 2023 09:32:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681144354; cv=none; d=google.com; s=arc-20160816; b=BJrSP/asO6vXIOn91T5WLv0rfQCaf/3725RIwUPcQq4pn3AHGr6DNfYBnuRJBVmKZe 1aYkOX+BYyBwm5PbGNyrVHrppZ+FqXnqI96IvtPjTKAje5ANtEcXLIWg96d6nCkqv2VG SQ0OLI+ibO1uAsldjMCe7u+YYE5GBTKkHo5318sofSDRcOZIZriBBs+dmFyRz5Hob1hb HPw1yWGdazuUMHABN3L4LXPPAgICXA5lze9suVKQ9EheeTclca8XGPYFulyrMXqxkrAp ILKtPIGU829kaLy1+pQGLOSXVTpj+LzjyiY925FOVHJV2KeD0MZ6hFIKGXw7OEsii/t0 0qQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=sHVVN6oTtru9Zp5JWJbbh+zOuZxw8Uvr9aoYu9AkWkM=; b=krfsgHqVteWPmRsaYaqKiF37CF+EojZCDlhGtzgCdQN75w3NhIRfuFF/duJm2dbWBT blB20Xb6muefndCWbug2BOE3LkJgkC+EHVngpg8VMyh8nxyfrfsLYSIP2J6Y1+9TrciS j7pkkD4HRf5+c9Jw1f6/6/hNP3dxxNNso8SZ2uUMw04pikrZSDf1R5gtZkO/OUVl5K5g nAMAJ5vSozRDpK1zf4ID1U+I+2DCn0CI+8uBzxJbuoelVZjqYZ2K7to275PCw8V1ByRK VOB+YA129X523TbQ8MmT4KFMGdCyvWpExgiB4KRhWTW/8GlfUkZvZYG6hj74HuPSpis1 EK/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Y3CDiubL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i6-20020a1709026ac600b001a63783159csi3626086plt.238.2023.04.10.09.32.22; Mon, 10 Apr 2023 09:32:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=Y3CDiubL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbjDJQbq (ORCPT + 99 others); Mon, 10 Apr 2023 12:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjDJQbo (ORCPT ); Mon, 10 Apr 2023 12:31:44 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D5419B2 for ; Mon, 10 Apr 2023 09:31:43 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id q15so2117486ljp.5 for ; Mon, 10 Apr 2023 09:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1681144302; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sHVVN6oTtru9Zp5JWJbbh+zOuZxw8Uvr9aoYu9AkWkM=; b=Y3CDiubLut2AB6QPV32bn/FfuOMZWWix66aTa31ZRqltIrsJFxAgIlNRPOewA3MZBr nJxKYWYlqk8hgLD+6TwUnJB1pxm0/CRalftqoW4fcn4UW/49Q3R5HX65hXxLlHddhDAT 6vUgKi5L+bn/tx1Mz/BQRITWMKXE8FkZvr2DPhVXenQTmb0UiwqosO3qnabdMeQvwogg +ZU9MculDoXd1poXG2BqEvgleELf7EOLXg1UOuhY7mhM7nGE80JXW8om0mgGsFcOUoml E8cBqkDEte6py5pFWlKxbmUKaBGZ37TvpBtEdYnH8jXYsBUhmeYWepBPDH8hyxCp/BFj 6lkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681144302; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sHVVN6oTtru9Zp5JWJbbh+zOuZxw8Uvr9aoYu9AkWkM=; b=O1wVGLqof9oXcjgKQErh4ZYmXe4VGmzi8aY3eWYhGV8jmomu5Ps7sKEOUSEKFXnH/1 ormYn0AG6rOEDiLzbsLe74xx+agsYGu4fsvmq6pJ81YOsPpf9+jNAA1/A77SfeRgRPAD QxUHsF0rlEjpesGgI50uQ4cl5/7515kLAtZGXHhEpQDDkBL0LD1SRVcyj2mhB0XZZ0J1 Gu8X6U749mDiCRpesGmj139jjCGik46k/eNZFjCkzt/Xw1lqqZ09RpNbm/hp25Uw7HA7 o9MEH9TjTfk3ufIztNyiZtWvRU4J7g8UFUjqw6c2qxqSCy1OTHAo1WG1bzXs5uYfhEDR i08A== X-Gm-Message-State: AAQBX9cdk84HVwkteHLPVmC1hTzfjS4f4FJc3xJRdVmsFSLS/SDutn4A lKRi1rd3p6q5ijZwsgl/Tr+OMGsJxd8CvMW5brVK6A== X-Received: by 2002:a2e:780e:0:b0:2a7:7470:4ebc with SMTP id t14-20020a2e780e000000b002a774704ebcmr1368279ljc.2.1681144302005; Mon, 10 Apr 2023 09:31:42 -0700 (PDT) MIME-Version: 1.0 References: <20230326144701.3039598-1-nikunj@amd.com> <20230326144701.3039598-5-nikunj@amd.com> In-Reply-To: <20230326144701.3039598-5-nikunj@amd.com> From: Peter Gonda Date: Mon, 10 Apr 2023 10:31:30 -0600 Message-ID: Subject: Re: [PATCH v2 04/11] virt: sev-guest: Add simplified helper to assign vmpck To: Nikunj A Dadhania Cc: linux-kernel@vger.kernel.org, x86@kernel.org, bp@alien8.de, thomas.lendacky@amd.com, dionnaglaze@google.com, seanjc@google.com, pbonzini@redhat.com, michael.roth@amd.com, ketanch@iitk.ac.in Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-15.7 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > -static u8 *get_vmpck(int id, struct snp_secrets_page_layout *layout, u32 **seqno) > +bool snp_assign_vmpck(struct snp_guest_dev *dev, int vmpck_id) > { > - u8 *key = NULL; > + if (WARN_ON(vmpck_id > 3)) > + return false; Should vmpck_id be a uint to match the module parameter or should we check if vmpck_id < 0 ?