Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fc52d5c1-61db-b8e3-e608-12434b0ee740@linuxfoundation.org>
Date:   Mon, 10 Apr 2023 12:30:04 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 1/3] tools/nolibc/stdio: Implement vprintf()
Content-Language: en-US
To:     paulmck@kernel.org, Willy Tarreau <w@1wt.eu>
Cc:     Mark Brown <broonie@kernel.org>, Shuah Khan <shuah@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230405-kselftest-nolibc-v2-0-2ac2495814b5@kernel.org>
 <20230405-kselftest-nolibc-v2-1-2ac2495814b5@kernel.org>
 <ZC8OwUPAC4s413jP@1wt.eu>
 <cbece9a0-b8d0-4f3e-9a55-9fe87e111392@paulmck-laptop>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <cbece9a0-b8d0-4f3e-9a55-9fe87e111392@paulmck-laptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/23 12:43, Paul E. McKenney wrote:
> On Thu, Apr 06, 2023 at 08:26:09PM +0200, Willy Tarreau wrote:
>> On Thu, Apr 06, 2023 at 05:19:10PM +0100, Mark Brown wrote:
>>> vprintf() is equivalent to vfprintf() to stdout so implement it as a simple
>>> wrapper for the existing vfprintf(), allowing us to build kselftest.h.
>>>
>>> Suggested-by: Willy Tarreau <w@1wt.eu>
>>> Signed-off-by: Mark Brown <broonie@kernel.org>
>>> ---
>>>   tools/include/nolibc/stdio.h | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
>>> index 96ac8afc5aee..6cbbb52836a0 100644
>>> --- a/tools/include/nolibc/stdio.h
>>> +++ b/tools/include/nolibc/stdio.h
>>> @@ -273,6 +273,12 @@ int vfprintf(FILE *stream, const char *fmt, va_list args)
>>>   	return written;
>>>   }
>>>   
>>> +static __attribute__((unused))
>>> +int vprintf(const char *fmt, va_list args)
>>> +{
>>> +	return vfprintf(stdout, fmt, args);
>>> +}
>>> +
>>>   static __attribute__((unused, format(printf, 2, 3)))
>>>   int fprintf(FILE *stream, const char *fmt, ...)
>>>   {
>>
>> Perfect, thank you Mark, I'm glad that it simplified the rest of
>> your series.
>>
>> Acked-by: Willy Tarreau <w@1wt.eu>
>>
>> Paul, feel free to directly queue this one for 6.5. If you prefer I
>> can as well queue it on my side and send it later, it's just that I
>> have exactly zero extra value on top of this one ;-)
> 
> Alternatively, if it would be more convenient for Mark to send this
> up via kselftest:
> 
> Acked-by: Paul E. McKenney <paulmck@kernel.org>
> 
> It currently merges cleanly with the -rcu tree's dev branch, so this
> should not be a problem.
> 
> Either way, please let me know, Mark!
> 
> 						

I can take these through kselftest or can go through arm64

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah