Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Takahiro Itazuri <itazur@amazon.com>
To:     <seanjc@google.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pbonzini@redhat.com>, <zulinx86@gmail.com>
Subject: Re: [PATCH] kvm: x86: Update KVM_GET_CPUID2 to return valid entry count
Date:   Mon, 10 Apr 2023 19:38:45 +0100
Message-ID: <20230410183845.98304-1-itazur@amazon.com>
In-Reply-To: <ZDQveaSDYx+4z5t4@google.com>
References: <ZDQveaSDYx+4z5t4@google.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Date:   Mon, 10 Apr 2023 08:47:05 -0700
From:   Sean Christopherson <seanjc@google.com>
> Capitalize KVM please, i.e. "KVM: x86:".

Will fix. Thanks!

> I think we should break from the (IMO) somewhat funky KVM ioctl() pattern of
> 
> 	r = <errno>
> 	if (try something and it fails)
> 		goto out;
> 
> and instead set "r" in the error paths.  That avoids the need for a scratch "nent",
> and IMO makes this much more straightforward.
> 
> 	int r = 0;
> 
> 	if (cpuid->nent < vcpu->arch.cpuid_nent)
> 		r = -E2BIG;
> 	else if (copy_to_user(entries, vcpu->arch.cpuid_entries,
> 			      vcpu->arch.cpuid_nent * sizeof(struct kvm_cpuid_entry2)))
> 		r = -EFAULT;
> 
> 	/*
> 	 * Update "nent" even on failure, e.g. so that userspace can fix an
> 	 * -E2BIG issue by allocating a larger array.
> 	 */
> 	cpuid->nent = vcpu->arch.cpuid_nent;
> 	return r;

Looks better to me! Will fix this too!.

Best regards,
Takahiro Itazuri