Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9549e422-e5b2-ccf6-3c8d-ac61436e7fa6@amd.com>
Date:   Mon, 10 Apr 2023 16:53:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, avadhut.naik@amd.com
Subject: Re: [PATCH] EDAC/mce_amd: Decode Cache Level "L0" Error Code
To:     Borislav Petkov <bp@alien8.de>
References: <20230410203357.17704-1-yazen.ghannam@amd.com>
 <20230410204710.GBZDR1ziKdqr4ihJZh@fat_crate.local>
Content-Language: en-US
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20230410204710.GBZDR1ziKdqr4ihJZh@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHp4SVd3T3k1d01vOFVTREhkSHNtRzhmc1lDK1ZGVGZBUFg1QXNIZXM0THoz?=
 =?utf-8?B?MU10YkUwWXhweEIxSVhQaFlNazFhNmo0cjQxUjJQQ3pRbGZrYUQ4LzFMOGRM?=
 =?utf-8?B?YzlqSzEvWGlSYVNPemNFaGNZZEJZZkNwSGpBQ2FLc3BGbytqT3lzYnRZRW5q?=
 =?utf-8?B?cTNCYlEyZERubTlsdU9rZElyWkMzZ0U2dDFuN0RRT0YyVVd2SWoxcSt3aWhE?=
 =?utf-8?B?dW5RbGNYQkRmYVhOdmlIVnA2bkMxdzQ0L0k0bWtsODd2SmNWcndPNnFMUHI4?=
 =?utf-8?B?RWV1eFF0aWlCTU93V1RNQlJPUHl2ZmdwVysxMUc0em1FV0VIbFBianJnTVBE?=
 =?utf-8?B?dEdLa0lFeWpNUTQ4UnNudVBDVEw3S2h5U0J4a3RnaWZ1T01iN0NtbHZWQ3lq?=
 =?utf-8?B?OEZQSXdsWS84YzkvRXFkYW1Wb1Vwa2VRZnlKNitvMDl0cmRYeEF2SXVleTR0?=
 =?utf-8?B?SERGa1ZJMzhxdlVGd2FPeHlzZnBzMnVvWjd1T2NZZE1xcEx5OWdHbnBpNXlP?=
 =?utf-8?B?Q1V4V1ZUVXUvWmZmTFRnNzM1enBoYlo2bzdZYXlmL0p1eTZVaXBUM2pCSTlS?=
 =?utf-8?B?SE1haUdoWVhpb0orZGppaFRjRld3ZDBzV0xrQ3pUVkpPNUtCenlSWWxXZ2ZG?=
 =?utf-8?B?L1p1ME05a2p6QzhxTU1MSDFTZml3VnBUSjVzQXlxOGZ5eTJtbG1SVStSZ2Rs?=
 =?utf-8?B?ZERZR0RuRHh2bDh3ZUswanRRYm5rOXIvMHM4TDBnQ28rZWlleGQxTS9GWHpn?=
 =?utf-8?B?bnNnbXpraTM5TnAzbW51MlR5RmRMY3VJcG9FWTBRbkgrdXVxdGIrdEZFTDZs?=
 =?utf-8?B?QUxWdGtFZk1GMWxrTW1RWjJnampRLy9GSDNnTkg1MWNLbnA5aUtqbk0rUC90?=
 =?utf-8?B?QzEwVktyeGY5ZzRNMjdHUGc2QkVxT25nVFg5YWJjZWRZUWZDVFdmT0UzOE5t?=
 =?utf-8?B?R05DUDV1aldGRjYySE5vR1pnNUphcTEzMnRoMzZobmpRKzJVMzN4QVBQbzhp?=
 =?utf-8?B?RGxHTGIrOVJCRysybXNaaUs5Zk5BVXIwcTJsWjFYRTJkUXZCWWFJUGNjOTNv?=
 =?utf-8?B?a3NLZ0NpOUNDdXdzcHNuYldGemJFNCtVVXFPRUJrUUV2VmVYNWlUd1dIa3k2?=
 =?utf-8?B?RUd6SXBwNE9mWTZRaWV5ZlRpS1grMEVHb0t5cVRKWDA3VVV6UWd4dUI4NFQ1?=
 =?utf-8?B?S1YvekZhQVhOL25pSHJkSHhEWnhleFEyZ1dscGxSb2tDalJudUxtcktRd0E5?=
 =?utf-8?B?YjRuQlNWSnJzNEdsSjArNnRFQkpNNC96NGRzZ3RjYVo2Y3NlT1J2UndQcVpR?=
 =?utf-8?B?TDR6MVVsVkVTSU5Db25zT1BKWDUyQ3IvQUJNQktBeXJja2ZoMWZyTTNWVVIr?=
 =?utf-8?B?RWhHaEdIL24yRmxnU3JCWjlqYWFkSkUxK1kvZkV2NkpnZGYvODFIYUVVOFVi?=
 =?utf-8?B?dk9Sc29sWWF1SkRIQ3kzeEtWOTh0MGF1N1VnRy9iOGtRVmZDZVVFdjdWcmxv?=
 =?utf-8?B?Y245QytITFNUbEVoa2FRRlQ0WitETGlMWU93amZRV2NjbDNVeExwTWk2MDNn?=
 =?utf-8?B?VTFNZXNsMmowaEg3T0xYQzE0RDJVY0RWbUlzWi9EcXJINjRnWjI3U0cwYmNX?=
 =?utf-8?B?M0tDV3FOWEtJYjhxUHo2czVzZjFMRWNFUGFwS0R2cXNCbGYrTDVjZkN5R2ti?=
 =?utf-8?B?SUpUKzJUWkx1YVJja2daQlI2L3dtSll5ci9OM3g0Wi9DUy80RFYvQ01oRlhy?=
 =?utf-8?B?VVluM1lXRjJKR2c1UkgzUDdhM1ZSZnYwYjBCakR5MWpMMDQxNnM3QThIcTBl?=
 =?utf-8?B?V0tKM0NVWkpNQWt5U3RsNHlvSFc3SkwyNi9nSGR0TU0xVC9jYm9HWUZISXI1?=
 =?utf-8?B?M3ZDR1hkM3NCOGdVL1BMN1J6dm5sYnFqVWNrdDFmMFpWUGRkUFdtOU5hQW5w?=
 =?utf-8?B?THZDYXk0UHJmMHRQaExZd1lVSk9vd2R6WUxRVDRxOCsyM2k0QWgwRkpMbzlL?=
 =?utf-8?B?TmpaeG9wYTZ3c1BRR2YvZkZCcWlTRUlkcEg3U2VNcmxrc2hCakFXU1FlT0Fm?=
 =?utf-8?B?VzYzTzA5dnlrZVhMQU9BSEJiamVFMnlmSGlraXl0cFF1cG5jbUhSV1pQanl6?=
 =?utf-8?Q?CiW4GcGFiDEaW+w9mMZ6fyUiN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7870f3c-2915-48f4-9145-08db3a05b0c9
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 20:53:51.9974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D/61NyONtEN105DH+mHFbSujDlTL4gT+kcA4fJ4umeFMdGviwNTBn99bErESlXsWHnrVD0helia/g0RIq/h6Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8419
X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/10/23 16:47, Borislav Petkov wrote:
> On Mon, Apr 10, 2023 at 03:33:57PM -0500, Yazen Ghannam wrote:
>> The "L0" cache level is listed as "reserved" in legacy documentation.
>> This has now been defined as "Core" in current documentation for
>> Zen-based systems.
>>
>> Update the cache level strings to include this new definition.
>>
>> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> ---
>>  drivers/edac/mce_amd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
>> index cc5c63feb26a..1d1b9da3b9bd 100644
>> --- a/drivers/edac/mce_amd.c
>> +++ b/drivers/edac/mce_amd.c
>> @@ -37,7 +37,7 @@ EXPORT_SYMBOL_GPL(amd_unregister_ecc_decoder);
>>  static const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" };
>>  
>>  /* cache level */
>> -static const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" };
>> +static const char * const ll_msgs[] = { "CORE", "L1", "L2", "L3/GEN" };
> 
> Still used on legacy machines. I thought we agreed we'll move all the
> decoding to luserspace, for newer Zens...
> 

I was thinking about that for the Extended Error Code descriptions. But good
point, please disregard this patch.

Thanks,
Yazen