Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758813AbXIYPqS (ORCPT ); Tue, 25 Sep 2007 11:46:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755880AbXIYPqE (ORCPT ); Tue, 25 Sep 2007 11:46:04 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:35190 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755845AbXIYPqD (ORCPT ); Tue, 25 Sep 2007 11:46:03 -0400 From: "Rafael J. Wysocki" To: Linus Torvalds Subject: Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7) Date: Tue, 25 Sep 2007 18:00:12 +0200 User-Agent: KMail/1.9.5 Cc: Andrew Morton , Damien Wyart , LKML , Len Brown , Frans Pop , Alexey Starikovskiy , linux-acpi@vger.kernel.org References: <20070925065109.GA3080@localhost.localdomain> <20070925003340.5d6dd7f4.akpm@linux-foundation.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709251800.13272.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1812 Lines: 44 On Tuesday, 25 September 2007 17:40, Linus Torvalds wrote: > > On Tue, 25 Sep 2007 08:51:09 +0200 Damien Wyart wrote: > > > > Hello, > > > > After testing rc8, I noticed that I couldn't power off the computer > > directly, it only got halted and I had to press the power button > > manually. Just before displaying "System halted", the following message > > is displayed: > > > > ACPI : PCI interrupt for device 0000:02:08.0 disabled > > > > I had to first revert 5a50fe709d527f31169263e36601dd83446d5744 then > > f216cc3748a3a22c2b99390fddcdafa0583791a2 (handling of Sx states) to > > recover previous behaviour. > > Hmm. Those things *do* seem to be suspicious. > > For example, those commits seem to move code that used to be inside > CONFIG_PM (which pretty much *everybody* has) to be inside > CONFIG_ACPI_SLEEP (which is a totally different thing, and depends on > whether the user asked for suspend support or not! > > Damien - does it work if you ask for SUSPEND or HIBERNATION support? > > Len - why are you guys moving stuff into CONFIG_PM_SLEEP? I know you seem > to think that absolutely *everybody* should always support suspend and > hibernation, but the fact is, not everybody does. And it's a totally > separate thing for normal ACPI CPU runstate support that people have used > to manage a *running* CPU (and shutting it down). This was a mistake and fixes have already been posted: http://marc.info/?l=linux-acpi&m=119052970904643&w=4 http://marc.info/?l=linux-acpi&m=119073173625910&w=4 Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/