Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230405110455.1368428-1-kherbst@redhat.com>
In-Reply-To: <20230405110455.1368428-1-kherbst@redhat.com>
From:   Ben Skeggs <skeggsb@gmail.com>
Date:   Tue, 11 Apr 2023 08:05:56 +1000
Message-ID: <CACAvsv6ODb++b3nZMJcv2__rUC7M0K1BDiZqoh9tLhNqtSxKzQ@mail.gmail.com>
Subject: Re: [PATCH] drm/nouveau/fb: add missing sysmen flush callbacks
To:     Karol Herbst <kherbst@redhat.com>
Cc:     linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
        Ben Skeggs <bskeggs@redhat.com>,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 5 Apr 2023 at 21:05, Karol Herbst <kherbst@redhat.com> wrote:
>
> Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203
> Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from common code")
> Signed-off-by: Karol Herbst <kherbst@redhat.com>
Oops, that must've gotten lost in a rebase somehow.

Reviewed-by: Ben Skeggs <bskeggs@redhat.com>

> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 +
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 +
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 +
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 +
>  4 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
> index 76678dd60f93f..c4c6f67af7ccc 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
> @@ -31,6 +31,7 @@ gf108_fb = {
>         .init = gf100_fb_init,
>         .init_page = gf100_fb_init_page,
>         .intr = gf100_fb_intr,
> +       .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
>         .ram_new = gf108_ram_new,
>         .default_bigpage = 17,
>  };
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
> index f73442ccb424b..433fa966ba231 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
> @@ -77,6 +77,7 @@ gk104_fb = {
>         .init = gf100_fb_init,
>         .init_page = gf100_fb_init_page,
>         .intr = gf100_fb_intr,
> +       .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
>         .ram_new = gk104_ram_new,
>         .default_bigpage = 17,
>         .clkgate_pack = gk104_fb_clkgate_pack,
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
> index 45d6cdffafeed..4dc283dedf8b5 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
> @@ -59,6 +59,7 @@ gk110_fb = {
>         .init = gf100_fb_init,
>         .init_page = gf100_fb_init_page,
>         .intr = gf100_fb_intr,
> +       .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
>         .ram_new = gk104_ram_new,
>         .default_bigpage = 17,
>         .clkgate_pack = gk110_fb_clkgate_pack,
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
> index de52462a92bf0..90bfff616d35b 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
> @@ -31,6 +31,7 @@ gm107_fb = {
>         .init = gf100_fb_init,
>         .init_page = gf100_fb_init_page,
>         .intr = gf100_fb_intr,
> +       .sysmem.flush_page_init = gf100_fb_sysmem_flush_page_init,
>         .ram_new = gm107_ram_new,
>         .default_bigpage = 17,
>  };
> --
> 2.39.2
>