Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bbd3ad38-6a2d-e81f-0d72-7181674fafb5@nxp.com>
Date:   Tue, 11 Apr 2023 02:28:34 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: Fix kernel test robot sparse
 warning
To:     Mathieu Poirier <mathieu.poirier@linaro.org>, andersson@kernel.org
Cc:     linux-remoteproc@vger.kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230407161429.3973177-1-mathieu.poirier@linaro.org>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <20230407161429.3973177-1-mathieu.poirier@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enVXMjZ5QmZmV2VIMXdLbjJUL3dueE9HbUY5Rk01K1RYLzVQZmxXMWF4Uk00?=
 =?utf-8?B?YllRaFdGS3VYcTM5aXJiTHJCc09pRXllSkxBTmVyWDVHSHJha1R3OVlFSEVy?=
 =?utf-8?B?YkpXQlgvRGdMQk95ODdXRi85Qm5kaGhkalpaWVVmMHQ2akI5QkZJcEw2bWNN?=
 =?utf-8?B?dHlPbjFPdkRvaFRkZHVEdlBuOSt3OUpDNmM1MWQwMVA2bE5RNXpkd1JpRCtU?=
 =?utf-8?B?WGFvUncwTDJQSWErMlRlRTh0VHBDZnh3WDFPa0g3dzFDNDRzTHE4MkhBcUkw?=
 =?utf-8?B?eHNwbHNvU0dKQUQ1QVlqcUM3TGkyc3hyM0V0QjVqZXRWeTl4eXA0K1hRM3F3?=
 =?utf-8?B?eVJaWlJScnkreFB0UTkyWWZWK1NxZUFZK043Q1J0OU9oQzR3UE10RUZQdC92?=
 =?utf-8?B?RDQvQnVxMDQ2dkhVZ2g1ZEhTMUxXakZxY1VjaHBuSUE3N3QydXFIa21RcUly?=
 =?utf-8?B?U3NQY2x6RFdRMVJSZjF4MVpvbjZsMmdMUTZjVFo5L2ZCaThyVWZXb1VtUGxR?=
 =?utf-8?B?dHMzY2NQSGliZUU0QThabDAvZm1RbG93Mk9zRVRqcVhzeTJWWUJ4eWZJSUtN?=
 =?utf-8?B?Y0hoNFlpZVJuWnVwcitLSkwrVVdLdnlzd1RjQXdtNVBFRXpVL1V6TEIyeW43?=
 =?utf-8?B?RGhheDBWMGxVUWVEMG01cm1MWTlkSmJUamNJNVB1T3R0OHRoSDZCaTI3TGVH?=
 =?utf-8?B?VTZla0o1THR3S2ZhdUVCSXJmaDlHdGdqOHVuVnkzNmpJQlJQRGQvQ1piZ2ZY?=
 =?utf-8?B?TzhqbWtySUowTHBuUFJvQkNHRjR5OU9mUjlWWUVoMk9FZXk3K0FKWEdINTdo?=
 =?utf-8?B?NWZnNXVoNFRUS2pxcjhQdHV5bldlOVFUSGtYclY5ZWJ1T29FUGR3WG16Rzdp?=
 =?utf-8?B?eWY5cVV6N3RUcWVEeExtbnpxbFRxUU1TdkY3QUNHTU51WWdLV0lqNS9jQ1hW?=
 =?utf-8?B?VHVBdmpPM2tnZGE4dWRRcFN1dHgxbVF2R0lDbm9KRnAyZ2JvbXpGaFI2UGVT?=
 =?utf-8?B?VkVNZGhEdzBzRkg4TjN2ajV3WWhxcnVDUW9HU2xvRzMzc05CQXFEWjRFZ0Zp?=
 =?utf-8?B?ZE9vaWZiUHVhQ3ZCblpTNUtJWGtXZzM0WHlsTncxYlR2M0tqRkpEM21DOE1C?=
 =?utf-8?B?Qkk5WGxEWW1tUEI2eVUwdExEVjI0L3VEWElkRE0rNlJSM0NBREhOWXZGRjJm?=
 =?utf-8?B?UnM1TXplbnd4UWdzMjZ0YzJjZGxxWGc3VjhoV3A2dVVLV2tWNWJDK2ZzTnRE?=
 =?utf-8?B?UDJrcUpPb01kbzc1SXBqWlJUUjI3V2t0TDhCZXlGVDhlS3FYc3VSYXg3MWZB?=
 =?utf-8?B?MFAyMTJobGtZOHovL1VXblg5RjdJMkl2ek5qT1B0MkJIV0UwcUs2Ky9JSkJC?=
 =?utf-8?B?dnBheDlNWE83TE9MRU1TRmFFa0h2aWV6V1hRdTg2VWhxR2EyVHBlWlVWdUxI?=
 =?utf-8?B?NWNKZ2lCcjBrTXNSeU1aYUJOQUhSZWU2bUNxeU9YT3BsNjludFQrejByTHVZ?=
 =?utf-8?B?ZU1rZHZKNTNZWTBVbHNka2orWTFybXg0U0owUGZlOHlyU0dyb3VYQU9uekQy?=
 =?utf-8?B?SXA4ZEpqQjNtZFFKVzNzR0UzSWZna2szRUpadWxHYzBXTDFhY043dEFzL2Vs?=
 =?utf-8?B?ejljM1FLOEF6c1lhRkd3N2pTVElYa1Z3cHN1ZHZOMlpCQ3l0THZUQ0pRSXUr?=
 =?utf-8?B?VGJjc29MdVJyNytDZ3czeXlXOGk3c2lCMWUreG11REtGdHpKVmFEWkI5dTlW?=
 =?utf-8?B?UHNlNE5BcUhjM3lkNm8rVjZWa2lLdlFHYmRkMjd0U3p6S2dHU2NKaWVzd3FJ?=
 =?utf-8?B?amJ3ZzRJRVJ6TG1oNmdtMzFYYUZpN2N6VHB0YmZqQjNFTDh0Zmc4ZWhKTmFx?=
 =?utf-8?B?UDg2TjRwWFBlcWxkckpBM0JMdklrZHFabzErWkQ0VzhSOEtieEdkOHloRU16?=
 =?utf-8?B?cXFQZ1o2bklNNXAxOG81WVVyVklMNW5LMGkwbi9XVENycVBZeHRkWFpqWDZq?=
 =?utf-8?B?MTA4VmI1TUxWeGxrdlhwaGFIQ1c2dDRndGlqVWtEdXRhM3Z6M2ttK0kzMksz?=
 =?utf-8?B?MmRzNWExTTdsVXJZNTF0RXYvWXNxYXNFS2J0MFFKU2xFVVR3V2NaZnBoaU02?=
 =?utf-8?B?SzR6dG4rMzhycE95bTJ1VXNDL3pkb2xEWjhFUlNPUlZZUzB2Vm1OMENWWVFT?=
 =?utf-8?B?clE9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 004f8169-ee96-4edb-024c-08db3a1b662b
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2023 23:29:15.7565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0x9gVMZlA1kd7OuHsNDGR9HVxLuRD8tN30GrPwXA8SwU24qW0MAp1skUE7MQT0txL7w90wzt+N2i1AhivRX/fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9808
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/7/2023 7:14 PM, Mathieu Poirier wrote:
> This patch fixes the kernel test robot warning reported here:
>
> https://lore.kernel.org/bpf/642f916b.pPIKZ%2Fl%2F%2Fbw8tvIH%25lkp@intel.com/T/
>
> Fixes: 408ec1ff0caa ("remoteproc: imx_dsp_rproc: Add custom memory copy implementation for i.MX DSP Cores")
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia


> ---
>
> Iuliana - please thest this on your side
>
> ---
>   drivers/remoteproc/imx_dsp_rproc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index 21759d9e5b7b..c805cb83cacc 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -750,12 +750,12 @@ static void imx_dsp_rproc_kick(struct rproc *rproc, int vqid)
>    * The IRAM is part of the HiFi DSP.
>    * According to hw specs only 32-bits writes are allowed.
>    */
> -static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
> +static int imx_dsp_rproc_memcpy(void *dst, const void *src, size_t size)
>   {
> +	void __iomem *dest = (void __iomem *)dst;
>   	const u8 *src_byte = src;
>   	const u32 *source = src;
>   	u32 affected_mask;
> -	u32 *dst = dest;
>   	int i, q, r;
>   	u32 tmp;
>   
> @@ -768,7 +768,7 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
>   
>   	/* copy data in units of 32 bits at a time */
>   	for (i = 0; i < q; i++)
> -		writel(source[i], &dst[i]);
> +		writel(source[i], dest + i * 4);
>   
>   	if (r) {
>   		affected_mask = GENMASK(8 * r, 0);
> @@ -799,8 +799,8 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
>    */
>   static int imx_dsp_rproc_memset(void *addr, u8 value, size_t size)
>   {
> +	void __iomem *tmp_dst = (void __iomem *)addr;
>   	u32 tmp_val = value;
> -	u32 *tmp_dst = addr;
>   	u32 affected_mask;
>   	int q, r;
>   	u32 tmp;