Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 17:07:12 -0700
From:   Alison Schofield <alison.schofield@intel.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Fix logical operator continuations
Message-ID: <ZDSksGyxnu5eIo+1@aschofie-mobl2>
References: <20230408171803.GA262580@sumitra.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230408171803.GA262580@sumitra.com>
Precedence: bulk

On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> Fix logical operator continuation as suggested by Linux kernel
> coding-style. Check reported by checkpatch:
> 
> CHECK: Logical continuations should be on the previous line
> 
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>

Hi Sumitra,

That commit message can be explicit, like "Move logical operator
to previous line"

Alison


> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> index 5a1cd22f5e25..58ed394202ae 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
>  					&priv->rtllib->pwr_save_ctrl;
>  
>  	if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> -	    (priv->rtllib->state == RTLLIB_LINKED))
> -	    || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> +	    (priv->rtllib->state == RTLLIB_LINKED)) ||
> +	    (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
>  	    (priv->rtllib->iw_mode == IW_MODE_MASTER))
>  		return;
>  
> -- 
> 2.25.1
>