Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Angus Chen <angus.chen@jaguarmicro.com>
To:     mst@redhat.com, jasowang@redhat.com
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org,
        Angus Chen <angus.chen@jaguarmicro.com>
Subject: [PATCH] virtio_pci: Wait for legacy device to be reset
Date:   Tue, 11 Apr 2023 09:38:32 +0800
Message-Id: <20230411013833.1305-1-angus.chen@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qhKWz4OeM8+JoY1ipoJx7Kc+Ocyet7DAh4fOqYwm4K52DbQpfmrHYajMLRXB?=
 =?us-ascii?Q?ZgHMahuy0LWkAW04Eoq4YIG082flpQ/R0jQemPnFIhAP079Mxs7KUJneo5X4?=
 =?us-ascii?Q?naJ5+rjJI5FYNyc70apPs6fv0HytXjt0rMqNnBgcorfdd6JaMvVhNULLV6Ac?=
 =?us-ascii?Q?H9ilKtU7xVycjCtRWxWJh1eRs3sL6edvjYmxqEo8CcNqKEmJwuoFy6m1u7Zl?=
 =?us-ascii?Q?1ZExOCfY1e1y4qtt3QcNUsNTYbzkwQUJp+gldd2Rd9FDyLslbPsWCqx++CkI?=
 =?us-ascii?Q?Z6y3P0LoAYjioNEL0KEYyeKSyZltiJpj+8YD53TIv2IO1Bu6vb8y406WMiLa?=
 =?us-ascii?Q?e3qqcnYcXm+ygg+KxS63R5n+nMvtkIVCOup0KL6ROO9OrCPYscd2lwzal+wF?=
 =?us-ascii?Q?wj5c2aao+4NghlwSTu1UnjUyfAvXoT025r59xBJ9yvr23GsQ0QwtkBrqD1HA?=
 =?us-ascii?Q?gXOiYZRGt8AEgg+sFIFc6YI+HWa9OEdnEG/5MwrOq9IS0skwxnoR29vJ8uhn?=
 =?us-ascii?Q?RGdhkpiwB1H3HxkuuCnFrGQD089oYPiQg9Ka8YIGXLjH1LlkJe6DROsDV7cF?=
 =?us-ascii?Q?j+s3HoCIxTg4q7lXucfhYuDUq5WQhbZUA4W/5rsL7BH/ovM60uFJUK2eEIie?=
 =?us-ascii?Q?qVMBWLO+242lf1EcfQym1T1i09pBCmodLpU37RH4lcYAXXW5g6slhDLYaNU7?=
 =?us-ascii?Q?Lm1WVN+BbKLl2sTR+aQvkqB/y2VvtVm9BQuBgAj6t4ns7LBfN6fWzYccZ3oL?=
 =?us-ascii?Q?c62sSM0AIpltq7r9zfBLbMo/fHc6OLwScAY0Aj0tqb+5Cq/zLnMI1JX374vB?=
 =?us-ascii?Q?dGZjQEVu6+gV3WsF3+FrsSoscz60gGsDFfgmWQJgog/XD+/qGObwv89AIne0?=
 =?us-ascii?Q?OFUe9HEt8u3dnQuoxfvs4uMTLGgoSshXRu0CTJrgeaRdf752Qmwwcw4roCUY?=
 =?us-ascii?Q?PbHo1JGeDWWW8q53w03G6gOYP7QQdQ1pQ4gAtqE4ncmxeZv9wdpWED2rfRfl?=
 =?us-ascii?Q?nUGPKmT+8FkTuT5miTubYTusI5Gf7UWtrF+0GiUEhUmn82bcqBDnwfD52pqM?=
 =?us-ascii?Q?KY5xZ1RJWBcTtYCU1fyYjGvAxvMjW7BUowr87DzMBRUdvSYaMceL5InYj2xX?=
 =?us-ascii?Q?r33tV3pk+gEA4X5dcuWv3MqLrjqjMefmuAO2XnLYnaYDwD7MpyZbtJgB0jPi?=
 =?us-ascii?Q?ZssyPT+E3/OymViVsPRLxrwrM+B1aYZwTTGcMDAibtY9p6C3Lfst9Zekvgyv?=
 =?us-ascii?Q?n5SKl6olgwwnCfhrahUvaNdPAw9PkXIYLSJ983vGimDX6rIfzcH+cY2/Wo/Q?=
 =?us-ascii?Q?wFdGJRyt/LFW3e8tMNTPJSbINQcqy2bZS5QSHdWyFUougImJwLfC/D2N1WTx?=
 =?us-ascii?Q?OMiILYUD6LUdtdVY4qT83VFH6Mk3OOcuVCJDi6IEXO/zvb5pIjtjvwtEnZct?=
 =?us-ascii?Q?7FkYVD5C3mBp6LCgGzzjCD/TOEAYS5FSR/Oh5feLQp+1ACneyEdFAm4E3Brj?=
 =?us-ascii?Q?r01T3ZOp6TIOC+zemBBeCd3JbNjahe7Pkq9v3LVksYUrVnwNRwtEmq9ktP1q?=
 =?us-ascii?Q?OcC1RmItnn9alwLyEQX/lmU279scU28HaGzomnPiKuX2EalwTOY/nVSRcHqQ?=
 =?us-ascii?Q?wg=3D=3D?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77c2d42f-4b64-4f78-233c-08db3a2d83b8
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3424.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 01:38:56.3224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WSoBkD1KHci9CaKZkA/n1z9TKSkiMbFFlCCjZ4LIMCsuyt/kVu4M74kyZ71FE4exPKwRlcrAWE8r96o9poq/ZrzNPj9prW2q54POJ4ZsQOQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5607
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We read the status of device after reset,
It is not guaranteed that the device be reseted successfully.
We can use a while loop to make sure that,like the modern device did.
The spec is not request it ,but it work.

Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
 drivers/virtio/virtio_pci_legacy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
index 2257f1b3d8ae..f2d241563e4f 100644
--- a/drivers/virtio/virtio_pci_legacy.c
+++ b/drivers/virtio/virtio_pci_legacy.c
@@ -14,6 +14,7 @@
  *  Michael S. Tsirkin <mst@redhat.com>
  */
 
+#include <linux/delay.h>
 #include "linux/virtio_pci_legacy.h"
 #include "virtio_pci_common.h"
 
@@ -97,7 +98,8 @@ static void vp_reset(struct virtio_device *vdev)
 	vp_legacy_set_status(&vp_dev->ldev, 0);
 	/* Flush out the status write, and flush in device writes,
 	 * including MSi-X interrupts, if any. */
-	vp_legacy_get_status(&vp_dev->ldev);
+	while (vp_legacy_get_status(&vp_dev->ldev))
+		msleep(1);
 	/* Flush pending VQ/configuration callbacks. */
 	vp_synchronize_vectors(vdev);
 }
-- 
2.25.1