Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4865409rwl; Mon, 10 Apr 2023 18:54:06 -0700 (PDT) X-Google-Smtp-Source: AKy350a0Ntn+abu07LQvhv2lII0MzYC766AOf2oNPiUYv3ubSmQNeI+G79eUWALzWxUUNp8ttdo2 X-Received: by 2002:a50:ef13:0:b0:504:9b06:fec7 with SMTP id m19-20020a50ef13000000b005049b06fec7mr728073eds.37.1681178046317; Mon, 10 Apr 2023 18:54:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681178046; cv=none; d=google.com; s=arc-20160816; b=KImsLUj509QdTB27mzEU84ffTivZqul1VMWykC0ONtWK9Xzn9V0kwzDxhYVxRD+c1b oDTWMOueH78yBE20BgWPRnT03Zv2PPvwX8SGfjZjEvZT977ytiYn+iPcluBhQ87JPuf+ 96+SBCIgsUyFCDwECqcH1qeKdjB+P1BuOBdiRfNrsXoRMdORZq15w/dRHa6RCMqcpCiD M3OUWvOsKCtnlzzuheY6v5Z9IaXIl8OaPlhDrHTXIbon8k2SIAyipjORf9CgTsBpfwim 5bOadDMlRP9W9ltVpIlRNxXPd4kjlIWDCKkZ1moLIy+796RGW2NjC4rrJA2uHXaX2S5A Fn0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=obRgOLwa24A34Xw+WVQ19IPmX3EOzcjF/yQQr8z4UxI=; b=k7OtDe2IedwMBhfk+FKlTHIqBiboU+01Iqg5DNXE84d8CmudapSbAt/bhIAigHouTX wuo3qGQRjmWiaXUhMYwNRQT6sz6zPGtkbUc1Z8NwMF8XkA4a5FLeUnD0Fl6LpFsthWdK wlb8x/CdExX0SVYdtNxamqIpg5JW+QldojgIj3POsqGiUB50nP1VxuTnAGmz1+n5SWqA d5MFXWBtkxd6jl2EtAGkSfpVfF6btaGJIP+WrtwNtvorO8mWlFu3xKi50b7Bcc0lOpMZ V9JW+wLOnQYHbub/WfGLZK63ZhQnz745DjFFOaU0M09teLT3X8PwFFTb+P0KDPVqp9z/ NBvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FKStRVCj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho20-20020a1709070e9400b0094a5a281168si2977210ejc.801.2023.04.10.18.53.41; Mon, 10 Apr 2023 18:54:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FKStRVCj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbjDKBif (ORCPT + 99 others); Mon, 10 Apr 2023 21:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbjDKBid (ORCPT ); Mon, 10 Apr 2023 21:38:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32BC1E74; Mon, 10 Apr 2023 18:38:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C602761456; Tue, 11 Apr 2023 01:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30887C433AA; Tue, 11 Apr 2023 01:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681177112; bh=obRgOLwa24A34Xw+WVQ19IPmX3EOzcjF/yQQr8z4UxI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FKStRVCjUmppxwt5KJw0FZfvdJ/8tuaWaSbaVLEVv2cE6MpmWCsmO8+7sCx+XZ4IF 9+NJMoao6weabC/ZmfeOYfLEjT0e85GudexqiTnEC/5/diwWjipbaJki7WumRcNBUu VuNsRnT50tdB9rjByw17MxtMI7iW1AEfUj2svXy1UCmXaP/3KKqY3/9N0n0awuuwcY 3VLYUKNYeBziDU7+m7WPC39YS6jJ2lDXke/HbwkqvB1RvxKOxSo+1mVZwttk6j0Wil 2XWBrz8udkLTFSknPAxszivKNGhBrIz3tOARFevJTofK1iDyGNNO4NA8stv74SKi7l xdBzLt4l3EJdQ== Received: by mail-ej1-f45.google.com with SMTP id jg21so16229526ejc.2; Mon, 10 Apr 2023 18:38:32 -0700 (PDT) X-Gm-Message-State: AAQBX9dgDeVYErhVusvfA6CeJWmrEF+lycJVduPypZv6vOywb3aREk8S EFIKC6rcvY5yoHRrAL93ApH5ykcS6g3iRuZZrRY= X-Received: by 2002:a17:906:c78a:b0:947:eafc:a738 with SMTP id cw10-20020a170906c78a00b00947eafca738mr802756ejb.60.1681177110240; Mon, 10 Apr 2023 18:38:30 -0700 (PDT) MIME-Version: 1.0 References: <20230406220206.3067006-1-chenjiahao16@huawei.com> <20230406220206.3067006-2-chenjiahao16@huawei.com> In-Reply-To: From: Guo Ren Date: Tue, 11 Apr 2023 09:38:18 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next v3 1/2] riscv: kdump: Implement crashkernel=X,[high,low] To: Simon Horman Cc: Chen Jiahao , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kexec@lists.infradead.org, linux-doc@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, heiko@sntech.de, bjorn@rivosinc.com, alex@ghiti.fr, akpm@linux-foundation.org, atishp@rivosinc.com, bhe@redhat.com, thunder.leizhen@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 7, 2023 at 8:03=E2=80=AFPM Simon Horman wrot= e: > > On Fri, Apr 07, 2023 at 05:06:24PM +0800, Guo Ren wrote: > > On Thu, Apr 6, 2023 at 10:06=E2=80=AFPM Chen Jiahao wrote: > > > > > > On riscv, the current crash kernel allocation logic is trying to > > > allocate within 32bit addressible memory region by default, if > > > failed, try to allocate without 4G restriction. > > > > > > In need of saving DMA zone memory while allocating a relatively large > > > crash kernel region, allocating the reserved memory top down in > > > high memory, without overlapping the DMA zone, is a mature solution. > > > Here introduce the parameter option crashkernel=3DX,[high,low]. > > > > > > One can reserve the crash kernel from high memory above DMA zone rang= e > > > by explicitly passing "crashkernel=3DX,high"; or reserve a memory ran= ge > > > below 4G with "crashkernel=3DX,low". > > Asked-by: Guo Ren > > Perhaps 'Acked-by' :) Sorry, my typo. Acked-by: Guo Ren --=20 Best Regards Guo Ren