Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66c0e8b6-64d1-5be6-cd4d-9700d84e1b84@huawei.com>
Date:   Tue, 11 Apr 2023 12:14:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] fs: fix sysctls.c built
Content-Language: en-US
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <linux-fsdevel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>
References: <20230331084502.155284-1-wangkefeng.wang@huawei.com>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20230331084502.155284-1-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

/proc/sys/fs/overflowuid and overflowgid  will be lost without
building this file, kindly ping, any comments, thanks.


On 2023/3/31 16:45, Kefeng Wang wrote:
> 'obj-$(CONFIG_SYSCTL) += sysctls.o' must be moved after "obj-y :=",
> or it won't be built as it is overwrited.
> 
> Fixes: ab171b952c6e ("fs: move namespace sysctls and declare fs base directory")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>   fs/Makefile | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/Makefile b/fs/Makefile
> index 05f89b5c962f..8d4736fcc766 100644
> --- a/fs/Makefile
> +++ b/fs/Makefile
> @@ -6,7 +6,6 @@
>   # Rewritten to use lists instead of if-statements.
>   #
>   
> -obj-$(CONFIG_SYSCTL)		+= sysctls.o
>   
>   obj-y :=	open.o read_write.o file_table.o super.o \
>   		char_dev.o stat.o exec.o pipe.o namei.o fcntl.o \
> @@ -50,7 +49,7 @@ obj-$(CONFIG_FS_MBCACHE)	+= mbcache.o
>   obj-$(CONFIG_FS_POSIX_ACL)	+= posix_acl.o
>   obj-$(CONFIG_NFS_COMMON)	+= nfs_common/
>   obj-$(CONFIG_COREDUMP)		+= coredump.o
> -obj-$(CONFIG_SYSCTL)		+= drop_caches.o
> +obj-$(CONFIG_SYSCTL)		+= drop_caches.o sysctls.o
>   
>   obj-$(CONFIG_FHANDLE)		+= fhandle.o
>   obj-y				+= iomap/