Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5048027rwl; Mon, 10 Apr 2023 22:57:53 -0700 (PDT) X-Google-Smtp-Source: AKy350bJiuk0iwEwkyfjuzcUYxRdnTMsszZ8xGc/wvwuFo5/O2Z2Uo11rFjQuInMamSWIYJYlW7Y X-Received: by 2002:a50:ed17:0:b0:504:8173:ec8c with SMTP id j23-20020a50ed17000000b005048173ec8cmr12386798eds.13.1681192673216; Mon, 10 Apr 2023 22:57:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681192673; cv=none; d=google.com; s=arc-20160816; b=D3qhJGgMW/D3OVQWxlj0Q1jprsIQA+Bg3DE4mFTubCufK6qxNxhDMRqkCxin08DiGY UJ54k0gzTiSFE+T3prCFzFYlJAXx5nNlLAdfUE6dW0MJyJVVLxjMWlUQLSrq1x3aq1tf e1S5qAN/iDpStaL72V+F9zKSl6NgGdP3pK8ZPG1s42R72Itfq3TbFBs+AxvlZdTw6NfN yhTO+/cpBeHgcBxnyiB9HnqIwt/URBgdes3eyMFbnUPN5cwJeoOM9Q9oyNoDdjg2UsVb /KI1rUo8rXSUVlSG2QVjrE3ZzNNLf9qo2QED57sxSAdveFve0PObUC2pyNgiKykh6nW4 G2jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=HuWGcELmkJJ9H6v4hiFoJ9aS9O/S4iDSa8U1Z3FSqWk=; b=Vwoz8LWGXZzT2zLfrvm2dOJ9nTbgSH4P9KSuRjWVcrxULFz762GrOaMJku+2KFIpbn UY8nVrCpvWBwHbbZ4//KyX5Ka2YYcDsj3gwtXPs1+xn+s0BxzCvXqXQ4FiJFwvYOLidg tASazKumvKvjrnHrxQ+uF5+c5Q04kft6nM2PIgq66nMjMOTDF4vWHCl34Gv93S2FUvmT gNx3GhuGsg3erhKBmYMV2q2xg49WblCXn+PUzjwaY7f3N/kEVLZq+mc+/XLF65gUj7XC hFOk9W4izAd+5h6RF/dbzyfbjEVASURZ7hsz7qP7swashcVpIMPMZWWsmqC9vE3ae/4y Vprw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mSBugSjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a056402051000b0050470a9fe37si11415454edv.77.2023.04.10.22.57.28; Mon, 10 Apr 2023 22:57:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mSBugSjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbjDKF4s (ORCPT + 99 others); Tue, 11 Apr 2023 01:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjDKF4f (ORCPT ); Tue, 11 Apr 2023 01:56:35 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D3F40D7 for ; Mon, 10 Apr 2023 22:56:07 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id jg21so17146682ejc.2 for ; Mon, 10 Apr 2023 22:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681192563; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HuWGcELmkJJ9H6v4hiFoJ9aS9O/S4iDSa8U1Z3FSqWk=; b=mSBugSjYIIU21dzWXZVxrW7D5jwgfpQCx7VIz5BrooQi2P6sqO33aSgyyqhHyspvYx uNz+BHtb2n7F0ISccM8VIRfpFJV9nI8U6lVEOyudI6Bw5v+vNkTl6jF0WLppsNKGafc3 oZ76qFL+jbddmA7QSzXaK/J1mxlmB/9U5805LBHBiroGvCV9jRoyvAP3B9kdUT3Al5Ki bkx2NuRGJjIXbs2t5bJk7VF/PhRbvyD2PzY4f5icKR9JowCHd2wzFqByduQ03WoQte/+ C0W1M49zvmu9vYWb76390e7QblxKW6Fk5LfA1jBcC9x1nTlMT3FoM2B7KKI3kMcKkHGF WFnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681192563; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HuWGcELmkJJ9H6v4hiFoJ9aS9O/S4iDSa8U1Z3FSqWk=; b=SfBylanzxCk0UsgVWCdSxHgwP+tY7UGlsNB/ihMRW2123BwzFOldK4H5TwV3HC2LGi MB89wnIP4WxhlfCNMixKX7shs7hQ/rBWw2wUG1tqgn88O8w+htAWZ8HoqLgI7jSTHYns 2TPq4uB6krDGrrIF92Q2Jat+pXIzaTHwmTAkgefMA5a3N33ynDTVe5d0sSO00TH2nioG UKFyC73ZL4/P3rfA0cORgnJuBH+QDtUjuc0vyeGedgR5ab+DtoDvJ80qcvECPvrDXe6k TqDHDLdF7Wki5u7dbkvkF060k3zOikZi+Ms8P1/sZ+h+WmaFCXisFuDPnSeL1WUmwYqy B+Bw== X-Gm-Message-State: AAQBX9eO2zTnm1Coh6GGNUm9DrafAuevWKr3Rp/6I2v0CSp+oFMbPtGa nzCEUO0njezWF8HynWs+UzGOOA== X-Received: by 2002:a17:906:c206:b0:948:112e:c49a with SMTP id d6-20020a170906c20600b00948112ec49amr10760963ejz.24.1681192563301; Mon, 10 Apr 2023 22:56:03 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:dad2:72b7:3626:af61? ([2a02:810d:15c0:828:dad2:72b7:3626:af61]) by smtp.gmail.com with ESMTPSA id sa30-20020a1709076d1e00b0094c784f64fbsm967957ejc.66.2023.04.10.22.56.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 22:56:02 -0700 (PDT) Message-ID: <87ef069e-eaaf-9ba3-50a1-9d401494e20a@linaro.org> Date: Tue, 11 Apr 2023 07:56:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 3/5] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Content-Language: en-US To: Joel Selvaraj , Caleb Connolly , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Henrik Rydberg , Arnd Bergmann , Robert Jarzmik , Jeff LaBundy , Markuss Broks , Jean Delvare , Job Noorman , Alistair Francis , Chris Morgan , Hans de Goede Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20230410160200.57261-1-joelselvaraj.oss@gmail.com> <20230410160200.57261-4-joelselvaraj.oss@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230410160200.57261-4-joelselvaraj.oss@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2023 18:01, Joel Selvaraj wrote: > Enable qupv3_id_1 and gpi_dma1 as they are required for configuring > touchscreen. Also add pinctrl configurations needed for touchscreen. > These are common for both the tianma and ebbg touchscreen variant. > In the subsequent patch, we will initially enable support for the focaltech > touchscreen used in the EBBG variant. This is done in preparation for that. > > Signed-off-by: Joel Selvaraj > --- > .../qcom/sdm845-xiaomi-beryllium-common.dtsi | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > index 5ed975cc6ecb..b580a32fdc3b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > @@ -268,6 +268,10 @@ &gmu { > status = "okay"; > }; > > +&gpi_dma1 { > + status = "okay"; > +}; > + > &gpu { > status = "okay"; > > @@ -376,6 +380,10 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&qupv3_id_1 { > + status = "okay"; > +}; > + > &sdhc_2 { > status = "okay"; > > @@ -481,6 +489,37 @@ sdc2_card_det_n: sd-card-det-n-state { > function = "gpio"; > bias-pull-up; > }; > + > + ts_int_default: ts-int-default-state { > + pins = "gpio31"; > + function = "gpio"; > + drive-strength = <16>; > + bias-pull-down; > + input-enable; input-enable is not valid. > + }; > + > + ts_reset_default: ts-reset-default-state { > + pins = "gpio32"; > + function = "gpio"; > + drive-strength = <16>; > + output-high; > + }; > + > + ts_int_sleep: ts-int-sleep-state { > + pins = "gpio31"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + input-enable; input-enable is not valid. Best regards, Krzysztof