Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 10:58:03 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH v2] fsverity: use WARN_ON_ONCE instead of WARN_ON
Message-ID: <20230411-duktus-leitsatz-33c2dc2c7bde@brauner>
References: <20230406181542.38894-1-ebiggers@kernel.org>
 <20230406182525.GA1190@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230406182525.GA1190@sol.localdomain>
Precedence: bulk

On Thu, Apr 06, 2023 at 11:25:25AM -0700, Eric Biggers wrote:
> On Thu, Apr 06, 2023 at 11:15:42AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> > 
> > As per Linus's suggestion
> > (https://lore.kernel.org/r/CAHk-=whefxRGyNGzCzG6BVeM=5vnvgb-XhSeFJVxJyAxAF8XRA@mail.gmail.com),
> > use WARN_ON_ONCE instead of WARN_ON.  This barely adds any extra
> > overhead, and it makes it so that if any of these ever becomes reachable
> > (they shouldn't, but that's the point), the logs can't be flooded.
> > 
> > Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >  fs/verity/enable.c       | 4 ++--
> >  fs/verity/hash_algs.c    | 4 ++--
> >  fs/verity/open.c         | 2 +-
> >  include/linux/fsverity.h | 6 +++---
> >  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> Sorry, forgot changelog:
> 
> v2: also convert the three WARN_ON in include/linux/fsverity.h

Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>