Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 12:09:32 +0200
From:   Daniel Wagner <dwagner@suse.de>
To:     linux-nvme@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
        James Smart <james.smart@broadcom.com>,
        Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH] rvmet-fcloop: Remove remote port from list when unlinking
Message-ID: <r5hxrqiiqfsj27f3jlb2avq6wulg3ksnuf5zg6xrgkdprgrpxy@ssusv6tvghqy>
References: <20230411092209.12719-1-dwagner@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230411092209.12719-1-dwagner@suse.de>
Precedence: bulk

On Tue, Apr 11, 2023 at 11:22:09AM +0200, Daniel Wagner wrote:
> The remote port is never removed from fcloop_nports list. During module
> unloading it's possible to end up an busy loop in fcloop_exit, because
> the remote port is found in the list and thus we will never progress.
> 
> The kernel log will be spammed with
> 
>   nvme_fcloop: fcloop_exit: Failed deleting remote port
>   nvme_fcloop: fcloop_exit: Failed deleting target port
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---

Found a bunch more problems which need to be addressed. I'll collect all
changes and send them as series.