Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b42f7c48-84b1-1e50-bcad-1bf5edf1a168@linaro.org>
Date:   Tue, 11 Apr 2023 13:05:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous
 "input-enable"
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230410181005.25853-1-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230410181005.25853-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers.  Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts    | 2 --
>  arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 1 -
>  arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts        | 3 ---
>  3 files changed, 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> index 7a80e1c9f126..aa0e0e8d2a97 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> @@ -268,7 +268,6 @@ bluetooth_default_state: bluetooth-default-state {
>  		function = "gpio";
>  		drive-strength = <8>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_hostwake_default_state: wlan-hostwake-default-state {
> @@ -276,7 +275,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> index d64096028ab1..5593a3a60d6c 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> @@ -352,7 +352,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> index b82381229adf..b887e5361ec3 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> @@ -307,7 +307,6 @@ bluetooth_default_state: bluetooth-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	touch_pins: touch-state {
> @@ -317,7 +316,6 @@ irq-pins {
>  
>  			drive-strength = <8>;
>  			bias-pull-down;
> -			input-enable;
>  		};
>  
>  		reset-pins {
> @@ -335,7 +333,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
>  		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
> -		input-enable;
>  	};
>  
>  	wlan_regulator_default_state: wlan-regulator-default-state {