Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 07:13:37 -0400
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     Jason Wang <jasowang@redhat.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] virtio_pci: Wait for legacy device to be reset
Message-ID: <20230411071111-mutt-send-email-mst@kernel.org>
References: <CACGkMEscqtaTpCed_f2cfknO4--mXCyp33u1CmZwNEZxyf=ifQ@mail.gmail.com>
 <TY2PR06MB3424BACFA8B6CB463C12E31E859A9@TY2PR06MB3424.apcprd06.prod.outlook.com>
 <20230411024459-mutt-send-email-mst@kernel.org>
 <TY2PR06MB3424E3C222C3B896BB583DFD859A9@TY2PR06MB3424.apcprd06.prod.outlook.com>
 <20230411025335-mutt-send-email-mst@kernel.org>
 <TY2PR06MB3424DB10784CA5504A10099E859A9@TY2PR06MB3424.apcprd06.prod.outlook.com>
 <20230411032014-mutt-send-email-mst@kernel.org>
 <TY2PR06MB3424DE523E669A3B1910D7F0859A9@TY2PR06MB3424.apcprd06.prod.outlook.com>
 <20230411061409-mutt-send-email-mst@kernel.org>
 <TY2PR06MB3424185F07F76D82746B6503859A9@TY2PR06MB3424.apcprd06.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <TY2PR06MB3424185F07F76D82746B6503859A9@TY2PR06MB3424.apcprd06.prod.outlook.com>
Precedence: bulk

On Tue, Apr 11, 2023 at 10:57:51AM +0000, Angus Chen wrote:
> > > > Yes, not very clear still. What are the device and vendor ID of the
> > > > card? Does it have the virtio capabilities?
> > > > Thanks
> > > It's have the virtio capabilities.
> > > When it is used in bare metal ，
> > >    it just use PCI_VENDOR_ID_REDHAT_QUMRANET.
> > > When it use in vm,
> > >  It is just like :
> > > { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET,
> > >              VIRTIO_TRANS_ID_NET,
> > >              PCI_VENDOR_ID_JAGUARMICRO,
> > >              VIRTIO_ID_NET) },
> > >     { PCI_DEVICE_SUB(PCI_VENDOR_ID_REDHAT_QUMRANET,
> > >              VIRTIO_TRANS_ID_BLOCK,
> > >              PCI_VENDOR_ID_JAGUARMICRO,
> > >              VIRTIO_ID_BLOCK) },
> > >
> > 
> > Okay. So it's a transitional device. The question, then,
> > is how come you end up with drivers/virtio/virtio_pci_legacy.c
> > with a modern linux at all?
> > Did you by chance set force_legacy = true ?
> Yes,I can provide more information about it.
> We can test it use force_legacy ,or we use a server with multi os but it use only one card.
> Thanks.

Okay, so I don't yet see lots of value of merging this patch upstream.
The problematic code does not run by default as the modern driver is
used, and applying the patch upstream does nothing to fix the multi-os
case.

What did I miss?


-- 
MST