Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87eef8a06064dc895f183ba2a1cd649c213f3e37.camel@redhat.com>
Subject: Re: [PATCH net-next v2] qlcnic: check pci_reset_function result
From:   Paolo Abeni <pabeni@redhat.com>
To:     Denis Plotnikov <den-plotnikov@yandex-team.ru>,
        netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, anirban.chakraborty@qlogic.com,
        sony.chacko@qlogic.com, GR-Linux-NIC-Dev@marvell.com,
        helgaas@kernel.org, simon.horman@corigine.com, manishc@marvell.com,
        shshaikh@marvell.com
Date:   Tue, 11 Apr 2023 13:24:33 +0200
In-Reply-To: <20230407071849.309516-1-den-plotnikov@yandex-team.ru>
References: <20230407071849.309516-1-den-plotnikov@yandex-team.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-04-07 at 10:18 +0300, Denis Plotnikov wrote:
> Static code analyzer complains to unchecked return value.
> The result of pci_reset_function() is unchecked.
> Despite, the issue is on the FLR supported code path and in that
> case reset can be done with pcie_flr(), the patch uses less invasive
> approach by adding the result check of pci_reset_function().
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Fixes: 7e2cf4feba05 ("qlcnic: change driver hardware interface mechanism"=
)
> Signed-off-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>

Any special reason to target the net-next tree? This looks like a -net
candidate to me?

Thanks!

Paolo