Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 14:40:33 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Xu Yilun <yilun.xu@intel.com>
cc:     Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, linux-fpga@vger.kernel.org,
        Lee Jones <lee@kernel.org>, Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org,
        Russ Weight <russell.h.weight@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] mfd: intel-m10-bmc: Move core symbols to own
 namespace
In-Reply-To: <ZC+3msi6ovoF55tr@yilunxu-OptiPlex-7050>
Message-ID: <a67058bc-8265-add0-3b89-8ee310e871b6@linux.intel.com>
References: <20230405080152.6732-1-ilpo.jarvinen@linux.intel.com> <20230405080152.6732-2-ilpo.jarvinen@linux.intel.com> <ZC+3msi6ovoF55tr@yilunxu-OptiPlex-7050>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1253313675-1681213247=:2109"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1253313675-1681213247=:2109
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT

On Fri, 7 Apr 2023, Xu Yilun wrote:

> On 2023-04-05 at 11:01:49 +0300, Ilpo J?rvinen wrote:
> > Create INTEL_M10_BMC_CORE namespace for symbols exported by
> > intel-m10-bmc-core.
> 
> Is it necessary for handshake register, or just an independent
> improvement?

It's independent improvement.

> > Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> >  drivers/mfd/intel-m10-bmc-core.c | 2 +-
> >  drivers/mfd/intel-m10-bmc-pmci.c | 1 +
> >  drivers/mfd/intel-m10-bmc-spi.c  | 1 +
> >  3 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mfd/intel-m10-bmc-core.c b/drivers/mfd/intel-m10-bmc-core.c
> > index dac9cf7bcb4a..b94412813887 100644
> > --- a/drivers/mfd/intel-m10-bmc-core.c
> > +++ b/drivers/mfd/intel-m10-bmc-core.c
> > @@ -98,7 +98,7 @@ const struct attribute_group *m10bmc_dev_groups[] = {
> >  	&m10bmc_group,
> >  	NULL,
> >  };
> > -EXPORT_SYMBOL_GPL(m10bmc_dev_groups);
> > +EXPORT_SYMBOL_NS_GPL(m10bmc_dev_groups, INTEL_M10_BMC_CORE);
> >  
> >  int m10bmc_dev_init(struct intel_m10bmc *m10bmc, const struct intel_m10bmc_platform_info *info)
> 
> Why this function is not included in namespace?

It was not left out on purpose, I'll add it there.

-- 
 i.

--8323329-1253313675-1681213247=:2109--