Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5376455rwl; Tue, 11 Apr 2023 04:45:17 -0700 (PDT) X-Google-Smtp-Source: AKy350ZXogoHfw+IlkHHcqwt/NldSOWixPthT1HcsR3yJoLWQt1i7lR/IXGWgSG+60IoIS/VvK1L X-Received: by 2002:a05:6402:211:b0:4ad:738b:6706 with SMTP id t17-20020a056402021100b004ad738b6706mr13383926edv.2.1681213517207; Tue, 11 Apr 2023 04:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681213517; cv=none; d=google.com; s=arc-20160816; b=fajfm10XDUhmhN8OQcOMKeThV+CjlZom1MziIdId86x7WMTKg9BriHupvMglzWCx/U qb22jrvS5NliinTLl0WeVbnuFgbX3UCzLDRjTNJUOKw3Gx4mhh/4DnskpRdBHz2KAsfi JYwvdD44KLX2tTbTWtn3O+2jiZv9KgwaE0o3Vfrb//FEMKsL/587d18kHWz/XR9cB4Yf AQYixmzusQJZaNQSP/e2/xpN1AzOg3FuIxIQ5OhYTiduLswo0pujKViV5DPeKFbL7nH0 j05FKgUgW1aO9F/vMUOqhhiDiBxvir01tB1T6ibi63zvxqHDDsPrt1Ph9mBgfhVZUvth y7zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4mgNE43G53JBrqSQsqSgqdIDpvL0YEOV9DYJNxOjmiE=; b=XUMIf6fXfxOYZtsI2CqZU5j59yj3aWvuVkD1ZWDhd3aEwxPGJQMvrlBHFxp+F4Ye0U RMjxtXnAEsh/aMR+HCMOziMk5d5aEIqCZ68FjQAGUSSRO00kguWue3u1PgKUVplJ3ALN kqCMgL8ZOU5ed5DlMgoBPvHY/9sJvbufXP6fKJcCPOkqhhdWcutFyzziZu6cj9mVwhb7 qHN1qKsOttfmVgxJV3MrLxL6aodhUgFutjd5j+M5jwgxdqfHSmcv6FbBe6DAXaVFi6UJ JgZU7u9icXqyvUznTwHKGZy+lriqLXwFeLtgoHXITlxjZVkEovKUgrYh2Pqf923H9YTd 4M8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hYdUuSSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a1709062f0700b0093defbd6295si1895202eji.1052.2023.04.11.04.44.51; Tue, 11 Apr 2023 04:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hYdUuSSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjDKLnK (ORCPT + 99 others); Tue, 11 Apr 2023 07:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjDKLnA (ORCPT ); Tue, 11 Apr 2023 07:43:00 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D0964234 for ; Tue, 11 Apr 2023 04:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213376; x=1712749376; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MmgttL6Z2ite1qRkYYnR8yRMQm4E4KBl2+ANiydF4NE=; b=hYdUuSSYYzJtZwIPbcB6StX6XTvxxB9FKbZOj/5SIkr23EQSJnn+RkrD SKbOddUah1oGGuPYXj1Ej34VbK+eeVlAGOgD4OzmqSqMfMOuLB/UH+nzc KG4kkNVSOTXhsjJKmPQ5NpROpc6A4iiVdGG7Yy8ixRL38qHxqDIXUsTHu 7Rw5XpfgC8OTwg61wpNseqnXFPValzSdDuGwGNH42VJCfY+RkvffE5TLp ZHiqArblvkVv73kNofTCRmGt+qxs7w0ichOA2WdXhshKJ82rx1oz1iWyS ckD0HFqQejjO1LFBu6kxRc+iEhi9bU8yGWh9OFnrj/3U8dFihvVqel+Lm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="341085905" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="341085905" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:42:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="721175700" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="721175700" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2023 04:42:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pmCOZ-00FFDR-2f; Tue, 11 Apr 2023 14:42:43 +0300 Date: Tue, 11 Apr 2023 14:42:43 +0300 From: Andy Shevchenko To: Chanwoo Choi Cc: Chanwoo Choi , linux-kernel@vger.kernel.org, MyungJoo Ham Subject: Re: [PATCH v2 2/5] extcon: Get rid of not really used name field in struct extcon_dev Message-ID: References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> <20230405152745.24959-3-andriy.shevchenko@linux.intel.com> <4632ce69-2a94-0c33-9a76-b97596436e24@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4632ce69-2a94-0c33-9a76-b97596436e24@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2023 at 04:26:35AM +0900, Chanwoo Choi wrote: > On 23. 4. 6. 00:27, Andy Shevchenko wrote: ... > > - if (IS_ERR_OR_NULL(edev->name)) { > > - dev_err(&edev->dev, > > - "extcon device name is null\n"); > > - return -EINVAL; > > - } JFYI: this is a dead code in case you want to clean it up. Since the patch is NAKed, I'm not going to split it. Hence just for your information. -- With Best Regards, Andy Shevchenko