Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9541a779-bca8-4843-23ff-aff47709c5af@redhat.com>
Date:   Tue, 11 Apr 2023 14:02:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next] bnxt_en: Allow to set switchdev mode without
 existing VFs
To:     Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc:     mschmidt@redhat.com, Michael Chan <michael.chan@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230406130455.1155362-1-ivecera@redhat.com>
 <258624e7ffa7bfc3960e727c451cdabe4e7f3efe.camel@redhat.com>
Content-Language: en-US
From:   Ivan Vecera <ivecera@redhat.com>
In-Reply-To: <258624e7ffa7bfc3960e727c451cdabe4e7f3efe.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11. 04. 23 12:22, Paolo Abeni wrote:
> On Thu, 2023-04-06 at 15:04 +0200, Ivan Vecera wrote:
>> Remove an inability of bnxt_en driver to set eswitch to switchdev
>> mode without existing VFs by:
>>
>> 1. Allow to set switchdev mode in bnxt_dl_eswitch_mode_set() so
>>     representors are created only when num_vfs > 0 otherwise just
>>     set bp->eswitch_mode
>> 2. Do not automatically change bp->eswitch_mode during
>>     bnxt_vf_reps_create() and bnxt_vf_reps_destroy() calls so
>>     the eswitch mode is managed only by an user by devlink.
>>     Just set temporarily bp->eswitch_mode to legacy to avoid
>>     re-opening of representors during destroy.
>> 3. Create representors in bnxt_sriov_enable() if current eswitch
>>     mode is switchdev one
>>
>> Tested by this sequence:
>> 1. Set PF interface up
>> 2. Set PF's eswitch mode to switchdev
>> 3. Created N VFs
>> 4. Checked that N representors were created
>> 5. Set eswitch mode to legacy
>> 6. Checked that representors were deleted
>> 7. Set eswitch mode back to switchdev
>> 8. Checked that representros were re-created
> 
> Could you please update the commit message and re-post?
> 
> Thanks!

of course..

I.