Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5459402rwl; Tue, 11 Apr 2023 05:57:36 -0700 (PDT) X-Google-Smtp-Source: AKy350bOSZ4nzX1aI3wSxwrFArVJ8CxSCEkd4cltCf/9jnh3Z7z2DFwHAKdiy/TVRJkHab6Znv0V X-Received: by 2002:a17:906:3290:b0:885:a62c:5a5c with SMTP id 16-20020a170906329000b00885a62c5a5cmr9247835ejw.46.1681217856443; Tue, 11 Apr 2023 05:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681217856; cv=none; d=google.com; s=arc-20160816; b=ntFpuADRlWsi/oHRTcmxtBh98mLMF+7ufpLAxAbR2VRUR5C9Jufx0y2MW2Oq/Edu2C tZcY9GN+q6mxXV9hdi9ZeEkxy35gsD7X0uog73aSIHDJlZZG5V7oo6n3EuyxzjvhcOz/ 2LF13ya6vtKiaswLt0YWVgzUYOswO7FMUlbsSh5eY8C8R1tHVfrK+84TXY24OiAC3bJf O5gAMNY17IMFAv46KScaGrh4OiiTb5vMNryzJjcxqBRu2NHq3d19poHNXS10d5cZ1rXj mhZqhMwNOVB5+Bp2kAv4Vetg3jbCB7Cuy95OizUl7E089ruzuFIC4umtxV7vsTNhv6vN z8cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WFvtgGXh6gURF2Ev8feAnNkTzSGu1PeynGl1ztZC3/I=; b=C6Bt9wIg9s5EslfjQLvJrytcLx/9ATWYZVw1QfZ0CfrvGWhtFwtLFvtvrTvRtgQgq+ 77ryIgMMXBvzOu6Y0oahRz/Jirh/QN8b6GiAv4uFkCcy3Q/kdWaKz7HWaGs5OOd03d3g ivyGPlqUruSdu1lGEau798cRqF0eoPkfeeAbJmdEGj46CVK2MkiizHf/t5lOOXbceQyf Pd28SPNXzqShl27Hh5IDlz2qxgpSbCCuAbsx6OBWOSsPr0Bz+GOeeqH2D31EEnlozeEd BXu5DwL3ugIgvrYqbesLjTbGbAVLny3a6UwnvEoJPc6eZPOhakPvQuvnfWmh/3nWKesX pA1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=gw+qtOn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rp7-20020a170907888700b0094a4a4862afsi2016699ejc.695.2023.04.11.05.57.12; Tue, 11 Apr 2023 05:57:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=gw+qtOn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbjDKMpP (ORCPT + 99 others); Tue, 11 Apr 2023 08:45:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjDKMpO (ORCPT ); Tue, 11 Apr 2023 08:45:14 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D801FE4; Tue, 11 Apr 2023 05:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=WFvtgGXh6gURF2Ev8feAnNkTzSGu1PeynGl1ztZC3/I=; b=gw+qtOn3J1iPbXBg2DgKVfkTEC 79ACsGlkgXxvRmhNY5wt1JchiB3un/eyM8Hf4s0Pxuz+2F/Lv2Zf5/KlHzd+9IC4W0556rKPCnpo0 hAk7kt750ykZHjkb42MktCR8H3kdxs/8rCXjG/RDO+ySDO9PBio2O70PMvqETxsLE6bM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pmDMt-009zMV-54; Tue, 11 Apr 2023 14:45:03 +0200 Date: Tue, 11 Apr 2023 14:45:03 +0200 From: Andrew Lunn To: Paolo Abeni Cc: "Radu Pirea (OSS)" , hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: add remove callback Message-ID: <1c4c3085-f7e3-443b-8dfe-4cc19e85d9ad@lunn.ch> References: <20230406095904.75456-1-radu-nicolae.pirea@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Andrew: my understanding is that a connected phy, maintains a reference > to the relevant driver via phydev->mdio.dev.driver->owner, and such > reference is dropped by phy_disconnect() via phy_detach(). > > So remove can invoked only after phy_disconnect > > Does the above sounds reasonable/answer your question? Yes, that does seem logical. Reviewed-by: Andrew Lunn Andrew