Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 16:38:14 +0300
From:   Andy Shevchenko <andy@kernel.org>
To:     =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>
Cc:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        linux-kernel@vger.kernel.org,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@rivosinc.com>
Subject: Re: [RFC PATCH] checkpatch: Support __initconst combined with struct
 definition
Message-ID: <ZDVixjH5qLoy1jTW@smile.fi.intel.com>
References: <20230301094320.15954-1-bjorn@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230301094320.15954-1-bjorn@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Mar 01, 2023 at 10:43:20AM +0100, Bj?rn T?pel wrote:
> From: Bj?rn T?pel <bjorn@rivosinc.com>
> 
> Checkpatch sometimes report a false positive for __initconst. E.g., for the
> following snippet:
> 
>  | static const struct strspn_test {
>  | 	const char str[16];
>  | 	const char accept[16];
>  | 	const char reject[16];
>  | 	unsigned a;
>  | 	unsigned r;
>  | } tests[] __initconst = {
>  | 	{ "foobar", "", "", 0, 6 },
>  | 	{ "abba", "abc", "ABBA", 4, 4 },
>  | 	{ "abba", "a", "b", 1, 1 },
>  | 	{ "", "abc", "abc", 0, 0},
>  | };
> 
> checkpatch would report:
> 
>  | ERROR: Use of __initconst requires a separate use of const
>  | #190: FILE: ./test_string.c:190:
>  | +	} tests[] __initconst = {
> 
> Improve the reporting by trying harder to find the 'const'.

Joe, what do you think about this?

-- 
With Best Regards,
Andy Shevchenko