Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7af7475e-e8d3-6cf0-d879-4f9599bd1cfd@linaro.org>
Date:   Tue, 11 Apr 2023 14:30:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] ASoC: soc-compress: set pcm nonatomic flag from dai_link
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org
Cc:     tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org,
        Mohammad Rafi Shaik <quic_mohs@quicinc.com>
References: <20230411110831.813-1-srinivas.kandagatla@linaro.org>
 <14976031-7d63-4069-8647-3cee41064215@linux.intel.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <14976031-7d63-4069-8647-3cee41064215@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/04/2023 14:25, Pierre-Louis Bossart wrote:
> 
> 
> On 4/11/23 06:08, Srinivas Kandagatla wrote:
>> In compress offload case we never set nonatomic flag on a new pcm. This triggers
>> below configuration error with DPCM on Qualcomm setup where dai_links are marked
>> as nonatomic.
>>
>> "FE is atomic but BE is nonatomic, invalid configuration"
>>
>> Fix this by Updating the pcm nonatomic flag correcly from the respective dai_link.
>>
>> CC: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   sound/soc/soc-compress.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
>> index 554c329ec87f..a8d70274cab8 100644
>> --- a/sound/soc/soc-compress.c
>> +++ b/sound/soc/soc-compress.c
>> @@ -615,6 +615,7 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
>>   			return ret;
>>   		}
>>   
>> +		be_pcm->nonatomic = rtd->dai_link->nonatomic;
>>   		rtd->pcm = be_pcm;
>>   		rtd->fe_compr = 1;
>>   		if (rtd->dai_link->dpcm_playback)
> 
> isn't this fixed already? Daniel Baluta sent a patch for this, already
> applied by Mark:
> 

Thanks for pointing this, Yes, It is fixed in sound-next.. my branch was 
a week+ old so did not spot it :-)

--srini
> https://lore.kernel.org/alsa-devel/20230324124019.30826-1-daniel.baluta@oss.nxp.com/