Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220924073957.4140388-1-ruanjinjie@huawei.com>
In-Reply-To: <20220924073957.4140388-1-ruanjinjie@huawei.com>
From:   Karol Herbst <kherbst@redhat.com>
Date:   Tue, 11 Apr 2023 16:12:51 +0200
Message-ID: <CACO55tuDx0khsqgv6MBBnwKtcB-UwVLQYEfFah4f0WhOLHd0-A@mail.gmail.com>
Subject: Re: [PATCH -next] drm/nouveau/disp: make gv100_disp_core_mthd_base static
To:     ruanjinjie <ruanjinjie@huawei.com>
Cc:     bskeggs@redhat.com, lyude@redhat.com, airlied@linux.ie,
        linux-kernel@vger.kernel.org, daniel@ffwll.ch, airlied@redhat.com,
        dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Karol Herbst <kherbst@redhat.com>

On Sat, Sep 24, 2022 at 10:00=E2=80=AFAM ruanjinjie <ruanjinjie@huawei.com>=
 wrote:
>
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning:
> symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c b/drivers/g=
pu/drm/nouveau/nvkm/engine/disp/gv100.c
> index 6b9d49270fa7..347c12a1fcb7 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c
> @@ -587,7 +587,7 @@ gv100_disp_curs =3D {
>         .user =3D 73,
>  };
>
> -const struct nvkm_disp_mthd_list
> +static const struct nvkm_disp_mthd_list
>  gv100_disp_core_mthd_base =3D {
>         .mthd =3D 0x0000,
>         .addr =3D 0x000000,
> --
> 2.25.1
>