Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Apr 2023 10:58:47 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v3 3/3] counter: 104-quad-8: Utilize helper functions to
 handle PR, FLAG and PSC
Message-ID: <ZDV1p36N3wCav/vF@fedora>
References: <cover.1681134558.git.william.gray@linaro.org>
 <669c8f782f11fe27c4568e4fc3ba459c4f954874.1681134558.git.william.gray@linaro.org>
 <ZDVli05x7u/bg7Zc@smile.fi.intel.com>
 <ZDVpJb9DyIU+5eJf@fedora>
 <ZDVyJV8TfC31TYP2@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gFuETjZ/k9bxpdFT"
Content-Disposition: inline
In-Reply-To: <ZDVyJV8TfC31TYP2@smile.fi.intel.com>
Precedence: bulk


--gFuETjZ/k9bxpdFT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 11, 2023 at 05:43:49PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 11, 2023 at 10:05:25AM -0400, William Breathitt Gray wrote:
> > On Tue, Apr 11, 2023 at 04:50:03PM +0300, Andy Shevchenko wrote:
> > > On Mon, Apr 10, 2023 at 10:03:13AM -0400, William Breathitt Gray wrot=
e:
> > > > The Preset Register (PR), Flag Register (FLAG), and Filter Clock
> > > > Prescaler (PSC) have common usage patterns. Wrap up such usage into
> > > > dedicated functions to improve code clarity.
>=20
> ...
>=20
> > > >  	*val =3D 0;
> > >=20
> > > Is not needed now as always being initialized by below call.
> >=20
> > The regmap_noinc_read() call only reads the number of bytes requested.
> > Since we request 3 bytes, the upper bytes of the u64 val remain
> > uninitialized, so that is why we need to set *val =3D 0. This isn't
> > immediately clear in the code, so I can add a comment to make it
> > explicit.
>=20
> Hmm...
> Since we are using byte array for the value, can we actually use
> memset() to show that explicitly? Perhaps in that way it will be more vis=
ible?
>=20
> > > >  	spin_lock_irqsave(&priv->lock, irqflags);
> > > > =20
> > > >  	iowrite8(SELECT_RLD | RESET_BP | TRANSFER_CNTR_TO_OL, &chan->cont=
rol);
> > > > -
> > > > -	for (i =3D 0; i < 3; i++)
> > > > -		*val |=3D (unsigned long)ioread8(&chan->data) << (8 * i);
> > > > +	ioread8_rep(&chan->data, val, 3);
>=20
> But hold on, wouldn't this have an endianess issue? The call fills in LE,
> while here you use the CPU order.
>=20
> > > >  	spin_unlock_irqrestore(&priv->lock, irqflags);
>=20
> That said, I think you should have something like
>=20
> 	u8 value[3];
>=20
> 	ioread8_rep(..., value, sizeof(value));
>=20
> 	*val =3D get_unaligned_le24(value);
>=20
> --=20
> With Best Regards,
> Andy Shevchenko

Yes, I think you're right, that solves both problems at once so I'll use
get_aligned_le24() to set *val.

William Breathitt Gray

--gFuETjZ/k9bxpdFT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZDV1pwAKCRC1SFbKvhIj
K2kMAQDrWJPvMhPcHbdWvH5AkY0ad7jOK/SX/wZ3onxHUaOz7gD/YS6aHONzpLYQ
A2jVwk6XOn1NF2BILQcKRTPvWCls9gQ=
=VkrK
-----END PGP SIGNATURE-----

--gFuETjZ/k9bxpdFT--