Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <96ad9a58-00c8-1bb3-06d6-841e7ea41488@intel.com>
Date:   Tue, 11 Apr 2023 08:06:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH V2,net-next, 2/3] net: mana: Enable RX path to handle
 various MTU sizes
Content-Language: en-US
To:     Haiyang Zhang <haiyangz@microsoft.com>,
        <linux-hyperv@vger.kernel.org>, <netdev@vger.kernel.org>
CC:     <decui@microsoft.com>, <kys@microsoft.com>,
        <paulros@microsoft.com>, <olaf@aepfle.de>, <vkuznets@redhat.com>,
        <davem@davemloft.net>, <wei.liu@kernel.org>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>, <leon@kernel.org>,
        <longli@microsoft.com>, <ssengar@linux.microsoft.com>,
        <linux-rdma@vger.kernel.org>, <daniel@iogearbox.net>,
        <john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
        <ast@kernel.org>, <sharmaajay@microsoft.com>, <hawk@kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1680901196-20643-1-git-send-email-haiyangz@microsoft.com>
 <1680901196-20643-3-git-send-email-haiyangz@microsoft.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <1680901196-20643-3-git-send-email-haiyangz@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXJib205QlQ4SmZNVStINExXSFNrdTdTMmd1ZHJiWFFPR0ZYSHlxMWVyMlN0?=
 =?utf-8?B?d0x3dFlSY25ocUM0ZkZMRzQ4bUR6U0pueEVtSUE0STBEL0RKTXRVN01PY3ZB?=
 =?utf-8?B?WHBjNWpLdW1tM2hON0E5OUh1MHliZC9ITStjbGlkbXJVdDVwZnFrVzNmUzl5?=
 =?utf-8?B?ZGRST3AzY3pNNkMxZFhaQTlTd2k1MWR1TUc1OWp4a3FXOWhOaUlXcnlmMCt5?=
 =?utf-8?B?LzJNSUtEbkkyMW1iWFl4Yk9aRTltT1RPRlpXV3l1dGloeW15ZlpIZ0F3Z3dD?=
 =?utf-8?B?cFBobXo5aGhEWTV6bWx2dUxZYjNxVWV4TmMyQU1UQmhraDJrMnBOMy8wOHJ3?=
 =?utf-8?B?WnpFUC91a3FDdS8wSk9Fdk5nWXkwWS9zcUljT2k0akJXWW9SdTFMUVBFb2NL?=
 =?utf-8?B?RXh6c3JSYzFVWm1YdFZwUGdyR1kyclRPYlV5ckFEODJobDFwbGlERnU5QWZn?=
 =?utf-8?B?MEticWxwUWo0NmIxTmNKeXBReUhXMmVTVGJlUzNob05LUFB4ajEreElpVjJG?=
 =?utf-8?B?QUlOQUE1VXlycXFrNjRGTVNFMThRVlovOThTYlo5Z3d0ZU5xMS94SW5CdXZR?=
 =?utf-8?B?TzROT0hpRlliRWZoWTUwNitvczRuVlF3NGpCVUUyZjQxNUpMVVhVUEtvdVlQ?=
 =?utf-8?B?amVQRzI3SjF5cHhMZjgyQi8zWmZJdXhramdzSFdhb0RieTBTdVRSazZBQjBK?=
 =?utf-8?B?UmxkTFpLZTV2NkVxNy9ZZUt6MXNxWmFhbW1xMzdvdll0ejRUZDlKY09CN2xx?=
 =?utf-8?B?RzZWNWJTRHpMbXoyckJQVXpuV2wxd2lPdGd0amhwVGtTcExLVDJieHdJLzdS?=
 =?utf-8?B?MDBSdnhZNVFEd09MVktPSER2WFcwTVc5Yyt0MlJQUU1rL2pQcis5SmFROUVl?=
 =?utf-8?B?Y1RpK2J1UTJSSkoxTnZIT0ZtRi9NV2tMVU1vYnhkWlFRdE5JZUp0T2liWGZj?=
 =?utf-8?B?QXJ0UTVKQmZZVTRhTGdnMW4yUE9TK0xhYWJ2S21vV2JQNml1RmYwblJTT3B6?=
 =?utf-8?B?OUtmdjFnTzcxK2xKMXVWR1B3elUwRG1uMVIwcGR1VnRJU1RIV1UwRjV2eUtC?=
 =?utf-8?B?K1cvNTRVcWRqVkZUT21ZeG5iOHBsbG93ZHNmS1FxMUFEaERnaDhsVWVFM0k3?=
 =?utf-8?B?SEVpMUd0Sk1oMFZETHFNMW9Ma28vY0NxRUZ5Q1QrRTkwdndWbHRnSEQyREFP?=
 =?utf-8?B?YkVmUEtQcVFjbHlYaVlTR2JoR25QcW1Cb1k3Q0dUc0dCeTI4eWUvRk04WmE3?=
 =?utf-8?B?Ly92OVJmbDFqK0lHanRYSUxoN3AwanRvdFZZQ3huUXZ6ZXY3aW42Wk5Pd0V0?=
 =?utf-8?B?ZzYxQ0U4SkQvc1dObXRxd0NMZlhqRlFDOHM5c2V5N2FTZ01pdUZDU1NNbzNP?=
 =?utf-8?B?K1ErQkZuUGUzRHdmS0dIT2hnSEdmNVR5WkRObXpoRlIva2FjdXU3dWxsbDNu?=
 =?utf-8?B?bndML1MzNU1GQWZxTTY4V2oxZmNmUnVVdUxhQWZISW1iZ3ZwNkE5Z3o1cm9B?=
 =?utf-8?B?NVJTWEFDQ3BpZ3NPa1k4dEJyK2dwTFU5UzdPVThDNXJ1akxUZ01jVFpXWXc5?=
 =?utf-8?B?Uk5OaDNONnEzUG5XbTJIc3QzN3NrV0VONzJzTE4xRHB1dExiajlUZXhEL0Jz?=
 =?utf-8?B?VWxGclFEcWs3dFVZZU5HcE1OQUJxVWFUd3lQSlhQSVN1THNWaUpLY3gvMFdZ?=
 =?utf-8?B?OFMyOUhxdDU3eE5ESm9JY2w2VVdsWEU3dlo5eERNNUFEOW8zUENESnpKVnJ6?=
 =?utf-8?B?ZHNhZVZ3SXhIVDBvYi9xWmNXeXo0YngydVVZK0Q5NXdQZGFVU0hSVU5vWmg4?=
 =?utf-8?B?QTNQdUdXMHd5MFRnYThtamFsM05ZRjY5MDBXR0prQ0dqSUg3RUFvNVRyMnVV?=
 =?utf-8?B?TmVYOVpXdXFLUkdoVEppQjdFTnh6WkJOVFl5ekFTdFRyZFYrVm56TGc4TG91?=
 =?utf-8?B?QUErMUF0bE1qYWNEMFVwb2d2NnUzN05QY3JIMlI1YzhkbEdHRFRPTDJQSWdJ?=
 =?utf-8?B?a21ZWTZyMkpEbmxaZ2VVS0dYWlEwSS8rRFcrQjI4bU95R21oWVVYWS92bStz?=
 =?utf-8?B?MFpwNWNuNForalhKU3B4clFqc3g3ODNvZEg0TnhJZG9lOGFpU3lIcjNJeTlL?=
 =?utf-8?B?b0c5WktKWWpVemlmWDNsWEk4Z1NuZ2p3VFRVNVduZG84ZHVvU3ZITjQ5RW1q?=
 =?utf-8?B?QlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 57cd4078-e57a-49fc-bb3a-08db3a9e56aa
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 15:06:33.9227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KtsGKPonyPT1Pc/cxLIxf0DxCHvTl+do+aXZukwHReNyBUwzVeVt4i76JNefHkC99SAHFMKJBzWyqByoctsvN1WzQLhtQ9ev04olluZynOw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4601
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/7/2023 1:59 PM, Haiyang Zhang wrote:
> Update RX data path to allocate and use RX queue DMA buffers with
> proper size based on potentially various MTU sizes.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> 
> ---
> V2:
> Refectored to multiple patches for readability. Suggested by Yunsheng Lin.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

One tiny nit below, but not worth a respin.

> @@ -1764,6 +1798,7 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc,
>  	struct mana_obj_spec wq_spec;
>  	struct mana_obj_spec cq_spec;
>  	struct gdma_queue_spec spec;
> +	unsigned int mtu = ndev->mtu;

This one isn't quite RCT order. I'd only change it if you have another
respin for some reason.

Ha, I see you remove that line in the next patch, never mind...