Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a1be32f-452b-1bbb-00bb-5bc0ed5c3377@intel.com>
Date:   Tue, 11 Apr 2023 08:06:27 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH V2,net-next, 3/3] net: mana: Add support for jumbo frame
Content-Language: en-US
To:     Haiyang Zhang <haiyangz@microsoft.com>,
        <linux-hyperv@vger.kernel.org>, <netdev@vger.kernel.org>
CC:     <decui@microsoft.com>, <kys@microsoft.com>,
        <paulros@microsoft.com>, <olaf@aepfle.de>, <vkuznets@redhat.com>,
        <davem@davemloft.net>, <wei.liu@kernel.org>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>, <leon@kernel.org>,
        <longli@microsoft.com>, <ssengar@linux.microsoft.com>,
        <linux-rdma@vger.kernel.org>, <daniel@iogearbox.net>,
        <john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
        <ast@kernel.org>, <sharmaajay@microsoft.com>, <hawk@kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1680901196-20643-1-git-send-email-haiyangz@microsoft.com>
 <1680901196-20643-4-git-send-email-haiyangz@microsoft.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <1680901196-20643-4-git-send-email-haiyangz@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFBvZU12UjM0M04wOUlxK3BEUUxpdTUxTFZzbXlWYmhPSkttUUZMTGhhNTRu?=
 =?utf-8?B?ZjRyN2YvRzBSbjA2UUgwQklHZjh2b2RUdFYrS1ZIS2xzQTdKaXArcEdzYnNS?=
 =?utf-8?B?TUZua2hYT3NPaXY1d2tZa1JBMThjcHRqS09aRmhMYnBVRUhnVTZQYmpEeG9t?=
 =?utf-8?B?QVlqZC9Bd1JUa0QxYkxiZlE2K1daeWYycVpRcjhITFFZOHp5RVE5b3F6bUVX?=
 =?utf-8?B?eWhnd21Pa3k1ejdQUjJNUXJyZUMwL2U3dlJ3WGJ0NXlDWjVCUGJhZ3kzM0RO?=
 =?utf-8?B?YVZFNHhVRElpdmduQWZma1J6a0hJMUdzNUpxNlhWMVhQeHROaUYrN01PMnlj?=
 =?utf-8?B?aHYyOVRIUFRxZTRtOW5QTjY5LzdDOE90akRIN1p0M2hSelFlM0gvRWdySzUz?=
 =?utf-8?B?NjZ6eHFIejlrM3kvM2FQZlprUS9QdHZFaEhud0g5cG40Y1l6YzA3ZXJQNmJG?=
 =?utf-8?B?bWxRVG1zRTRQOXN0N1FPTG5MclRVMmQ0OGZ3TVViVmljWEZFYUVNRjJQdmpR?=
 =?utf-8?B?Mnk5R1R0K2RseUZiUmQ1T3JFZWg0YU5oa3dBNGVOa0tPUmNodUZNT1p2aVpJ?=
 =?utf-8?B?bU9WWHJEQUtCOEo4OHdmaCtvalBHb2EyYUlKdk9QVGN1SlFpWnpYdTJsT1Rz?=
 =?utf-8?B?b0o0NG9VR05uNkNNZWE2V09KaEoyK3c1aktmWVprb0VyOGMrZmc1M3hYUGVT?=
 =?utf-8?B?SkdyZCtUeC8yR0ZxandiRkR5SWlzSEVDbG5uRFMvdHNiTG5iTmRodXhCYUpJ?=
 =?utf-8?B?NVlWbU95WnhwK0l2OEkycVhOcDR5S0o2N2toV0RsVUtKM2FETC9rUTFvK1Vv?=
 =?utf-8?B?U0czZWpEaExKbVZHQjdiRWNHWTYwYklRNm4yeW0ya3p4SytzWjhjZDNCVXRP?=
 =?utf-8?B?K1NnbFdMWngvV2FjZlZ5eVZsR0ZzMzhmbFU0SUNnRENDdjE0V0NQU0lxY2ZG?=
 =?utf-8?B?OHRKWG01UkNZbW5KUFdsdmZNZ01xL1FWRzR5NUIrL2pHdHdqck9GUnhiYWJT?=
 =?utf-8?B?cktoanZOaWpuZFVVT3RQNmlRZFZPUmUrZFVTNmE3YjhHRDYyRHZSaUgxTmN0?=
 =?utf-8?B?QlNzZVB6TytBbXZSc2tpN012Q29zZFJGeUNvYTFpZnBnR3ltQmh1SWFsYy90?=
 =?utf-8?B?Tmo2Z1dmbVJnMC9MclhiZkhrVDNxVXJRSm5ISzdaQ0l2UEZRMEJBY1h1aHp4?=
 =?utf-8?B?ZWdMQlMvRmFySmRjQStuTG1MLy9KcmF0R1VySkk0SDI4Mm1Da1FqK2MvcW1U?=
 =?utf-8?B?TDRQNVpNb2xtVHBDMW5jcHI4RFk2V2w1cEpWYzJsQlJBU1Y1Nm1ycGxVd0dI?=
 =?utf-8?B?V2xNczIzcFF2WmVGWFdVZkpmSC9STFRIS2dOYWd4UUcycEFaUW5JUUN2bFRX?=
 =?utf-8?B?YkU2dDg4SWpTbDZ5c0xzMytoZ3E2aWpISTZCUWVHWjVtLzkwMGpyZDR3NE5w?=
 =?utf-8?B?am1mWVdEQUVzc1BaYmU2cDJ1ZUM0YXpyWVdPV0oyVUFueHFhUlVGSVdTRVRU?=
 =?utf-8?B?MTZXQWNBeWRQSElJMWVvT21IUDkwSlFIeDJIMWhSYXlJQ3k4dzdHN3lHNDhO?=
 =?utf-8?B?dFVqbWxLWmVUekxVOVNHUG9sSzM1bEp3RzMyRi9uZkVlZzNqNHRDbG0vVE5t?=
 =?utf-8?B?UVZKcnBXaWNNWUgyanU0aGVBbEZ0R0ZyUjlaSG1lTjFJT0lpck16Rk5TTXZu?=
 =?utf-8?B?WkZ1ZVpmTmZPRnpDUXdvem9jSUd0Vk1NNE82T0hsSzZHZlg0N1RKREdwWmhB?=
 =?utf-8?B?R2ZzSm94WmlCQkVYNHNHTjJuMnc1YVloS0FKSjhUK1F6OHNXOEF3MmJPaEpw?=
 =?utf-8?B?c1phWTZGa2xrWUg3VFluRkV3QVFQbUhFNmljV2dOQlBuTks1NmlnVFBHVEdw?=
 =?utf-8?B?S21hMDJMVG55WGpCUTBKVDhNemo4MXY4dm1pdm1Bc0g5bER5NkxaOEJHNnZw?=
 =?utf-8?B?RWdwT2dYZ09vOGcvYmVOMHVzZ2hyOHMxN3hNaWljL1VqRnU0S1pZN0h6LzJm?=
 =?utf-8?B?Qi9teFRockh3aWpEN1FCaCtQbGR5ZnBwRzlVVFlLUVpPT2EyNVpRaG9iWXlH?=
 =?utf-8?B?RERNMDlKN0c3YWsvN2xaWndRS0ozVU41MWNKWUxiR2N2a3NnT25kSW52UjNP?=
 =?utf-8?B?WlU5ZGRHbmlob3hrTW52UDdjVUV4azZ1V0VSRnBkQWVIWFJLaEh5bGxjVTh3?=
 =?utf-8?B?TlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e3662e0-cf5d-4dda-9fcc-08db3a9e5494
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 15:06:30.3663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0rZS5Ns7TF9ADuHHPaNk/D76Z98qxo06ePZn/fABQNo65/I/4wOBAgIbO3QR8wFTzabUf+EdaDJIupPYcVK+JZNbGdsVqHjQ42zs//ljqSU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4601
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/7/2023 1:59 PM, Haiyang Zhang wrote:
> During probe, get the hardware-allowed max MTU by querying the device
> configuration. Users can select MTU up to the device limit.
> When XDP is in use, limit MTU settings so the buffer size is within
> one page.
> Also, to prevent changing MTU fails, and leaves the NIC in a bad state,
> pre-allocate all buffers before starting the change. So in low memory
> condition, it will return error, without affecting the NIC.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>