Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef815d11d8514f1d53bcb55d4acbcbac518cd603.camel@collabora.com>
Subject: Re: [PATCH v5 13/13] media: AV1: Make sure that bit depth in
 correctly initialize
From:   Nicolas Dufresne <nicolas.dufresne@collabora.com>
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
        mchehab@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
        hverkuil-cisco@xs4all.nl
Cc:     linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
Date:   Tue, 11 Apr 2023 11:26:50 -0400
In-Reply-To: <20230330154043.1250736-14-benjamin.gaignard@collabora.com>
References: <20230330154043.1250736-1-benjamin.gaignard@collabora.com>
         <20230330154043.1250736-14-benjamin.gaignard@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Le jeudi 30 mars 2023 =C3=A0 17:40 +0200, Benjamin Gaignard a =C3=A9crit=C2=
=A0:
> Make sure that bit_depth field of V4L2_CTRL_TYPE_AV1_SEQUENCE
> is initialized correctly before using it.
>=20
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
>=20
In v6, can you move this patch earlier ? I'm having bisection in mind. With=
 that
being said:

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

>=20
> ---
>  drivers/media/v4l2-core/v4l2-ctrls-core.c | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4=
l2-core/v4l2-ctrls-core.c
> index 9fd37e94db17..a662fb60f73f 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c
> @@ -111,6 +111,7 @@ static void std_init_compound(const struct v4l2_ctrl =
*ctrl, u32 idx,
>  	struct v4l2_ctrl_vp9_frame *p_vp9_frame;
>  	struct v4l2_ctrl_fwht_params *p_fwht_params;
>  	struct v4l2_ctrl_h264_scaling_matrix *p_h264_scaling_matrix;
> +	struct v4l2_ctrl_av1_sequence *p_av1_sequence;
>  	void *p =3D ptr.p + idx * ctrl->elem_size;
> =20
>  	if (ctrl->p_def.p_const)
> @@ -157,6 +158,10 @@ static void std_init_compound(const struct v4l2_ctrl=
 *ctrl, u32 idx,
>  		p_vp9_frame->flags |=3D V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING |
>  			V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING;
>  		break;
> +	case V4L2_CTRL_TYPE_AV1_SEQUENCE:
> +		p_av1_sequence =3D p;
> +		p_av1_sequence->bit_depth =3D 8;
> +		break;
>  	case V4L2_CTRL_TYPE_FWHT_PARAMS:
>  		p_fwht_params =3D p;
>  		p_fwht_params->version =3D V4L2_FWHT_VERSION;